From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2918C433FE for ; Thu, 12 May 2022 23:23:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359427AbiELXXU (ORCPT ); Thu, 12 May 2022 19:23:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351389AbiELXXR (ORCPT ); Thu, 12 May 2022 19:23:17 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 088E512699C for ; Thu, 12 May 2022 16:23:16 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id s18-20020a056830149200b006063fef3e17so3803228otq.12 for ; Thu, 12 May 2022 16:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DdarBLYiMi2x7VgSAd/PCBnk6aZfFSV1j4amo34R1lo=; b=apzVBSTvVnFdVTUoPIDKPGqyCmAjRvkf6rI3Tktq7k7wvOuqA+G57qzpEtiK76kJmf LUfv77v/SDogQR8NwrwveKgXXJpK7D0bcaC5ELR0Er6I1I+oVXefpFegbV9MdH63NtrY d0AzRSpIqHI/VYzyuba4+NehsoFz6Q8QQGZLz4xBEBBgunNH75/CQBqk/gnedfzNSJmm wC6X3AtnEhrMqeMt4kQPSUJVdlZdwmzk5x0RZ/g1Nk4iVLMeEcA3mKSaAE0DiML+G0EG TBJ9BA1BCYReA9MHPJlqM4wSoQ2Nt072zGgOT7b/M8eqTe50EC8CB1bwLeI0NnEgLzcF eoIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DdarBLYiMi2x7VgSAd/PCBnk6aZfFSV1j4amo34R1lo=; b=W31fkQLLTpRVE40qMuN5ZPwX+/qQlBAFnPUYwWlTbNcsemfX1sHeUVVBQO5RxyNJTo kQd1c9jiVQWmVS69mML6upHIy6hpuf6vhBBTwEZ51/PYCNzDSM4CIX1THZZMZ8wb6oQd Ktp33zpUyEJPlpLI9rMuBKMfydAztJug6/UIi3rdh9/ERHFKYxz8+bLX9sz1UFzkIH1r ms+0qdrpOJ542je2MJDFjYlO7kmkym3o+c1Z+VeB383uZnG5TjUBk+QblfHuNJUC+V5Y q3I7hD7X96ViAJxxRzpF2uv9zvwRQCRYS8mRpR5YakwI8JL+ztQJWovuWJ/O/nOynmH7 4J6g== X-Gm-Message-State: AOAM533qWXBo7I0mbD/Q4N7fIyQ6eRR1JuQt6HGfEnV1Q+Tiea/yMunZ 3L9j9ZaouifnWQ6npQRvBv0LmSwekmQHXL2nCZY1pQ== X-Google-Smtp-Source: ABdhPJxR83dsw2D24e4NsRpwGRgwD6lMR3f1zsIUpSEV4D3/p9QeXVVifJHVHC3rS+x5S68Pt26SfdlwVssdYLtQ/N8= X-Received: by 2002:a05:6830:1c65:b0:606:3cc:862 with SMTP id s5-20020a0568301c6500b0060603cc0862mr875905otg.75.1652397795090; Thu, 12 May 2022 16:23:15 -0700 (PDT) MIME-Version: 1.0 References: <20220512222716.4112548-1-seanjc@google.com> <20220512222716.4112548-3-seanjc@google.com> In-Reply-To: <20220512222716.4112548-3-seanjc@google.com> From: Jim Mattson Date: Thu, 12 May 2022 16:23:04 -0700 Message-ID: Subject: Re: [PATCH 2/3] KVM: x86: Use explicit case-statements for MCx banks in {g,s}et_msr_mce() To: Sean Christopherson Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Jue Wang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2022 at 3:27 PM Sean Christopherson wrote: > > Use an explicit case statement to grab the full range of MCx bank MSRs > in {g,s}et_msr_mce(), and manually check only the "end" (the number of > banks configured by userspace may be less than the max). The "default" > trick works, but is a bit odd now, and will be quite odd if/when support > for accessing MCx_CTL2 MSRs is added, which has near identical logic. > > Hoist "offset" to function scope so as to avoid curly braces for the case > statement, and because MCx_CTL2 support will need the same variables. > > Opportunstically clean up the comment about allowing bit 10 to be cleared > from bank 4. > > No functional change intended. > > Cc: Jue Wang > Signed-off-by: Sean Christopherson > --- Reviewed-by: Jim Mattson