From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC339C33C9E for ; Mon, 6 Jan 2020 20:17:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0B72207FF for ; Mon, 6 Jan 2020 20:17:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="clap+ZSl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726969AbgAFURu (ORCPT ); Mon, 6 Jan 2020 15:17:50 -0500 Received: from mail-io1-f68.google.com ([209.85.166.68]:33098 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726713AbgAFURt (ORCPT ); Mon, 6 Jan 2020 15:17:49 -0500 Received: by mail-io1-f68.google.com with SMTP id z8so49947674ioh.0 for ; Mon, 06 Jan 2020 12:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ns8GnqwvJg6p4W/syDLUnvePjgs3xerHY20r9Gnc+74=; b=clap+ZSlRXw7zp6m90XHVxIDTEjjE9mcltqn7nwhdOy1qAuizA7p54MDYDj3llqhCi nJzjNDYwgjjHbTHFIIjbXd9dbOFEWGnu0h83h98/mByZ9oQizwnh0Y5O0zE4RXdBf2E+ 8YrSYyt7ItVEBkpoa5mDBPnC50hGe0Gus6v0OSA9Va1MDXhWqTJxCeN7Cz8XtS890KKT NmByMQvlHmLA6ZVfU3rg/ij2JzS7BlH9Exko0AolIcxWcx521GuR3QaU+OCjwIjF9lx9 /OYjh5668bwPU952Ni87MV/24z2NHt8c/rW0AQ06SmzZtKB/BqiJWof+ycJDMSFnQVrW pq6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ns8GnqwvJg6p4W/syDLUnvePjgs3xerHY20r9Gnc+74=; b=neKXrQoF4hl1kKWAvs8FV2EGletlmedqS9TDndB0h81IZiUEi1GAPEj0Ua8+PVNNgf Vw9/ilZwsEXdFjTamfIFIkHUbvX301Lq9aDjqiQA4oi193lq4bNKZgtyR6Fo+eeCTjG4 lN2af6yM90WNrEXzsRMPLwursTVxwcztTG8M3xnkQI0Vgs4CoetaQDmPNdcoylJqVlWS NCGRMad/tb/GHjJw36fgqZLLCko+cJMJLO6nwoexnFLUMtVKTbHfIGs+roJe3HlOrKes Mx9a80W5VgiuvIFmBVQ4QE+FP3ZBRkt+5x4Wur1iLA0eCrO4UoAF6nZ0rfdUC1Tzi36M a4KA== X-Gm-Message-State: APjAAAXXGImXdOa14LdWHJePzqLKDZtQKd9QAuHR+EGlz3RqbSnG8l4i G4FSQadElCh7/xnXV4pt6y8pMJewhYs+TrF4mdNc1g== X-Google-Smtp-Source: APXvYqxoZQ+6xjPL1kVSOGms8Zqaps/r0K/FNO33q2IPJVDh7QsN/goJF73XELIobJtwflx3BGbam+GNuwZyL1L5h7E= X-Received: by 2002:a5e:924c:: with SMTP id z12mr69658990iop.296.1578341868753; Mon, 06 Jan 2020 12:17:48 -0800 (PST) MIME-Version: 1.0 References: <20191211204753.242298-1-pomonis@google.com> <20191211204753.242298-6-pomonis@google.com> In-Reply-To: <20191211204753.242298-6-pomonis@google.com> From: Jim Mattson Date: Mon, 6 Jan 2020 12:17:37 -0800 Message-ID: Subject: Re: [PATCH v2 05/13] KVM: x86: Protect ioapic_write_indirect() from Spectre-v1/L1TF attacks To: Marios Pomonis Cc: Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "the arch/x86 maintainers" , kvm list , LKML , Nick Finco , Andrew Honig , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 11, 2019 at 12:48 PM Marios Pomonis wrote: > > This fixes a Spectre-v1/L1TF vulnerability in ioapic_write_indirect(). > This function contains index computations based on the > (attacker-controlled) IOREGSEL register. > > This patch depends on patch > "KVM: x86: Protect ioapic_read_indirect() from Spectre-v1/L1TF attacks". > > Fixes: commit 70f93dae32ac ("KVM: Use temporary variable to shorten lines.") > > Signed-off-by: Nick Finco > Signed-off-by: Marios Pomonis > Reviewed-by: Andrew Honig > Cc: stable@vger.kernel.org Reviewed-by: Jim Mattson