From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yafang Shao <laoar.shao@gmail.com>
Subject: Re: [PATCH net-next] Revert "net: init sk_cookie for inet socket"
Date: Tue, 24 Apr 2018 23:59:11 +0800
Message-ID: <CALOAHbAEO=XmxPoV0gyeqYAAzEE5WtaT9uh5TUSAJ0Q+XuHZ8g@mail.gmail.com>
References: <1524571537-9781-1-git-send-email-laoar.shao@gmail.com>
 <29dbd735-5fd7-d4e4-288f-220f2075b645@gmail.com> <CALOAHbASsC7TMfrQPY38AmVYfwmTmEj5Ju71Z0Wpv29O7HZk5A@mail.gmail.com>
 <26914c29-d248-5197-9e3c-fc44a1f5a1a8@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-io0-f193.google.com ([209.85.223.193]:42344 "EHLO
        mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751155AbeDXP7w (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 24 Apr 2018 11:59:52 -0400
Received: by mail-io0-f193.google.com with SMTP id a10-v6so5334247ioc.9
        for <netdev@vger.kernel.org>; Tue, 24 Apr 2018 08:59:52 -0700 (PDT)
In-Reply-To: <26914c29-d248-5197-9e3c-fc44a1f5a1a8@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Apr 24, 2018 at 11:49 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>
> On 04/24/2018 08:12 AM, Yafang Shao wrote:
>> On Tue, Apr 24, 2018 at 8:38 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>>>
>>>
>>> On 04/24/2018 05:05 AM, Yafang Shao wrote:
>>>> This revert commit <c6849a3ac17e> ("net: init sk_cookie for inet socket")
>>>>
>>>> Per discussion with Eric.
>>>>
>>>
>>> I suggest you include a bit more details, about cache line false sharing.
>>>
>>
>> Coud we adjust the struct common to avoid such kind of cache line
>> false sharing ?
>> I mean removing "atomic64_t  skc_cookie;" from struct sock_common and
>> place it in struct inet_sock ?
>
> The false sharing is not there, it is on net->cookie_gen
>

Yes.
This is the current issue.
May be we should adjust struct net as well.

Regarding sk_cookie, as it is only used by inet_sock now, may be it is
better placed in srtuct inet_sock ?

Thanks
Yafang