From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2835C433EF for ; Wed, 13 Oct 2021 05:22:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8FC6960F23 for ; Wed, 13 Oct 2021 05:22:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8FC6960F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 2E39D6B0071; Wed, 13 Oct 2021 01:22:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26D646B0072; Wed, 13 Oct 2021 01:22:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15B7F6B0073; Wed, 13 Oct 2021 01:22:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0067.hostedemail.com [216.40.44.67]) by kanga.kvack.org (Postfix) with ESMTP id 084316B0071 for ; Wed, 13 Oct 2021 01:22:48 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A8AD6182221D9 for ; Wed, 13 Oct 2021 05:22:47 +0000 (UTC) X-FDA: 78690269574.25.FECFBB2 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by imf13.hostedemail.com (Postfix) with ESMTP id 54F69103B567 for ; Wed, 13 Oct 2021 05:22:47 +0000 (UTC) Received: by mail-io1-f51.google.com with SMTP id q205so1420549iod.8 for ; Tue, 12 Oct 2021 22:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Oa8nmy5+PpWHs7fh7beTLOa12EG7JGd+R/I+01DgP4w=; b=FuOzOkIPJolBjVsg7HFvo1OAPXaJvanbvR3+0P98c/SAROE5Q40Mt6Q0gU425m0mk/ s8sZlk7wNJALEXLVWWPIeO9lFOCODH9yTGD1BPtae/YC2PdY8qSzNBXlkeG/YlqErfoT k0SkRRlq+41PzQQkENChm6ChgVaX2XNlJF4PF/FdrYNVomrdTGfCQG8jj8sV4CdnsjUc YIFTGmWkPLlkbXptlxDxEv5nDbnYhW9TF/9Mqm81p5LkJvtS1RXtZfxrW9NJ0KBkWLA2 j4TaHKtqly9yHfMEMDGkQ1GyQIjrXwEFVPOVZ1RvxFu4GtWArCAFbx4/0yD29YPwkJcw 1Qng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Oa8nmy5+PpWHs7fh7beTLOa12EG7JGd+R/I+01DgP4w=; b=7jzFwnuP0Y3sf1eTq5fMRu1tCy0JZCkS8pLCOtnbs3Oj1hguTzI4C5qucwWSMJfpKF KHX5X1xwbAlOU14y7w8fVRfYA2BSCfPU/wVqLOXZvimJEVX/fM0DyEO5rrSe44ZhxUna ZDYaNzKanQMZ4HHWXuKmuojekr8SHRN8XmrWl92W1Xbms51dr1imp8PeNPUUzzX8m7i/ /aolfk2R3duy26D5wpnVYWytvV3kS5Jyfw0MNhoyK6jRbj4OFXtrM2MbI9gUk4NQuypw XJ2pvdDkVPch6FjwBXHOrqUEwqTm1r0aRcEgSUPRYuWUofVxz2yk73qZAiZd5SKI1gAi NqTQ== X-Gm-Message-State: AOAM530haNuQ+weoYespJ0B0D+4z7B9XdR9J1WAQOz5fkVL+CkimcBej 1PeWafrsg8fRNPH6kqIFJ65CH/GJgeXFUOzvuMaBN/dwOit/4A== X-Google-Smtp-Source: ABdhPJzBf7pOj3SRmIDQluPo6NU56YU/O3gKFn4mWedkeCjIDcaj3e5NXPnaqFMeS9uFWz2124Sv4V0ySv/r0yYgUt8= X-Received: by 2002:a05:6638:35a0:: with SMTP id v32mr25765389jal.128.1634102566778; Tue, 12 Oct 2021 22:22:46 -0700 (PDT) MIME-Version: 1.0 References: <20211012182647.1605095-1-willy@infradead.org> <20211012182647.1605095-5-willy@infradead.org> In-Reply-To: <20211012182647.1605095-5-willy@infradead.org> From: Yafang Shao Date: Wed, 13 Oct 2021 13:22:10 +0800 Message-ID: Subject: Re: [PATCH 4/5] test_printf: Append '|' more efficiently To: "Matthew Wilcox (Oracle)" Cc: Sergey Senozhatsky , Petr Mladek , Linux MM , Vlastimil Babka , Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 54F69103B567 X-Stat-Signature: qt14iheowhpam3znirwk7345yxrgjukz Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FuOzOkIP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.166.51 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com X-HE-Tag: 1634102567-945765 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 13, 2021 at 2:33 AM Matthew Wilcox (Oracle) wrote: > > Instead of calling snprintf(), just append '|' by hand. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > lib/test_printf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index 60cdf4ba991e..662c3785aa57 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -623,9 +623,9 @@ page_flags_test(int section, int node, int zone, int last_cpupid, > if (!pft[i].width) > continue; > > - if (append) { > - snprintf(cmp_buf + size, BUF_SIZE - size, "|"); > - size = strlen(cmp_buf); > + if (append && size < BUF_SIZE) { Should it be: if (append && size < BUF_SIZE - 1) ? > + cmp_buf[size++] = '|'; > + cmp_buf[size] = '\0'; > } > > page_flags |= (values[i] & pft[i].mask) << pft[i].shift; > -- > 2.32.0 > -- Thanks Yafang