From: Yafang Shao <laoar.shao@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Linux MM <linux-mm@kvack.org>, Vlastimil Babka <vbabka@suse.cz>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH] vsprintf: Update %pGp documentation about that it prints hex value
Date: Fri, 29 Oct 2021 10:18:29 +0800 [thread overview]
Message-ID: <CALOAHbCp-Up0pQu6tfRKswTqzvQqDX66gbiZqpmAN2ny6uCgYA@mail.gmail.com> (raw)
In-Reply-To: <CALOAHbA2x0V=RYCBr+OnzYdy=hmiQLk4SBR1QkGfXe3RT8-Neg@mail.gmail.com>
On Fri, Oct 29, 2021 at 10:15 AM Yafang Shao <laoar.shao@gmail.com> wrote:
>
> On Wed, Oct 27, 2021 at 8:48 PM Petr Mladek <pmladek@suse.com> wrote:
> >
> > The commit 23efd0804c0a869dfb1e7 ("vsprintf: Make %pGp print
> > the hex value") changed the behavior of %pGp printk format.
> > Update the documentation accordingly.
> >
> > Fixes: 23efd0804c0a869dfb1e7 ("vsprintf: Make %pGp print the hex value")
> > Signed-off-by: Petr Mladek <pmladek@suse.com>
>
> Reviewed-by: Yafang Shao <laoar.shao@gmail.com>
>
With below minor change:
- %pGp
0x17ffffc0002036(referenced|uptodate|lru|active|private|node=0|zone=2|lastcpupid=0x1fffff
+ %pGp
0x17ffffc0002036(referenced|uptodate|lru|active|private|node=0|zone=2|lastcpupid=0x1fffff)
The ')' is lost.
I just checked the data before :(
> > ---
> > The commit ID 23efd0804c0a869dfb1e7 is taken from printk/linux.git,
> > branch for-5.16-vsprintf-pgp. It should get preserved when the branch
> > is merged into Linus tree.
> >
> > Documentation/core-api/printk-formats.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst
> > index e08bbe9b0cbf..4eff98e06b4b 100644
> > --- a/Documentation/core-api/printk-formats.rst
> > +++ b/Documentation/core-api/printk-formats.rst
> > @@ -580,7 +580,7 @@ Flags bitfields such as page flags, gfp_flags
> >
> > ::
> >
> > - %pGp referenced|uptodate|lru|active|private|node=0|zone=2|lastcpupid=0x1fffff
> > + %pGp 0x17ffffc0002036(referenced|uptodate|lru|active|private|node=0|zone=2|lastcpupid=0x1fffff
> > %pGg GFP_USER|GFP_DMA32|GFP_NOWARN
> > %pGv read|exec|mayread|maywrite|mayexec|denywrite
> >
> > --
> > 2.26.2
>
>
>
> --
> Thanks
> Yafang
--
Thanks
Yafang
next prev parent reply other threads:[~2021-10-29 2:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 14:26 [PATCH v2 0/5] Improvements to %pGp Matthew Wilcox (Oracle)
2021-10-19 14:26 ` [PATCH v2 1/5] test_printf: Make pft array const Matthew Wilcox (Oracle)
2021-10-19 14:26 ` [PATCH v2 2/5] test_printf: Remove separate page_flags variable Matthew Wilcox (Oracle)
2021-10-22 15:12 ` Yafang Shao
2021-10-27 9:47 ` Petr Mladek
2021-10-19 14:26 ` [PATCH v2 3/5] test_printf: Remove custom appending of '|' Matthew Wilcox (Oracle)
2021-10-19 14:26 ` [PATCH v2 4/5] test_printf: Append strings more efficiently Matthew Wilcox (Oracle)
2021-10-22 15:13 ` Yafang Shao
2021-10-27 10:14 ` Petr Mladek
2021-10-19 14:26 ` [PATCH v2 5/5] vsprintf: Make %pGp print the hex value Matthew Wilcox (Oracle)
2021-10-22 15:14 ` Yafang Shao
2021-10-27 10:27 ` Petr Mladek
2021-10-27 12:48 ` [PATCH] vsprintf: Update %pGp documentation about that it prints " Petr Mladek
2021-10-29 2:15 ` Yafang Shao
2021-10-29 2:18 ` Yafang Shao [this message]
2021-11-02 9:35 ` Petr Mladek
2021-10-27 12:09 ` [PATCH v2 0/5] Improvements to %pGp Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALOAHbCp-Up0pQu6tfRKswTqzvQqDX66gbiZqpmAN2ny6uCgYA@mail.gmail.com \
--to=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=senozhatsky@chromium.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.