From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECA79C433EF for ; Thu, 7 Jul 2022 10:30:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235136AbiGGKa2 (ORCPT ); Thu, 7 Jul 2022 06:30:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235231AbiGGKa2 (ORCPT ); Thu, 7 Jul 2022 06:30:28 -0400 Received: from mail-vk1-xa31.google.com (mail-vk1-xa31.google.com [IPv6:2607:f8b0:4864:20::a31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57C11564F3 for ; Thu, 7 Jul 2022 03:30:26 -0700 (PDT) Received: by mail-vk1-xa31.google.com with SMTP id d6so2237141vko.11 for ; Thu, 07 Jul 2022 03:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iNt1u7R+eN/x3tIuhIyGJhKuokTR5Zn4HsNjpIKWO9w=; b=ifzYQYeHcS9UTCVMztgbre4Kl7knMGfpYmbp/qAVuj6OQX1IqUuFWPehUhfuukSBPV mpihsshtAqM6NAb5JYC/dt+CjlMfgHhVzYvUsDQUevmOT1lJlHQgk9uipA1h+6QZhyDd LVddxYN+JKJuThHxLXt6dQQwoo/zqKrLbJ9QuPS8uLDhrg5CC9yBK2mEnvdom42WhVdy 6qrUcv7adCR7/I3wFc36+qObmk3ZFmPEPDWZxssq3CAOTDiz5P9lPIHehPpLKNqMkkyI VPp0JbSMUZDb+UtnR3ZviWd75SvvSN9tN4XaMdaRoMTyPcjLjJUUF/o9U53WucclBXdF QQWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iNt1u7R+eN/x3tIuhIyGJhKuokTR5Zn4HsNjpIKWO9w=; b=DzK6FNDKRapcWVAgK87cuHqLDW+6lNseQTdXIcgl4QZDmiEcMPorQJzxzsPtEac9OM dc2ZTjhoxdtbmP8L2r1F+dOBFr9u52wj/lY2PvWVMesFlXcrgBDhQaKIFdojBH95wgEV FLgQRg7vWY4HTa4IEcKw79ouJSWaulJHXoA2NgBR3ly9jmyKaN115jcWJ1dOwklGG9UH kJQ78R33pvfqhIytomRdZnMhX4frF6FbU28mCfWS2hV3hVdGZmW3Lr4OJRjqqmMS2xUK zX3EwnJTDUlKtKG/BXeRYmoosEzVkD6fIenyPVTm3CS94vWdGmyKMwwT23RPqhXtao0o Se5Q== X-Gm-Message-State: AJIora9lM7p7VvyM+J83zT6HBTQOFbwU5yGGHvN4tUhWVNIuxkOKjdlL KPaJvNM7ENYKMujmhXO9jD8QChbP5nzYFcbmDyPJ+lzdSYFxJGsY X-Google-Smtp-Source: AGRyM1utikq+PryJRTKyb6gB5KS4/sYQLvYxZ+RUZtw19TF8lZbhuB9N0gvKFcZfh2VV6s75CjgfprzgFIdIIWpny1Y= X-Received: by 2002:ac5:cc4c:0:b0:374:502d:85f4 with SMTP id l12-20020ac5cc4c000000b00374502d85f4mr1414185vkm.8.1657189825110; Thu, 07 Jul 2022 03:30:25 -0700 (PDT) MIME-Version: 1.0 References: <20220706155848.4939-1-laoar.shao@gmail.com> <20220706155848.4939-3-laoar.shao@gmail.com> In-Reply-To: From: Yafang Shao Date: Thu, 7 Jul 2022 18:29:48 +0800 Message-ID: Subject: Re: [PATCH bpf-next v2 2/2] bpf: Warn on non-preallocated case for missed trace types To: Alexei Starovoitov Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Quentin Monnet , Roman Gushchin , Hao Luo , bpf , linux-mm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Jul 7, 2022 at 12:50 AM Alexei Starovoitov wrote: > > On Wed, Jul 6, 2022 at 8:59 AM Yafang Shao wrote: > > > > BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE and BPF_PROG_TYPE_TRACING are > > trace type as well, which may also cause unexpected memory allocation if > > we set BPF_F_NO_PREALLOC. > > Let's also warn on both of them. > > > > Signed-off-by: Yafang Shao > > --- > > kernel/bpf/verifier.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > > index df3ec6b05f05..f9c0f4889a3a 100644 > > --- a/kernel/bpf/verifier.c > > +++ b/kernel/bpf/verifier.c > > @@ -12570,6 +12570,8 @@ static bool is_tracing_prog_type(enum bpf_prog_type type) > > case BPF_PROG_TYPE_TRACEPOINT: > > case BPF_PROG_TYPE_PERF_EVENT: > > case BPF_PROG_TYPE_RAW_TRACEPOINT: > > + case BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE: > > + case BPF_PROG_TYPE_TRACING: > > BPF_TRACE_ITER should probably be excluded. Right, I have verified that BPF_TRACE_ITER can be excluded. Will change it. -- Regards Yafang