From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E577C433E8 for ; Fri, 10 Jul 2020 14:04:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3302720748 for ; Fri, 10 Jul 2020 14:04:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dsYMmc5E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727978AbgGJOEr (ORCPT ); Fri, 10 Jul 2020 10:04:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727851AbgGJOEo (ORCPT ); Fri, 10 Jul 2020 10:04:44 -0400 Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 746E6C08C5CE; Fri, 10 Jul 2020 07:04:44 -0700 (PDT) Received: by mail-il1-x144.google.com with SMTP id t18so5163530ilh.2; Fri, 10 Jul 2020 07:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PTBjDKX9QGpcuX3s/VdchDQqYEiz3TYMGZbErPooqCM=; b=dsYMmc5ESfc26TsVEcETFHP1dEWIp0DgWNJMHhBXPlqWIAeycwi8nTlj+G/mo+GFsb ZQqtGQdXNxSN0PMwAIkFz4sEqVRnXT99p+X3a6xyip7Q44v6pZL3ueWkfrKzShVHokEy UoBXTzwI93Yr5wYPyJhj2wzM74CiJaUvO9uiiBotmaqyZYUrO1X6BoDhZ0re5ltGSWWs MyTi3GXg5NQni9wjIxStPPp8imUmXM1B6xtErm4x1kwhDmD9rTeqgG1v1nDjWgXdjxvq evlFkM2afcPt96UGdNYN0aVDvNKT1III5YcFkqVDCuomtAcuZQngauZMnABFNi4Va08i X5ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PTBjDKX9QGpcuX3s/VdchDQqYEiz3TYMGZbErPooqCM=; b=SU2ejiUBWTt0RbWYOy0jVxAouxoqifTRiFkYkhDybNtWWGZW0Xk+PM8JYqRHVTs8Zu GP0fXVKc0VUnQ+bwgecqFLQq/UuLOlbP7T1RAIbOXCfENBSM28Yw8aBTqU1v15dKIb1f aOIt3W9f/nqFK5ma01Zj6G7fIs+51VLe/WwmMYgBIfMuiwa5mS56eb0upTjOUzrPC+ww EB0pZXpVLE6v7AcqKYSFY2dFkm8vUALpTzzhSWKbqY1Y08pvKYQA+z3VY9wvbXQLQAwJ +4z+ZJeSypRgmedvMkHMnfohD6q4NSMavGuIjwuDYDC7oDogjheUvdjRxkmy09xQD2Er hOGg== X-Gm-Message-State: AOAM531KcE+oDbwYslccGTJJ/EEzDb9+o0XY78Z3ZU6ZEoeqLxI83JBI e6nCQnO7bnfWdRcsGZReORaY1WUwOpuFz5SVTn0= X-Google-Smtp-Source: ABdhPJxIbAyUa3bPZYLNXzNpF2ldPD5y93hhQQAnFQkwKXGvH95xcg2wRO+ogn/HrcfKmzgZlFFYG/HC7DwGTggSVUM= X-Received: by 2002:a92:404e:: with SMTP id n75mr11630820ila.203.1594389883807; Fri, 10 Jul 2020 07:04:43 -0700 (PDT) MIME-Version: 1.0 References: <1594309987-9919-1-git-send-email-laoar.shao@gmail.com> <20200710124253.GA1125@lca.pw> <20200710125852.GC3022@dhcp22.suse.cz> <20200710130724.GD3022@dhcp22.suse.cz> In-Reply-To: <20200710130724.GD3022@dhcp22.suse.cz> From: Yafang Shao Date: Fri, 10 Jul 2020 22:04:07 +0800 Message-ID: Subject: Re: [PATCH v2] mm, oom: make the calculation of oom badness more accurate To: Michal Hocko Cc: Qian Cai , David Rientjes , Andrew Morton , Linux MM , sfr@canb.auug.org.au, Linux-Next Mailing List , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 10, 2020 at 9:07 PM Michal Hocko wrote: > > On Fri 10-07-20 14:58:54, Michal Hocko wrote: > [...] > > I will have a closer look. Is the full dmesg available somewhere? > > Ups, I have missed this: > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 2dd5a90f2f81..7f01835862f4 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -306,7 +306,7 @@ static enum oom_constraint constrained_alloc(struct oom_control *oc) > static int oom_evaluate_task(struct task_struct *task, void *arg) > { > struct oom_control *oc = arg; > - unsigned long points; > + long points; > > if (oom_unkillable_task(task)) > goto next; > > Does it help? > -- Thanks Michal. This should be the fix. I did it in our in-house kernel, but when I posted it to upstream I missed it. That's my fault. -- Thanks Yafang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A775C433E3 for ; Fri, 10 Jul 2020 14:04:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1F1142088E for ; Fri, 10 Jul 2020 14:04:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dsYMmc5E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F1142088E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B17F58D000B; Fri, 10 Jul 2020 10:04:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC74F8D0001; Fri, 10 Jul 2020 10:04:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DD4F8D000B; Fri, 10 Jul 2020 10:04:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id 884DF8D0001 for ; Fri, 10 Jul 2020 10:04:45 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 470CC8248047 for ; Fri, 10 Jul 2020 14:04:45 +0000 (UTC) X-FDA: 77022336930.19.offer78_1b0b8b926ece Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id EF6711ACC2B for ; Fri, 10 Jul 2020 14:04:44 +0000 (UTC) X-HE-Tag: offer78_1b0b8b926ece X-Filterd-Recvd-Size: 3774 Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 14:04:44 +0000 (UTC) Received: by mail-il1-f196.google.com with SMTP id x9so5163575ila.3 for ; Fri, 10 Jul 2020 07:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PTBjDKX9QGpcuX3s/VdchDQqYEiz3TYMGZbErPooqCM=; b=dsYMmc5ESfc26TsVEcETFHP1dEWIp0DgWNJMHhBXPlqWIAeycwi8nTlj+G/mo+GFsb ZQqtGQdXNxSN0PMwAIkFz4sEqVRnXT99p+X3a6xyip7Q44v6pZL3ueWkfrKzShVHokEy UoBXTzwI93Yr5wYPyJhj2wzM74CiJaUvO9uiiBotmaqyZYUrO1X6BoDhZ0re5ltGSWWs MyTi3GXg5NQni9wjIxStPPp8imUmXM1B6xtErm4x1kwhDmD9rTeqgG1v1nDjWgXdjxvq evlFkM2afcPt96UGdNYN0aVDvNKT1III5YcFkqVDCuomtAcuZQngauZMnABFNi4Va08i X5ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PTBjDKX9QGpcuX3s/VdchDQqYEiz3TYMGZbErPooqCM=; b=r+ek0M8L8J3UmiRHnW38VmQEuKrZvwboV2qv7J9T5oYWITC93OWbG4M7VkiXzDX+Tg 8EGj9sRzEIGz7GGEdjdRmXmqyTx4h+SeZaswaRJMP7knqS88r1JVX3XUI5fHdNOni571 GfeFRNpd/V+rUvHyiPCqXEdwYLkciaC1xLGaTqVFBtKkMa67vMzkax8y9SD3b9GZu8Ao n2Z6BJJx9gaGFH5yGTDFu34bKOsJXNV6T1A6jq3UA7vjBOiAz0nA9p+EDBy4HQ9Y6Xyt yBetYBWi9ef1Mxp9jm5jjckx0ZzPUMZptLTzsfO0psC6mv16eXM6ekVCIEJesa3gcM7W X1iw== X-Gm-Message-State: AOAM530o3dXxXgA64aOy5hhxShdhyJq3RLGomuCzOm7v9NKsh04zrUUB p5jvSEQEr9cqu0f1HpqcakX8juqZJAdEE6LLxRs= X-Google-Smtp-Source: ABdhPJxIbAyUa3bPZYLNXzNpF2ldPD5y93hhQQAnFQkwKXGvH95xcg2wRO+ogn/HrcfKmzgZlFFYG/HC7DwGTggSVUM= X-Received: by 2002:a92:404e:: with SMTP id n75mr11630820ila.203.1594389883807; Fri, 10 Jul 2020 07:04:43 -0700 (PDT) MIME-Version: 1.0 References: <1594309987-9919-1-git-send-email-laoar.shao@gmail.com> <20200710124253.GA1125@lca.pw> <20200710125852.GC3022@dhcp22.suse.cz> <20200710130724.GD3022@dhcp22.suse.cz> In-Reply-To: <20200710130724.GD3022@dhcp22.suse.cz> From: Yafang Shao Date: Fri, 10 Jul 2020 22:04:07 +0800 Message-ID: Subject: Re: [PATCH v2] mm, oom: make the calculation of oom badness more accurate To: Michal Hocko Cc: Qian Cai , David Rientjes , Andrew Morton , Linux MM , sfr@canb.auug.org.au, Linux-Next Mailing List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: EF6711ACC2B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 10, 2020 at 9:07 PM Michal Hocko wrote: > > On Fri 10-07-20 14:58:54, Michal Hocko wrote: > [...] > > I will have a closer look. Is the full dmesg available somewhere? > > Ups, I have missed this: > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 2dd5a90f2f81..7f01835862f4 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -306,7 +306,7 @@ static enum oom_constraint constrained_alloc(struct oom_control *oc) > static int oom_evaluate_task(struct task_struct *task, void *arg) > { > struct oom_control *oc = arg; > - unsigned long points; > + long points; > > if (oom_unkillable_task(task)) > goto next; > > Does it help? > -- Thanks Michal. This should be the fix. I did it in our in-house kernel, but when I posted it to upstream I missed it. That's my fault. -- Thanks Yafang