From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C166E6D10 for ; Tue, 6 Apr 2021 16:02:04 +0000 (UTC) Received: by mail-io1-f44.google.com with SMTP id f19so16101888ion.3 for ; Tue, 06 Apr 2021 09:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y6td6U/wgXJy1PKxkTx+qADiVVwnBDVWbevDjru0nls=; b=XvPpCjYxNmJmPbhWQwWWLjNrOfwWJekG5FGqReCq3HR7smTKgok8w/+146+n12sXYh g1SrBLJkHm6800/a8NRq/X+CMSiz6G/JNNS8hv/BXu44w47pWOn4xjF227zQ2lkprOIh eGWepOCNQdmUWzQmHnj7HDx92mhDsbhqkmNXhEA/G8FyxFn6hoH1IVrtQ7PnvK8DwgzB PpYChXnoMFzZkwxfV3WUOwaNcPHs1chU+ro8WE+MMTT1XaElw/fgi6L1oS8RhBNtOjdF OYxHMqvZRgAwps12+XvU/yKiF+SLtPa48N5qxjKKm0GQe2t7kykpeRwCrm/FaC3hYWj6 A/SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y6td6U/wgXJy1PKxkTx+qADiVVwnBDVWbevDjru0nls=; b=luErrmScP/2Ncs4R3TtS7BoG4ukd95NHGu73r9h+klJKF0CHY/kHHA1WtHTKOrdXkB ezdx8ZGxHKsd8RX8W0oUkA0kqfsMwFUwuiOPUzFmTIUuIInaHdmxXWIGMh2ObxrIzp51 iiVzA8SpyO1doM8sk9zEMu6Hj7/fB+Uupwpru2MIO+pi0Fk0X8dvvkGSh6EKdBua8XRb EhK71gorAPm3kYzdYyr6R7sED2R/Q4jCwWGAEUjYzYDkY64yIRBCpl7O1QjccM3cdSNr 8a1CUDdX3HJQ5gpnSufD/pWmiLVaeP1liTLldAI5SaVzMBbjnA3gHGWYGB0SS/C28HKl rc1g== X-Gm-Message-State: AOAM532bZoAMmpIgaQczLBd07fFYmjiqK1m6AW/scVVZi9PgOKWKyluJ sG/7TEYe4P6SuvESbKxZdPjVxfFJWHXMJHu+TB0= X-Google-Smtp-Source: ABdhPJzrupn5Tqo/qGYiJFhgY4pom3bPfOsFnrJ4YLA/PGWrDxckk5HncixtyDHTPC1rXWyNlr2qX0SRG+OFMzNoklo= X-Received: by 2002:a05:6638:144e:: with SMTP id l14mr29148356jad.76.1617724924002; Tue, 06 Apr 2021 09:02:04 -0700 (PDT) X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210406141819.1025864-1-dqfext@gmail.com> <20210406141819.1025864-3-dqfext@gmail.com> In-Reply-To: From: DENG Qingfang Date: Wed, 7 Apr 2021 00:02:00 +0800 Message-ID: Subject: Re: [RFC net-next 2/4] net: dsa: mt7530: add interrupt support To: Andrew Lunn Cc: "David S. Miller" , Florian Fainelli , Heiner Kallweit , Jakub Kicinski , Landen Chao , Matthias Brugger , Russell King , Sean Wang , Vivien Didelot , Vladimir Oltean , Rob Herring , Linus Walleij , Greg Kroah-Hartman , Sergio Paracuellos , linux-kernel , "moderated list:ARM/Mediatek SoC support" , linux-staging@lists.linux.dev, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , netdev , Weijie Gao , Chuanhong Guo , =?UTF-8?Q?Ren=C3=A9_van_Dorst?= Content-Type: text/plain; charset="UTF-8" On Tue, Apr 6, 2021 at 11:49 PM Andrew Lunn wrote: > O.K. So that makes it similar to the mv88e6xxx. With that driver, i > kept interrupt setup and mdio setup separate. I add the interrupt > controller first, and then do mdio setup, calling a helper to map the > PHY interrupts and assign them to bus->irq[]. > > That gives you a cleaner structure when you start using the other > interrupts. Okay. Will split the function in v2. Thanks. > > Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0521DC433B4 for ; Tue, 6 Apr 2021 16:02:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D374613CA for ; Tue, 6 Apr 2021 16:02:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D374613CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n9X6em0bqhuKi/FjAvVhQ+TXkcn4EFqQrHTlfv6pgRY=; b=Edc7EsSkkj59UxFXborpb6oqu cOFtQ7kNnXkbHWthudOQFx8fYoHsEdAfbIuPdr9OasHiaXSdJFcJDB6/xtYhVv10o9Fmye2UebXWH x/m8RUHqzCc4oFZ5n7ftsrtG0cI8NsXmESntG9DgoB7wmZr/VHPp6+YjHAl18/Z2jo0+vLfsmEUoz Oiyg29BT6K5UxID0I7qhdZ5pUSia9Y4h7+hGxqNFekClwzl2aM/UIPdefYBXlSlFFIoUddkFbdkqM aB+6mc941dAx19iRjxcT3BVh8ZN64a7yJUsogMRQSmZ+wcvZCaWXIJog59BUVMFdKOoGRJqC4a6WR kflj/yJPA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTo9Z-002yJa-08; Tue, 06 Apr 2021 16:02:09 +0000 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTo9V-002yJ2-8I for linux-mediatek@lists.infradead.org; Tue, 06 Apr 2021 16:02:06 +0000 Received: by mail-io1-xd2a.google.com with SMTP id j26so10928934iog.13 for ; Tue, 06 Apr 2021 09:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y6td6U/wgXJy1PKxkTx+qADiVVwnBDVWbevDjru0nls=; b=XvPpCjYxNmJmPbhWQwWWLjNrOfwWJekG5FGqReCq3HR7smTKgok8w/+146+n12sXYh g1SrBLJkHm6800/a8NRq/X+CMSiz6G/JNNS8hv/BXu44w47pWOn4xjF227zQ2lkprOIh eGWepOCNQdmUWzQmHnj7HDx92mhDsbhqkmNXhEA/G8FyxFn6hoH1IVrtQ7PnvK8DwgzB PpYChXnoMFzZkwxfV3WUOwaNcPHs1chU+ro8WE+MMTT1XaElw/fgi6L1oS8RhBNtOjdF OYxHMqvZRgAwps12+XvU/yKiF+SLtPa48N5qxjKKm0GQe2t7kykpeRwCrm/FaC3hYWj6 A/SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y6td6U/wgXJy1PKxkTx+qADiVVwnBDVWbevDjru0nls=; b=D+PXponJCg2E5gNfz2WBkrMAN4/HwHPYuf2LeviiPWVtVk5wNFR7nj89AxHnm7QFS6 OwcDb8pgyMhEWjz0c7fS1kguDwFoHrZsQxdis4eRE849tRh3qw4xDq9WBrxkJKd4ikuO q+nM28oRml4IYs+3UnI0EA8MhTz1sjHRljDGKvnaRLosU799ICNiAMR8vX2dH9MDsPYL fjGBOr8mzMvctm6iHr+YOIzG0wxZq99yTPpmF+dT1HiOBXsdwUQ+/ihoz8tfeeiNi7Y5 uwM7aiEvCC4WUndl4qAJvjHkqHTT+Ez/Ue8BFSsYS3NsrFzStI455IRl+BLWEuFCW3U7 KBzQ== X-Gm-Message-State: AOAM533TkaljeJT/rU3Da8BmtbS8R7XbW11a6v+vAVbCsWBQSVctZ+64 mDB5Cj6jph6Wrf1Nj0zapsBbpWmgz0QNKhAgFZs= X-Google-Smtp-Source: ABdhPJzrupn5Tqo/qGYiJFhgY4pom3bPfOsFnrJ4YLA/PGWrDxckk5HncixtyDHTPC1rXWyNlr2qX0SRG+OFMzNoklo= X-Received: by 2002:a05:6638:144e:: with SMTP id l14mr29148356jad.76.1617724924002; Tue, 06 Apr 2021 09:02:04 -0700 (PDT) MIME-Version: 1.0 References: <20210406141819.1025864-1-dqfext@gmail.com> <20210406141819.1025864-3-dqfext@gmail.com> In-Reply-To: From: DENG Qingfang Date: Wed, 7 Apr 2021 00:02:00 +0800 Message-ID: Subject: Re: [RFC net-next 2/4] net: dsa: mt7530: add interrupt support To: Andrew Lunn Cc: "David S. Miller" , Florian Fainelli , Heiner Kallweit , Jakub Kicinski , Landen Chao , Matthias Brugger , Russell King , Sean Wang , Vivien Didelot , Vladimir Oltean , Rob Herring , Linus Walleij , Greg Kroah-Hartman , Sergio Paracuellos , linux-kernel , "moderated list:ARM/Mediatek SoC support" , linux-staging@lists.linux.dev, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , netdev , Weijie Gao , Chuanhong Guo , =?UTF-8?Q?Ren=C3=A9_van_Dorst?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210406_170205_388145_ED651C8D X-CRM114-Status: GOOD ( 10.90 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Apr 6, 2021 at 11:49 PM Andrew Lunn wrote: > O.K. So that makes it similar to the mv88e6xxx. With that driver, i > kept interrupt setup and mdio setup separate. I add the interrupt > controller first, and then do mdio setup, calling a helper to map the > PHY interrupts and assign them to bus->irq[]. > > That gives you a cleaner structure when you start using the other > interrupts. Okay. Will split the function in v2. Thanks. > > Andrew _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek