From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ed Czeck <ed.czeck@atomicrules.com>
Subject: Re: [PATCH v4 7/7] net/ark: Arkville PMD component
	integration
Date: Thu, 23 Mar 2017 18:19:54 -0400
Message-ID: <CALZ3Gug4vAujN0+yMoVEnKisWDD0XgVhfuPsHw=oc2TmrgHWHA@mail.gmail.com>
References: <1490231015-31748-1-git-send-email-ed.czeck@atomicrules.com>
 <1490231015-31748-7-git-send-email-ed.czeck@atomicrules.com>
 <f376c1db-a747-9bff-c57e-9c3e1cd373cf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>,
 Shepard Siegel <shepard.siegel@atomicrules.com>,
 John Miller <john.miller@atomicrules.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com
 [209.85.220.181]) by dpdk.org (Postfix) with ESMTP id 9329A14E8
 for <dev@dpdk.org>; Thu, 23 Mar 2017 23:20:15 +0100 (CET)
Received: by mail-qk0-f181.google.com with SMTP id f11so6031128qkb.0
 for <dev@dpdk.org>; Thu, 23 Mar 2017 15:20:15 -0700 (PDT)
In-Reply-To: <f376c1db-a747-9bff-c57e-9c3e1cd373cf@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Mar 23, 2017 at 8:13 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:
>

> >
> > +static
> > +int
>
> Can be in same line.
Fixed

>
> > +check_for_ext(struct rte_eth_dev *dev __rte_unused,
> > +           struct ark_adapter *ark __rte_unused)
>
> __rte_unused can go away
Fixed


> Hi Ed,
>
> Can you give some more details on "user extension" that loaded
dynamically?
>
> How much the driver depends on it, what happens if the library is missing=
?
>
> And how do you deliver that shared library?
>
Dynamic libraries arem optional user provided extensions to the PMD. The
driver funcations correctly without one.   Here is the blurb from our doc
file: doc/guides/nics/ark.rst

The ARK PMD user extensions are a feature of Arkville=E2=80=99s DPDK
net/ark poll mode driver, allowing users to add their
own code to extend the net/ark functionality without
having to make source code changes to the driver. One motivation for
this capability is that while DPDK provides a rich set of functions
to interact with NIC-like capabilities (e.g. MAC addresses and statistics),
the Arkville RTL IP does not include a MAC.  Users can supply their
own MAC or custom FPGA applications, which may require control from
the PMD.  The user extension is the means providing the control
between the user's FPGA application and the existing DPDK features via
the PMD.