From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ed Czeck <ed.czeck@atomicrules.com>
Subject: Re: [PATCH 2/2] net/ark: report hardware status during
	PMD init
Date: Tue, 11 Apr 2017 11:26:26 -0400
Message-ID: <CALZ3GuhuMYBoxcRFkpjZeotmeV6Gpx7zmXD7_ipNyQ=NEdkFmA@mail.gmail.com>
References: <1491827199-4853-1-git-send-email-ed.czeck@atomicrules.com>
 <1491827199-4853-2-git-send-email-ed.czeck@atomicrules.com>
 <5bb8278f-a3b1-01bc-6161-33c73e9731a4@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: dev@dpdk.org, John Miller <john.miller@atomicrules.com>,
 Shepard Siegel <shepard.siegel@atomicrules.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f175.google.com (mail-qk0-f175.google.com
 [209.85.220.175]) by dpdk.org (Postfix) with ESMTP id 8EC962BF5
 for <dev@dpdk.org>; Tue, 11 Apr 2017 17:26:47 +0200 (CEST)
Received: by mail-qk0-f175.google.com with SMTP id d131so399640qkc.3
 for <dev@dpdk.org>; Tue, 11 Apr 2017 08:26:47 -0700 (PDT)
In-Reply-To: <5bb8278f-a3b1-01bc-6161-33c73e9731a4@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Apr 10, 2017 at 11:01 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> On 4/10/2017 1:26 PM, Ed Czeck wrote:
> > Expose additional fpga status registers and report
> > conditions during PMD init
> >
>
> > +     if (ark->sysctrl.t32[3] != 0) {
> > +             if (ark_rqp_lasped(ark->rqpacing))
> > +                     PMD_DRV_LOG(INFO, "Arkville Evaluation System - "
>
> Is this should be "info" level or debug, is end user interested if timer
> expired or not?
>
> These messages are intended for the user.  After internal discussion we
promoted them to warning and error.



> > +                                 "Timer has Expired\n");
> > +             else
> > +                     PMD_DRV_LOG(INFO, "Arkville Evaluation System - "
>
> btw, what is the logic in pmd, when to use PMD_DRV_LOG and when to use
> PMD_DEBUG_LOG?


The  PMD_DRV_LOG macro is a local wrapper on RTE_LOG, while the
PMD_DEBUG_LOG macro is a compile-time conditional macro to the same
RTE_LOG.  The DEBUG_LOG macro is conditionalize on the configuration
RTE_LIBRTE_ARK_DEBUG_TRACE.


> > +                                 "Timer is Running\n");
> > +     }
> > +
> >
>
> Extra line.
>
Removed.

Thank you