From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lei Wen Date: Fri, 22 Jul 2011 15:52:32 +0800 Subject: [U-Boot] [PATCH v2 2/2] gpio: Add GPIO driver for Marvell SoC Armada100 In-Reply-To: <86738418.45518.1311319666588.JavaMail.root@ahm.einfochips.com> References: <86738418.45518.1311319666588.JavaMail.root@ahm.einfochips.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Jul 22, 2011 at 3:27 PM, Ajay Bhargav wrote: > Hi Lei, > >> Why not put this structure into driver file? >> I think this register is not easy to change, and put this into arch >> .h >> would make the work duplicated, >> as each arch need to redefine the same structure again. >> > Other architectures may/may not have the same structure. One can redefine > structure based on this header file. I think if have no such same structure, the gpio driver may need to be rewrite, since the meaning of the register may also change. Best regards, Lei