From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752863AbaHMOAR (ORCPT ); Wed, 13 Aug 2014 10:00:17 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:62160 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbaHMOAP (ORCPT ); Wed, 13 Aug 2014 10:00:15 -0400 MIME-Version: 1.0 In-Reply-To: <1407225723-23754-2-git-send-email-minchan@kernel.org> References: <1407225723-23754-1-git-send-email-minchan@kernel.org> <1407225723-23754-2-git-send-email-minchan@kernel.org> From: Dan Streetman Date: Wed, 13 Aug 2014 09:59:52 -0400 X-Google-Sender-Auth: d1Z9A0uQG0fxEB4WfTQyv20Ws0Y Message-ID: Subject: Re: [RFC 1/3] zsmalloc: move pages_allocated to zs_pool To: Minchan Kim Cc: Linux-MM , linux-kernel , Sergey Senozhatsky , Jerome Marchand , juno.choi@lge.com, seungho1.park@lge.com, Luigi Semenzato , Nitin Gupta Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 5, 2014 at 4:02 AM, Minchan Kim wrote: > Pages_allocated has counted in size_class structure and when user > want to see total_size_bytes, it gathers all of value from each > size_class to report the sum. > > It's not bad if user don't see the value often but if user start > to see the value frequently, it would be not a good deal for > performance POV. > > This patch moves the variable from size_class to zs_pool so it would > reduce memory footprint (from [255 * 8byte] to [sizeof(atomic_t)]) > but it adds new locking overhead but it wouldn't be severe because > it's not a hot path in zs_malloc(ie, it is called only when new > zspage is created, not a object). Would using an atomic64_t without locking be simpler? > > Signed-off-by: Minchan Kim > --- > mm/zsmalloc.c | 30 ++++++++++++++++-------------- > 1 file changed, 16 insertions(+), 14 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index fe78189624cf..a6089bd26621 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -198,9 +198,6 @@ struct size_class { > > spinlock_t lock; > > - /* stats */ > - u64 pages_allocated; > - > struct page *fullness_list[_ZS_NR_FULLNESS_GROUPS]; > }; > > @@ -216,9 +213,12 @@ struct link_free { > }; > > struct zs_pool { > + spinlock_t stat_lock; > + > struct size_class size_class[ZS_SIZE_CLASSES]; > > gfp_t flags; /* allocation flags used when growing pool */ > + unsigned long pages_allocated; > }; > > /* > @@ -882,6 +882,7 @@ struct zs_pool *zs_create_pool(gfp_t flags) > > } > > + spin_lock_init(&pool->stat_lock); > pool->flags = flags; > > return pool; > @@ -943,8 +944,10 @@ unsigned long zs_malloc(struct zs_pool *pool, size_t size) > return 0; > > set_zspage_mapping(first_page, class->index, ZS_EMPTY); > + spin_lock(&pool->stat_lock); > + pool->pages_allocated += class->pages_per_zspage; > + spin_unlock(&pool->stat_lock); > spin_lock(&class->lock); > - class->pages_allocated += class->pages_per_zspage; > } > > obj = (unsigned long)first_page->freelist; > @@ -997,14 +1000,14 @@ void zs_free(struct zs_pool *pool, unsigned long obj) > > first_page->inuse--; > fullness = fix_fullness_group(pool, first_page); > - > - if (fullness == ZS_EMPTY) > - class->pages_allocated -= class->pages_per_zspage; > - > spin_unlock(&class->lock); > > - if (fullness == ZS_EMPTY) > + if (fullness == ZS_EMPTY) { > + spin_lock(&pool->stat_lock); > + pool->pages_allocated -= class->pages_per_zspage; > + spin_unlock(&pool->stat_lock); > free_zspage(first_page); > + } > } > EXPORT_SYMBOL_GPL(zs_free); > > @@ -1100,12 +1103,11 @@ EXPORT_SYMBOL_GPL(zs_unmap_object); > > u64 zs_get_total_size_bytes(struct zs_pool *pool) > { > - int i; > - u64 npages = 0; > - > - for (i = 0; i < ZS_SIZE_CLASSES; i++) > - npages += pool->size_class[i].pages_allocated; > + u64 npages; > > + spin_lock(&pool->stat_lock); > + npages = pool->pages_allocated; > + spin_unlock(&pool->stat_lock); > return npages << PAGE_SHIFT; > } > EXPORT_SYMBOL_GPL(zs_get_total_size_bytes); > -- > 2.0.0 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by kanga.kvack.org (Postfix) with ESMTP id 184B26B0035 for ; Wed, 13 Aug 2014 10:00:15 -0400 (EDT) Received: by mail-we0-f181.google.com with SMTP id k48so11345808wev.40 for ; Wed, 13 Aug 2014 07:00:14 -0700 (PDT) Received: from mail-we0-x22e.google.com (mail-we0-x22e.google.com [2a00:1450:400c:c03::22e]) by mx.google.com with ESMTPS id z1si26133629wiw.106.2014.08.13.07.00.12 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 13 Aug 2014 07:00:13 -0700 (PDT) Received: by mail-we0-f174.google.com with SMTP id x48so11422854wes.33 for ; Wed, 13 Aug 2014 07:00:12 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1407225723-23754-2-git-send-email-minchan@kernel.org> References: <1407225723-23754-1-git-send-email-minchan@kernel.org> <1407225723-23754-2-git-send-email-minchan@kernel.org> From: Dan Streetman Date: Wed, 13 Aug 2014 09:59:52 -0400 Message-ID: Subject: Re: [RFC 1/3] zsmalloc: move pages_allocated to zs_pool Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Linux-MM , linux-kernel , Sergey Senozhatsky , Jerome Marchand , juno.choi@lge.com, seungho1.park@lge.com, Luigi Semenzato , Nitin Gupta On Tue, Aug 5, 2014 at 4:02 AM, Minchan Kim wrote: > Pages_allocated has counted in size_class structure and when user > want to see total_size_bytes, it gathers all of value from each > size_class to report the sum. > > It's not bad if user don't see the value often but if user start > to see the value frequently, it would be not a good deal for > performance POV. > > This patch moves the variable from size_class to zs_pool so it would > reduce memory footprint (from [255 * 8byte] to [sizeof(atomic_t)]) > but it adds new locking overhead but it wouldn't be severe because > it's not a hot path in zs_malloc(ie, it is called only when new > zspage is created, not a object). Would using an atomic64_t without locking be simpler? > > Signed-off-by: Minchan Kim > --- > mm/zsmalloc.c | 30 ++++++++++++++++-------------- > 1 file changed, 16 insertions(+), 14 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index fe78189624cf..a6089bd26621 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -198,9 +198,6 @@ struct size_class { > > spinlock_t lock; > > - /* stats */ > - u64 pages_allocated; > - > struct page *fullness_list[_ZS_NR_FULLNESS_GROUPS]; > }; > > @@ -216,9 +213,12 @@ struct link_free { > }; > > struct zs_pool { > + spinlock_t stat_lock; > + > struct size_class size_class[ZS_SIZE_CLASSES]; > > gfp_t flags; /* allocation flags used when growing pool */ > + unsigned long pages_allocated; > }; > > /* > @@ -882,6 +882,7 @@ struct zs_pool *zs_create_pool(gfp_t flags) > > } > > + spin_lock_init(&pool->stat_lock); > pool->flags = flags; > > return pool; > @@ -943,8 +944,10 @@ unsigned long zs_malloc(struct zs_pool *pool, size_t size) > return 0; > > set_zspage_mapping(first_page, class->index, ZS_EMPTY); > + spin_lock(&pool->stat_lock); > + pool->pages_allocated += class->pages_per_zspage; > + spin_unlock(&pool->stat_lock); > spin_lock(&class->lock); > - class->pages_allocated += class->pages_per_zspage; > } > > obj = (unsigned long)first_page->freelist; > @@ -997,14 +1000,14 @@ void zs_free(struct zs_pool *pool, unsigned long obj) > > first_page->inuse--; > fullness = fix_fullness_group(pool, first_page); > - > - if (fullness == ZS_EMPTY) > - class->pages_allocated -= class->pages_per_zspage; > - > spin_unlock(&class->lock); > > - if (fullness == ZS_EMPTY) > + if (fullness == ZS_EMPTY) { > + spin_lock(&pool->stat_lock); > + pool->pages_allocated -= class->pages_per_zspage; > + spin_unlock(&pool->stat_lock); > free_zspage(first_page); > + } > } > EXPORT_SYMBOL_GPL(zs_free); > > @@ -1100,12 +1103,11 @@ EXPORT_SYMBOL_GPL(zs_unmap_object); > > u64 zs_get_total_size_bytes(struct zs_pool *pool) > { > - int i; > - u64 npages = 0; > - > - for (i = 0; i < ZS_SIZE_CLASSES; i++) > - npages += pool->size_class[i].pages_allocated; > + u64 npages; > > + spin_lock(&pool->stat_lock); > + npages = pool->pages_allocated; > + spin_unlock(&pool->stat_lock); > return npages << PAGE_SHIFT; > } > EXPORT_SYMBOL_GPL(zs_get_total_size_bytes); > -- > 2.0.0 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org