From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver Date: Thu, 19 Oct 2017 15:52:42 -0500 Message-ID: References: <3d432aa2617977a2b0a8621a1fc2f36f751133e1.1507752381.git.digetx@gmail.com> <20171017201354.efgjrwvakkseyvr7@rob-hp-laptop> <20171017202407.GA10482@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Dmitry Osipenko Cc: devel@driverdev.osuosl.org, "devicetree@vger.kernel.org" , Stephen Warren , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Jonathan Hunter , Thierry Reding , "linux-tegra@vger.kernel.org" , Mauro Carvalho Chehab , Dan Carpenter , "linux-media@vger.kernel.org" List-Id: linux-tegra@vger.kernel.org On Tue, Oct 17, 2017 at 4:26 PM, Dmitry Osipenko wrote: > On 18.10.2017 00:13, Rob Herring wrote: >> On Tue, Oct 17, 2017 at 3:24 PM, Thierry Reding >> wrote: >>> On Tue, Oct 17, 2017 at 03:13:54PM -0500, Rob Herring wrote: >>> [...] >>>>> diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt >>> [...] >>>>> +- resets : Must contain an entry for each entry in reset-names. >>>>> + See ../reset/reset.txt for details. >>>>> +- reset-names : Must include the following entries: >>>>> + - vde >>>> >>>> -names is pointless when there is only one. >>> >>> I'd prefer to keep it. In the past we occasionally had to add clocks or >>> resets to a device tree node where only one had been present (and hence >>> no -names property) and that caused some awkwardness because verbiage >>> had to be added to the bindings that clarified that one particular entry >>> (the original one) always had to come first. >> >> The order should be specified regardless of -names and the original >> one has to come first if you add any. That's not awkwardness, but how >> bindings work. > > Probably it would be okay to remove '-names' from the binding doc, but keep them > in the actual DT, wouldn't it? No. Then where are the names documented? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218AbdJSUxH (ORCPT ); Thu, 19 Oct 2017 16:53:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:58314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbdJSUxE (ORCPT ); Thu, 19 Oct 2017 16:53:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AC9421924 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org X-Google-Smtp-Source: ABhQp+QgTlk+dJOp3ry5Bd5SHiODy54BnhKAzSSowT+ayr4B+wXuqqsp4PIicUFfRpytr60DSOA7HFbYzvMFgMRKnYM= MIME-Version: 1.0 In-Reply-To: References: <3d432aa2617977a2b0a8621a1fc2f36f751133e1.1507752381.git.digetx@gmail.com> <20171017201354.efgjrwvakkseyvr7@rob-hp-laptop> <20171017202407.GA10482@ulmo> From: Rob Herring Date: Thu, 19 Oct 2017 15:52:42 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Greg Kroah-Hartman , Mauro Carvalho Chehab , Stephen Warren , Dan Carpenter , "linux-media@vger.kernel.org" , "linux-tegra@vger.kernel.org" , devel@driverdev.osuosl.org, "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 17, 2017 at 4:26 PM, Dmitry Osipenko wrote: > On 18.10.2017 00:13, Rob Herring wrote: >> On Tue, Oct 17, 2017 at 3:24 PM, Thierry Reding >> wrote: >>> On Tue, Oct 17, 2017 at 03:13:54PM -0500, Rob Herring wrote: >>> [...] >>>>> diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt >>> [...] >>>>> +- resets : Must contain an entry for each entry in reset-names. >>>>> + See ../reset/reset.txt for details. >>>>> +- reset-names : Must include the following entries: >>>>> + - vde >>>> >>>> -names is pointless when there is only one. >>> >>> I'd prefer to keep it. In the past we occasionally had to add clocks or >>> resets to a device tree node where only one had been present (and hence >>> no -names property) and that caused some awkwardness because verbiage >>> had to be added to the bindings that clarified that one particular entry >>> (the original one) always had to come first. >> >> The order should be specified regardless of -names and the original >> one has to come first if you add any. That's not awkwardness, but how >> bindings work. > > Probably it would be okay to remove '-names' from the binding doc, but keep them > in the actual DT, wouldn't it? No. Then where are the names documented? Rob