From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC458C4332D for ; Wed, 10 Feb 2021 18:20:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82EFB64EDC for ; Wed, 10 Feb 2021 18:20:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233970AbhBJSTw (ORCPT ); Wed, 10 Feb 2021 13:19:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:57822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233809AbhBJSSB (ORCPT ); Wed, 10 Feb 2021 13:18:01 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id ADAE064EE9; Wed, 10 Feb 2021 18:16:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612981009; bh=Y3M41xwZVH3Dio4o/VsIyICva0DpELAmRG0OwZz7C1Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QM7pBvQZXERvSGVgvVQf7/8bIgSjJ1LFA/QqdCKHjseU3TJdXhwdyRqlAohdiep5Y ccCj9qMxQ00ZZL5/zdNDgyrMtC/uJJIhU5zT90AAT5gh5E4CRD8NIo1utDowjzRE6L RSXQIstLwQh+q983wgmIG69dRBcZICctI9Yzzh3HjAaHF+YoO5+HRfkGDbOcKLs4E9 KmnqwHD8vgvZxBhHsjXiByuC4u7CiPVwRyCqEFr3QEl6GQNSQjLhqYUpPGV0xpLPoM BBAx3oxFCcyYCN/7z2GTGIwbl0dJb3vp85lJkX6pplDCGq8WX8xOn88uv8E/euu1+9 i/DEf4jgqEj1g== Received: by mail-qv1-f46.google.com with SMTP id ew18so1303424qvb.4; Wed, 10 Feb 2021 10:16:49 -0800 (PST) X-Gm-Message-State: AOAM530v2gKJZGkjfatpIhCp8IVAGpWyVOgwFT2G+TuN5S0RqlG1+2j+ YjxpUjcmE01LVVG8GgpeQxf1ARBQ0jAsU2ngNA== X-Google-Smtp-Source: ABdhPJxvrP8Mx1Q6brlIT04YJdW8GZAt91MQw70k4YzGnJ4FdepboyPbcyxHhdadzSfGAHVYcBki3D4fuCUyMhVxlvI= X-Received: by 2002:ad4:45ca:: with SMTP id v10mr4316438qvt.11.1612981008833; Wed, 10 Feb 2021 10:16:48 -0800 (PST) MIME-Version: 1.0 References: <20201205155621.3045-1-Sergey.Semin@baikalelectronics.ru> <20201205155621.3045-10-Sergey.Semin@baikalelectronics.ru> In-Reply-To: <20201205155621.3045-10-Sergey.Semin@baikalelectronics.ru> From: Rob Herring Date: Wed, 10 Feb 2021 12:16:37 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names To: Serge Semin Cc: Felipe Balbi , Krzysztof Kozlowski , Florian Fainelli , Greg Kroah-Hartman , Andy Gross , Bjorn Andersson , Serge Semin , linux-arm-msm , Linux USB List , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat, Dec 5, 2020 at 9:56 AM Serge Semin wrote: > > In accordance with the USB HCD/DRD schema all the USB controllers are > supposed to have DT-nodes named with prefix "^usb(@.*)?". Since the > existing DT-nodes will be renamed in a subsequent patch let's first make > sure the DWC3 Qualcomm driver supports them and second falls back to the > deprecated naming so not to fail on the legacy DTS-files passed to the > newer kernels. > > Signed-off-by: Serge Semin > Reviewed-by: Bjorn Andersson > --- > drivers/usb/dwc3/dwc3-qcom.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index c703d552bbcf..49ad8d507d37 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -630,7 +630,8 @@ static int dwc3_qcom_of_register_core(struct platform_device *pdev) > struct device *dev = &pdev->dev; > int ret; > > - dwc3_np = of_get_child_by_name(np, "dwc3"); > + dwc3_np = of_get_child_by_name(np, "usb") ?: > + of_get_child_by_name(np, "dwc3"); Is there some reason using compatible instead wouldn't work here? > if (!dwc3_np) { > dev_err(dev, "failed to find dwc3 core child\n"); > return -ENODEV; > -- > 2.29.2 >