From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings
Date: Tue, 12 Feb 2019 14:47:19 -0600
Message-ID: <CAL_Jsq+3Ttr8wGsDkx0q0VJRVWx2Zt41xY=NUB8GCJ1LjLk_tw@mail.gmail.com>
References: <1548761715-4004-1-git-send-email-jorge.ramirez-ortiz@linaro.org>
 <1548761715-4004-2-git-send-email-jorge.ramirez-ortiz@linaro.org>
 <20190130200218.GB5908@bogus> <f6823a9e-f2d0-ca5b-a2f8-eb362221ab81@linaro.org>
 <63959c4f-211e-bc2e-12a4-c4ef61c818a9@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <63959c4f-211e-bc2e-12a4-c4ef61c818a9@linaro.org>
Sender: linux-kernel-owner@vger.kernel.org
To: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mark Rutland <mark.rutland@arm.com>, Kishon Vijay Abraham I <kishon@ti.com>, jackp@codeaurora.org, Andy Gross <andy.gross@linaro.org>, Stephen Boyd <swboyd@chromium.org>, Shawn Guo <shawn.guo@linaro.org>, Vinod <vkoul@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Khasim Syed Mohammed <khasim.mohammed@linaro.org>, devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Linux USB List <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
List-Id: linux-arm-msm@vger.kernel.org

On Wed, Feb 6, 2019 at 8:11 AM Jorge Ramirez
<jorge.ramirez-ortiz@linaro.org> wrote:
>
> On 2/5/19 12:02, Jorge Ramirez wrote:
> > On 1/30/19 21:02, Rob Herring wrote:
> >> On Tue, Jan 29, 2019 at 12:35:14PM +0100, Jorge Ramirez-Ortiz wrote:
> >>> Binding description for Qualcomm's Synopsys 1.0.0 super-speed PHY
> >>> controller embedded in QCS404.
> >>>
> >>> Based on Sriharsha Allenki's <sallenki@codeaurora.org> original
> >>> definitions.
> >>>
> >>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> >>> ---
> >>>  .../devicetree/bindings/usb/qcom,usb-ssphy.txt     | 73 ++++++++++++++++++++++
> >>>  1 file changed, 73 insertions(+)
> >>>  create mode 100644 Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt b/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
> >>> new file mode 100644
> >>> index 0000000..8ef6e39
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
> >>> @@ -0,0 +1,73 @@
> >>> +Qualcomm Synopsys 1.0.0 SS phy controller
> >>> +===========================================
> >>> +
> >>> +Synopsys 1.0.0 ss phy controller supports SS usb connectivity on Qualcomm
> >>> +chipsets
> >>> +
> >>> +Required properties:
> >>> +
> >>> +- compatible:
> >>> +    Value type: <string>
> >>> +    Definition: Should contain "qcom,usb-ssphy".
> >>
> >> This is in no way specific enough.
> >
> > ok. will remove the old unused bindings and reuse qcom,dwc3-ss-usb-phy
> >
> >>
> >>> +
> >>> +- reg:
> >>> +    Value type: <prop-encoded-array>
> >>> +    Definition: USB PHY base address and length of the register map.
> >>> +
> >>> +- #phy-cells:
> >>> +    Value type: <u32>
> >>> +    Definition: Should be 0. See phy/phy-bindings.txt for details.
> >>> +
> >>> +- clocks:
> >>> +    Value type: <prop-encoded-array>
> >>> +    Definition: See clock-bindings.txt section "consumers". List of
> >>> +            three clock specifiers for reference, phy core and
> >>> +            pipe clocks.
> >>> +
> >>> +- clock-names:
> >>> +    Value type: <string>
> >>> +    Definition: Names of the clocks in 1-1 correspondence with the "clocks"
> >>> +            property. Must contain "ref", "phy" and "pipe".
> >>> +
> >>> +- vdd-supply:
> >>> +    Value type: <phandle>
> >>> +    Definition: phandle to the regulator VDD supply node.
> >>> +
> >>> +- vdda1p8-supply:
> >>> +    Value type: <phandle>
> >>> +    Definition: phandle to the regulator 1.8V supply node.
> >>> +
> >>> +
> >>> +Optional child nodes:
> >>> +
> >>> +- vbus-supply:
> >>> +    Value type: <phandle>
> >>> +    Definition: phandle to the VBUS supply node.
> >>
> >> Does the phy actually get supplied by Vbus? If not, then Vbus supply
> >> should be defined in a USB connector node.
> >
> > yes per the documentation vbus can optionally be routed to the phy to
> > drive a signal to the controller.
>
>
> funny enough when vbus is optionally routed to the phy is not to be
> controlled like we do when the vbus-supply property is present.
>
> So to all effects no, you are right, the phy does not get supplied by VBUS.
>
> would defining the connector like this be enough?
>
> usb3_phy: usb3-phy@78000 {
>         compatible = "qcom,snps-usb-ssphy";
>         [...]
>         usb3_c_connector: usb3-c-connector {
>                 compatible = "usb-c-connector";
>                 label = "USB-C";
>                 type = "micro";
>                 vbus-supply = <&usb3_vbus_reg>;
>         };
> };

IIRC, the connector node is defined to go under either the USB
controller or a USB-C controller (if a separate chip controlling the
USB-PD and alternate modes). We generally don't put PHYs into a node
topology, but keep them as a phandle reference.

Rob

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=NGUq=QT=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,
	SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B8F45C282C4
	for <linux-kernel@archiver.kernel.org>; Tue, 12 Feb 2019 20:47:35 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 83CF0222C1
	for <linux-kernel@archiver.kernel.org>; Tue, 12 Feb 2019 20:47:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1550004455;
	bh=dG3SYe1pky2pZMnt/9eiwxUcZ72JgJN0XyaOEoZJn3w=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From;
	b=M/6GJAOsqK1dfHLy3iXzl23VlD5BmVSeOVySl3Z/S3eUdQVOT9w1ztsGQiw//yp3u
	 FPtaSxeCtttKVmuUI/xUZlIqXW8m19yxhTYNzWKLOdHjbQE9g7VDw8CqzhyZ7ciix6
	 jDsf40vgjaAk3PQxF24HU89fn8P2MeDQEpTm0ppE=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731772AbfBLUre (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 12 Feb 2019 15:47:34 -0500
Received: from mail.kernel.org ([198.145.29.99]:54074 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727012AbfBLUrd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Feb 2019 15:47:33 -0500
Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172])
        (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 084A7222C4;
        Tue, 12 Feb 2019 20:47:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1550004452;
        bh=dG3SYe1pky2pZMnt/9eiwxUcZ72JgJN0XyaOEoZJn3w=;
        h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
        b=FM+PUZNK3D89uRZ6qfG335Uq5hmBsBhvekSeSKmu1XIgN++9c4jwSIJW6YrKr4NPL
         LtDj24vbtJ1A1M2pyhqZdin8igeDdXL28v5/NJKHXsGqUDecFAdTmqGMfvRR/flUZk
         VYAiR/qwIQagZHx2bfzfJpIBoS5jDU+QcSC06D2U=
Received: by mail-qk1-f172.google.com with SMTP id x9so64293qkf.0;
        Tue, 12 Feb 2019 12:47:31 -0800 (PST)
X-Gm-Message-State: AHQUAuakmFH9CpF4wCSKn9gYRM3ER+45CCUVj/9wLCUQgLOPCIVF4fGI
        JIjuyJAMVhmAamS5BBV+Deuq7SoWCm13q24M4g==
X-Google-Smtp-Source: AHgI3IblU/uhnwzaW4iMyxiQLo6YZeD4EDKEJn6whYdWRAEpevbjO/8tQgQXZlTuw77NdG7YUMVYNz0Rbqgu9os8s2I=
X-Received: by 2002:a37:b646:: with SMTP id g67mr4109588qkf.326.1550004451191;
 Tue, 12 Feb 2019 12:47:31 -0800 (PST)
MIME-Version: 1.0
References: <1548761715-4004-1-git-send-email-jorge.ramirez-ortiz@linaro.org>
 <1548761715-4004-2-git-send-email-jorge.ramirez-ortiz@linaro.org>
 <20190130200218.GB5908@bogus> <f6823a9e-f2d0-ca5b-a2f8-eb362221ab81@linaro.org>
 <63959c4f-211e-bc2e-12a4-c4ef61c818a9@linaro.org>
In-Reply-To: <63959c4f-211e-bc2e-12a4-c4ef61c818a9@linaro.org>
From:   Rob Herring <robh@kernel.org>
Date:   Tue, 12 Feb 2019 14:47:19 -0600
X-Gmail-Original-Message-ID: <CAL_Jsq+3Ttr8wGsDkx0q0VJRVWx2Zt41xY=NUB8GCJ1LjLk_tw@mail.gmail.com>
Message-ID: <CAL_Jsq+3Ttr8wGsDkx0q0VJRVWx2Zt41xY=NUB8GCJ1LjLk_tw@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings
To:     Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        jackp@codeaurora.org, Andy Gross <andy.gross@linaro.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Shawn Guo <shawn.guo@linaro.org>, Vinod <vkoul@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Khasim Syed Mohammed <khasim.mohammed@linaro.org>,
        devicetree@vger.kernel.org,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Linux USB List <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 6, 2019 at 8:11 AM Jorge Ramirez
<jorge.ramirez-ortiz@linaro.org> wrote:
>
> On 2/5/19 12:02, Jorge Ramirez wrote:
> > On 1/30/19 21:02, Rob Herring wrote:
> >> On Tue, Jan 29, 2019 at 12:35:14PM +0100, Jorge Ramirez-Ortiz wrote:
> >>> Binding description for Qualcomm's Synopsys 1.0.0 super-speed PHY
> >>> controller embedded in QCS404.
> >>>
> >>> Based on Sriharsha Allenki's <sallenki@codeaurora.org> original
> >>> definitions.
> >>>
> >>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> >>> ---
> >>>  .../devicetree/bindings/usb/qcom,usb-ssphy.txt     | 73 ++++++++++++++++++++++
> >>>  1 file changed, 73 insertions(+)
> >>>  create mode 100644 Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt b/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
> >>> new file mode 100644
> >>> index 0000000..8ef6e39
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
> >>> @@ -0,0 +1,73 @@
> >>> +Qualcomm Synopsys 1.0.0 SS phy controller
> >>> +===========================================
> >>> +
> >>> +Synopsys 1.0.0 ss phy controller supports SS usb connectivity on Qualcomm
> >>> +chipsets
> >>> +
> >>> +Required properties:
> >>> +
> >>> +- compatible:
> >>> +    Value type: <string>
> >>> +    Definition: Should contain "qcom,usb-ssphy".
> >>
> >> This is in no way specific enough.
> >
> > ok. will remove the old unused bindings and reuse qcom,dwc3-ss-usb-phy
> >
> >>
> >>> +
> >>> +- reg:
> >>> +    Value type: <prop-encoded-array>
> >>> +    Definition: USB PHY base address and length of the register map.
> >>> +
> >>> +- #phy-cells:
> >>> +    Value type: <u32>
> >>> +    Definition: Should be 0. See phy/phy-bindings.txt for details.
> >>> +
> >>> +- clocks:
> >>> +    Value type: <prop-encoded-array>
> >>> +    Definition: See clock-bindings.txt section "consumers". List of
> >>> +            three clock specifiers for reference, phy core and
> >>> +            pipe clocks.
> >>> +
> >>> +- clock-names:
> >>> +    Value type: <string>
> >>> +    Definition: Names of the clocks in 1-1 correspondence with the "clocks"
> >>> +            property. Must contain "ref", "phy" and "pipe".
> >>> +
> >>> +- vdd-supply:
> >>> +    Value type: <phandle>
> >>> +    Definition: phandle to the regulator VDD supply node.
> >>> +
> >>> +- vdda1p8-supply:
> >>> +    Value type: <phandle>
> >>> +    Definition: phandle to the regulator 1.8V supply node.
> >>> +
> >>> +
> >>> +Optional child nodes:
> >>> +
> >>> +- vbus-supply:
> >>> +    Value type: <phandle>
> >>> +    Definition: phandle to the VBUS supply node.
> >>
> >> Does the phy actually get supplied by Vbus? If not, then Vbus supply
> >> should be defined in a USB connector node.
> >
> > yes per the documentation vbus can optionally be routed to the phy to
> > drive a signal to the controller.
>
>
> funny enough when vbus is optionally routed to the phy is not to be
> controlled like we do when the vbus-supply property is present.
>
> So to all effects no, you are right, the phy does not get supplied by VBUS.
>
> would defining the connector like this be enough?
>
> usb3_phy: usb3-phy@78000 {
>         compatible = "qcom,snps-usb-ssphy";
>         [...]
>         usb3_c_connector: usb3-c-connector {
>                 compatible = "usb-c-connector";
>                 label = "USB-C";
>                 type = "micro";
>                 vbus-supply = <&usb3_vbus_reg>;
>         };
> };

IIRC, the connector node is defined to go under either the USB
controller or a USB-C controller (if a separate chip controlling the
USB-PD and alternate modes). We generally don't put PHYs into a node
topology, but keep them as a phandle reference.

Rob

From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Subject: [v2,1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings
From: Rob Herring <robh@kernel.org>
Message-Id: <CAL_Jsq+3Ttr8wGsDkx0q0VJRVWx2Zt41xY=NUB8GCJ1LjLk_tw@mail.gmail.com>
Date: Tue, 12 Feb 2019 14:47:19 -0600
To: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mark Rutland <mark.rutland@arm.com>, Kishon Vijay Abraham I <kishon@ti.com>, jackp@codeaurora.org, Andy Gross <andy.gross@linaro.org>, Stephen Boyd <swboyd@chromium.org>, Shawn Guo <shawn.guo@linaro.org>, Vinod <vkoul@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Khasim Syed Mohammed <khasim.mohammed@linaro.org>, devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Linux USB List <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
List-ID: <linux-usb.vger.kernel.org>

T24gV2VkLCBGZWIgNiwgMjAxOSBhdCA4OjExIEFNIEpvcmdlIFJhbWlyZXoKPGpvcmdlLnJhbWly
ZXotb3J0aXpAbGluYXJvLm9yZz4gd3JvdGU6Cj4KPiBPbiAyLzUvMTkgMTI6MDIsIEpvcmdlIFJh
bWlyZXogd3JvdGU6Cj4gPiBPbiAxLzMwLzE5IDIxOjAyLCBSb2IgSGVycmluZyB3cm90ZToKPiA+
PiBPbiBUdWUsIEphbiAyOSwgMjAxOSBhdCAxMjozNToxNFBNICswMTAwLCBKb3JnZSBSYW1pcmV6
LU9ydGl6IHdyb3RlOgo+ID4+PiBCaW5kaW5nIGRlc2NyaXB0aW9uIGZvciBRdWFsY29tbSdzIFN5
bm9wc3lzIDEuMC4wIHN1cGVyLXNwZWVkIFBIWQo+ID4+PiBjb250cm9sbGVyIGVtYmVkZGVkIGlu
IFFDUzQwNC4KPiA+Pj4KPiA+Pj4gQmFzZWQgb24gU3JpaGFyc2hhIEFsbGVua2kncyA8c2FsbGVu
a2lAY29kZWF1cm9yYS5vcmc+IG9yaWdpbmFsCj4gPj4+IGRlZmluaXRpb25zLgo+ID4+Pgo+ID4+
PiBTaWduZWQtb2ZmLWJ5OiBKb3JnZSBSYW1pcmV6LU9ydGl6IDxqb3JnZS5yYW1pcmV6LW9ydGl6
QGxpbmFyby5vcmc+Cj4gPj4+IC0tLQo+ID4+PiAgLi4uL2RldmljZXRyZWUvYmluZGluZ3MvdXNi
L3Fjb20sdXNiLXNzcGh5LnR4dCAgICAgfCA3MyArKysrKysrKysrKysrKysrKysrKysrCj4gPj4+
ICAxIGZpbGUgY2hhbmdlZCwgNzMgaW5zZXJ0aW9ucygrKQo+ID4+PiAgY3JlYXRlIG1vZGUgMTAw
NjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvcWNvbSx1c2Itc3NwaHku
dHh0Cj4gPj4+Cj4gPj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu
ZGluZ3MvdXNiL3Fjb20sdXNiLXNzcGh5LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i
aW5kaW5ncy91c2IvcWNvbSx1c2Itc3NwaHkudHh0Cj4gPj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0
Cj4gPj4+IGluZGV4IDAwMDAwMDAuLjhlZjZlMzkKPiA+Pj4gLS0tIC9kZXYvbnVsbAo+ID4+PiAr
KysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL3Fjb20sdXNiLXNzcGh5
LnR4dAo+ID4+PiBAQCAtMCwwICsxLDczIEBACj4gPj4+ICtRdWFsY29tbSBTeW5vcHN5cyAxLjAu
MCBTUyBwaHkgY29udHJvbGxlcgo+ID4+PiArPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQo+ID4+PiArCj4gPj4+ICtTeW5vcHN5cyAxLjAuMCBzcyBwaHkgY29udHJv
bGxlciBzdXBwb3J0cyBTUyB1c2IgY29ubmVjdGl2aXR5IG9uIFF1YWxjb21tCj4gPj4+ICtjaGlw
c2V0cwo+ID4+PiArCj4gPj4+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ID4+PiArCj4gPj4+ICst
IGNvbXBhdGlibGU6Cj4gPj4+ICsgICAgVmFsdWUgdHlwZTogPHN0cmluZz4KPiA+Pj4gKyAgICBE
ZWZpbml0aW9uOiBTaG91bGQgY29udGFpbiAicWNvbSx1c2Itc3NwaHkiLgo+ID4+Cj4gPj4gVGhp
cyBpcyBpbiBubyB3YXkgc3BlY2lmaWMgZW5vdWdoLgo+ID4KPiA+IG9rLiB3aWxsIHJlbW92ZSB0
aGUgb2xkIHVudXNlZCBiaW5kaW5ncyBhbmQgcmV1c2UgcWNvbSxkd2MzLXNzLXVzYi1waHkKPiA+
Cj4gPj4KPiA+Pj4gKwo+ID4+PiArLSByZWc6Cj4gPj4+ICsgICAgVmFsdWUgdHlwZTogPHByb3At
ZW5jb2RlZC1hcnJheT4KPiA+Pj4gKyAgICBEZWZpbml0aW9uOiBVU0IgUEhZIGJhc2UgYWRkcmVz
cyBhbmQgbGVuZ3RoIG9mIHRoZSByZWdpc3RlciBtYXAuCj4gPj4+ICsKPiA+Pj4gKy0gI3BoeS1j
ZWxsczoKPiA+Pj4gKyAgICBWYWx1ZSB0eXBlOiA8dTMyPgo+ID4+PiArICAgIERlZmluaXRpb246
IFNob3VsZCBiZSAwLiBTZWUgcGh5L3BoeS1iaW5kaW5ncy50eHQgZm9yIGRldGFpbHMuCj4gPj4+
ICsKPiA+Pj4gKy0gY2xvY2tzOgo+ID4+PiArICAgIFZhbHVlIHR5cGU6IDxwcm9wLWVuY29kZWQt
YXJyYXk+Cj4gPj4+ICsgICAgRGVmaW5pdGlvbjogU2VlIGNsb2NrLWJpbmRpbmdzLnR4dCBzZWN0
aW9uICJjb25zdW1lcnMiLiBMaXN0IG9mCj4gPj4+ICsgICAgICAgICAgICB0aHJlZSBjbG9jayBz
cGVjaWZpZXJzIGZvciByZWZlcmVuY2UsIHBoeSBjb3JlIGFuZAo+ID4+PiArICAgICAgICAgICAg
cGlwZSBjbG9ja3MuCj4gPj4+ICsKPiA+Pj4gKy0gY2xvY2stbmFtZXM6Cj4gPj4+ICsgICAgVmFs
dWUgdHlwZTogPHN0cmluZz4KPiA+Pj4gKyAgICBEZWZpbml0aW9uOiBOYW1lcyBvZiB0aGUgY2xv
Y2tzIGluIDEtMSBjb3JyZXNwb25kZW5jZSB3aXRoIHRoZSAiY2xvY2tzIgo+ID4+PiArICAgICAg
ICAgICAgcHJvcGVydHkuIE11c3QgY29udGFpbiAicmVmIiwgInBoeSIgYW5kICJwaXBlIi4KPiA+
Pj4gKwo+ID4+PiArLSB2ZGQtc3VwcGx5Ogo+ID4+PiArICAgIFZhbHVlIHR5cGU6IDxwaGFuZGxl
Pgo+ID4+PiArICAgIERlZmluaXRpb246IHBoYW5kbGUgdG8gdGhlIHJlZ3VsYXRvciBWREQgc3Vw
cGx5IG5vZGUuCj4gPj4+ICsKPiA+Pj4gKy0gdmRkYTFwOC1zdXBwbHk6Cj4gPj4+ICsgICAgVmFs
dWUgdHlwZTogPHBoYW5kbGU+Cj4gPj4+ICsgICAgRGVmaW5pdGlvbjogcGhhbmRsZSB0byB0aGUg
cmVndWxhdG9yIDEuOFYgc3VwcGx5IG5vZGUuCj4gPj4+ICsKPiA+Pj4gKwo+ID4+PiArT3B0aW9u
YWwgY2hpbGQgbm9kZXM6Cj4gPj4+ICsKPiA+Pj4gKy0gdmJ1cy1zdXBwbHk6Cj4gPj4+ICsgICAg
VmFsdWUgdHlwZTogPHBoYW5kbGU+Cj4gPj4+ICsgICAgRGVmaW5pdGlvbjogcGhhbmRsZSB0byB0
aGUgVkJVUyBzdXBwbHkgbm9kZS4KPiA+Pgo+ID4+IERvZXMgdGhlIHBoeSBhY3R1YWxseSBnZXQg
c3VwcGxpZWQgYnkgVmJ1cz8gSWYgbm90LCB0aGVuIFZidXMgc3VwcGx5Cj4gPj4gc2hvdWxkIGJl
IGRlZmluZWQgaW4gYSBVU0IgY29ubmVjdG9yIG5vZGUuCj4gPgo+ID4geWVzIHBlciB0aGUgZG9j
dW1lbnRhdGlvbiB2YnVzIGNhbiBvcHRpb25hbGx5IGJlIHJvdXRlZCB0byB0aGUgcGh5IHRvCj4g
PiBkcml2ZSBhIHNpZ25hbCB0byB0aGUgY29udHJvbGxlci4KPgo+Cj4gZnVubnkgZW5vdWdoIHdo
ZW4gdmJ1cyBpcyBvcHRpb25hbGx5IHJvdXRlZCB0byB0aGUgcGh5IGlzIG5vdCB0byBiZQo+IGNv
bnRyb2xsZWQgbGlrZSB3ZSBkbyB3aGVuIHRoZSB2YnVzLXN1cHBseSBwcm9wZXJ0eSBpcyBwcmVz
ZW50Lgo+Cj4gU28gdG8gYWxsIGVmZmVjdHMgbm8sIHlvdSBhcmUgcmlnaHQsIHRoZSBwaHkgZG9l
cyBub3QgZ2V0IHN1cHBsaWVkIGJ5IFZCVVMuCj4KPiB3b3VsZCBkZWZpbmluZyB0aGUgY29ubmVj
dG9yIGxpa2UgdGhpcyBiZSBlbm91Z2g/Cj4KPiB1c2IzX3BoeTogdXNiMy1waHlANzgwMDAgewo+
ICAgICAgICAgY29tcGF0aWJsZSA9ICJxY29tLHNucHMtdXNiLXNzcGh5IjsKPiAgICAgICAgIFsu
Li5dCj4gICAgICAgICB1c2IzX2NfY29ubmVjdG9yOiB1c2IzLWMtY29ubmVjdG9yIHsKPiAgICAg
ICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJ1c2ItYy1jb25uZWN0b3IiOwo+ICAgICAgICAgICAg
ICAgICBsYWJlbCA9ICJVU0ItQyI7Cj4gICAgICAgICAgICAgICAgIHR5cGUgPSAibWljcm8iOwo+
ICAgICAgICAgICAgICAgICB2YnVzLXN1cHBseSA9IDwmdXNiM192YnVzX3JlZz47Cj4gICAgICAg
ICB9Owo+IH07CgpJSVJDLCB0aGUgY29ubmVjdG9yIG5vZGUgaXMgZGVmaW5lZCB0byBnbyB1bmRl
ciBlaXRoZXIgdGhlIFVTQgpjb250cm9sbGVyIG9yIGEgVVNCLUMgY29udHJvbGxlciAoaWYgYSBz
ZXBhcmF0ZSBjaGlwIGNvbnRyb2xsaW5nIHRoZQpVU0ItUEQgYW5kIGFsdGVybmF0ZSBtb2Rlcyku
IFdlIGdlbmVyYWxseSBkb24ndCBwdXQgUEhZcyBpbnRvIGEgbm9kZQp0b3BvbG9neSwgYnV0IGtl
ZXAgdGhlbSBhcyBhIHBoYW5kbGUgcmVmZXJlbmNlLgoKUm9iCg==

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=CPNf=QT=lists.infradead.org=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 92E25C282CA
	for <infradead-linux-arm-kernel@archiver.kernel.org>; Tue, 12 Feb 2019 20:47:38 +0000 (UTC)
Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id 5C294222C1
	for <infradead-linux-arm-kernel@archiver.kernel.org>; Tue, 12 Feb 2019 20:47:38 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JZJB4P0G";
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="FM+PUZNK"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C294222C1
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=lists.infradead.org; s=bombadil.20170209; h=Sender:
	Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:
	List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:
	In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description:
	Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:
	List-Owner; bh=bpnr0wb/80D5a1iVcRwd/Qt2fmvMAY9Pb+KBbIhFPIw=; b=JZJB4P0Gg/4/Jr
	67mlv2FpXahSbJvgRQ2M2n3VI9EKXF0eGWKN+oIo9552XpJd7JdkzWvcM4mMVux8AZ1QtvE/pdy6y
	9lFdkclfkWekOL1PeRnE6SnYLo/HpEtnBIQf25pWH1+tpD+pTfvjo6htxVv6dSR10vvBpcgAqJqiv
	osUhYKRkQz6wB21nNa7cFIeEn/62pfXogaHahlBxT8mZThQupMVdfBgtaT9h0vC2fmOFFlMmGLGto
	VNsyUXrE0x5sdRMEJtF8IPyc+rJxIdUWja5BFV/jpqPbrnu3ZyRvHacMjqv4Vz/IXbCfE3ghkaYpP
	0Rfm7khFD2NE59Eu9Pew==;
Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org)
	by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))
	id 1gtexs-000162-VP; Tue, 12 Feb 2019 20:47:36 +0000
Received: from mail.kernel.org ([198.145.29.99])
 by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux))
 id 1gtexo-00015W-Fn
 for linux-arm-kernel@lists.infradead.org; Tue, 12 Feb 2019 20:47:34 +0000
Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com
 [209.85.222.172])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.kernel.org (Postfix) with ESMTPSA id 0E94B222C7
 for <linux-arm-kernel@lists.infradead.org>;
 Tue, 12 Feb 2019 20:47:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
 s=default; t=1550004452;
 bh=dG3SYe1pky2pZMnt/9eiwxUcZ72JgJN0XyaOEoZJn3w=;
 h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
 b=FM+PUZNK3D89uRZ6qfG335Uq5hmBsBhvekSeSKmu1XIgN++9c4jwSIJW6YrKr4NPL
 LtDj24vbtJ1A1M2pyhqZdin8igeDdXL28v5/NJKHXsGqUDecFAdTmqGMfvRR/flUZk
 VYAiR/qwIQagZHx2bfzfJpIBoS5jDU+QcSC06D2U=
Received: by mail-qk1-f172.google.com with SMTP id y195so16864qka.12
 for <linux-arm-kernel@lists.infradead.org>;
 Tue, 12 Feb 2019 12:47:32 -0800 (PST)
X-Gm-Message-State: AHQUAub6zofdWAKeNg9FWBXh8znWEOzm/149hlqL8lPV/qOqVr+cxLOM
 d9UfhNFiBqBRo3ICmFXArF2Ct+rsChLHBCvd7Q==
X-Google-Smtp-Source: AHgI3IblU/uhnwzaW4iMyxiQLo6YZeD4EDKEJn6whYdWRAEpevbjO/8tQgQXZlTuw77NdG7YUMVYNz0Rbqgu9os8s2I=
X-Received: by 2002:a37:b646:: with SMTP id g67mr4109588qkf.326.1550004451191; 
 Tue, 12 Feb 2019 12:47:31 -0800 (PST)
MIME-Version: 1.0
References: <1548761715-4004-1-git-send-email-jorge.ramirez-ortiz@linaro.org>
 <1548761715-4004-2-git-send-email-jorge.ramirez-ortiz@linaro.org>
 <20190130200218.GB5908@bogus>
 <f6823a9e-f2d0-ca5b-a2f8-eb362221ab81@linaro.org>
 <63959c4f-211e-bc2e-12a4-c4ef61c818a9@linaro.org>
In-Reply-To: <63959c4f-211e-bc2e-12a4-c4ef61c818a9@linaro.org>
From: Rob Herring <robh@kernel.org>
Date: Tue, 12 Feb 2019 14:47:19 -0600
X-Gmail-Original-Message-ID: <CAL_Jsq+3Ttr8wGsDkx0q0VJRVWx2Zt41xY=NUB8GCJ1LjLk_tw@mail.gmail.com>
Message-ID: <CAL_Jsq+3Ttr8wGsDkx0q0VJRVWx2Zt41xY=NUB8GCJ1LjLk_tw@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY
 bindings
To: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 
X-CRM114-CacheID: sfid-20190212_124732_557331_ADFADDDA 
X-CRM114-Status: GOOD (  21.92  )
X-BeenThere: linux-arm-kernel@lists.infradead.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <linux-arm-kernel.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, 
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, 
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org,
 jackp@codeaurora.org, Shawn Guo <shawn.guo@linaro.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Linux USB List <linux-usb@vger.kernel.org>,
 Khasim Syed Mohammed <khasim.mohammed@linaro.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Stephen Boyd <swboyd@chromium.org>, Vinod <vkoul@kernel.org>,
 Bjorn Andersson <bjorn.andersson@linaro.org>,
 linux-arm-msm <linux-arm-msm@vger.kernel.org>,
 Andy Gross <andy.gross@linaro.org>, Kishon Vijay Abraham I <kishon@ti.com>,
 "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
 <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org

On Wed, Feb 6, 2019 at 8:11 AM Jorge Ramirez
<jorge.ramirez-ortiz@linaro.org> wrote:
>
> On 2/5/19 12:02, Jorge Ramirez wrote:
> > On 1/30/19 21:02, Rob Herring wrote:
> >> On Tue, Jan 29, 2019 at 12:35:14PM +0100, Jorge Ramirez-Ortiz wrote:
> >>> Binding description for Qualcomm's Synopsys 1.0.0 super-speed PHY
> >>> controller embedded in QCS404.
> >>>
> >>> Based on Sriharsha Allenki's <sallenki@codeaurora.org> original
> >>> definitions.
> >>>
> >>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> >>> ---
> >>>  .../devicetree/bindings/usb/qcom,usb-ssphy.txt     | 73 ++++++++++++++++++++++
> >>>  1 file changed, 73 insertions(+)
> >>>  create mode 100644 Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt b/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
> >>> new file mode 100644
> >>> index 0000000..8ef6e39
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/usb/qcom,usb-ssphy.txt
> >>> @@ -0,0 +1,73 @@
> >>> +Qualcomm Synopsys 1.0.0 SS phy controller
> >>> +===========================================
> >>> +
> >>> +Synopsys 1.0.0 ss phy controller supports SS usb connectivity on Qualcomm
> >>> +chipsets
> >>> +
> >>> +Required properties:
> >>> +
> >>> +- compatible:
> >>> +    Value type: <string>
> >>> +    Definition: Should contain "qcom,usb-ssphy".
> >>
> >> This is in no way specific enough.
> >
> > ok. will remove the old unused bindings and reuse qcom,dwc3-ss-usb-phy
> >
> >>
> >>> +
> >>> +- reg:
> >>> +    Value type: <prop-encoded-array>
> >>> +    Definition: USB PHY base address and length of the register map.
> >>> +
> >>> +- #phy-cells:
> >>> +    Value type: <u32>
> >>> +    Definition: Should be 0. See phy/phy-bindings.txt for details.
> >>> +
> >>> +- clocks:
> >>> +    Value type: <prop-encoded-array>
> >>> +    Definition: See clock-bindings.txt section "consumers". List of
> >>> +            three clock specifiers for reference, phy core and
> >>> +            pipe clocks.
> >>> +
> >>> +- clock-names:
> >>> +    Value type: <string>
> >>> +    Definition: Names of the clocks in 1-1 correspondence with the "clocks"
> >>> +            property. Must contain "ref", "phy" and "pipe".
> >>> +
> >>> +- vdd-supply:
> >>> +    Value type: <phandle>
> >>> +    Definition: phandle to the regulator VDD supply node.
> >>> +
> >>> +- vdda1p8-supply:
> >>> +    Value type: <phandle>
> >>> +    Definition: phandle to the regulator 1.8V supply node.
> >>> +
> >>> +
> >>> +Optional child nodes:
> >>> +
> >>> +- vbus-supply:
> >>> +    Value type: <phandle>
> >>> +    Definition: phandle to the VBUS supply node.
> >>
> >> Does the phy actually get supplied by Vbus? If not, then Vbus supply
> >> should be defined in a USB connector node.
> >
> > yes per the documentation vbus can optionally be routed to the phy to
> > drive a signal to the controller.
>
>
> funny enough when vbus is optionally routed to the phy is not to be
> controlled like we do when the vbus-supply property is present.
>
> So to all effects no, you are right, the phy does not get supplied by VBUS.
>
> would defining the connector like this be enough?
>
> usb3_phy: usb3-phy@78000 {
>         compatible = "qcom,snps-usb-ssphy";
>         [...]
>         usb3_c_connector: usb3-c-connector {
>                 compatible = "usb-c-connector";
>                 label = "USB-C";
>                 type = "micro";
>                 vbus-supply = <&usb3_vbus_reg>;
>         };
> };

IIRC, the connector node is defined to go under either the USB
controller or a USB-C controller (if a separate chip controlling the
USB-PD and alternate modes). We generally don't put PHYs into a node
topology, but keep them as a phandle reference.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel