From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F1FC433ED for ; Tue, 4 May 2021 13:44:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCE97613C9 for ; Tue, 4 May 2021 13:44:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230478AbhEDNpq (ORCPT ); Tue, 4 May 2021 09:45:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:34284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230263AbhEDNpq (ORCPT ); Tue, 4 May 2021 09:45:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 99C7E613CA; Tue, 4 May 2021 13:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620135891; bh=OoY7sR/hY7LZvtUjMAYF/MkjrOj1a5CCgGxbKU/rJZw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=OKm5uExsk0ndOjKjti3FLrEg5dOu5Bn/nkm/IjPlMivLUIYOHxSais/2AjQIBoRgl K9/aRVq0DtHDKztVBb76apF519fMCRfNLo6hMaArfgpH65ZQ7GCTbaSapPBouurO8u 3MMwDMnC/oay4OKgzu1QCTmmAqM/HkVeP8Y6OzbvFZ0AciXe1RveMMoQhFCd+Sjq7u NEsqSvg9QJCCN4Q2wEnBtddFPY44h6xDHi6zYauc4j7qxRMCMdWjxmX+4Mur6EtzwT SUpBJ9Q/Xybkoa9RvyMw7iYIyV+aIosilO9wkrV8oMC2p3Adl94FNqc39wtB5cRpPx RjbtIijx2Znww== Received: by mail-ed1-f43.google.com with SMTP id g14so10487496edy.6; Tue, 04 May 2021 06:44:51 -0700 (PDT) X-Gm-Message-State: AOAM5301cmq3QB9z4aXZayhu0Tn2lZ5ThKmtR6GlQDrMMozmmxKe1yI0 Ffh+971kj2brO/I8l4OU6eHuCDN5UggOt9yTUw== X-Google-Smtp-Source: ABdhPJyXXxiV2axgsIJtm4Ts4YBQH28fg/zBYx3IUm470HLRGclpfqPPVwgy6hYb18r7lsRW1m5nchaoZwE0g+Re7iY= X-Received: by 2002:aa7:dc10:: with SMTP id b16mr26637920edu.258.1620135890171; Tue, 04 May 2021 06:44:50 -0700 (PDT) MIME-Version: 1.0 References: <20210426095426.118356-1-tsbogend@alpha.franken.de> <20210426095426.118356-2-tsbogend@alpha.franken.de> In-Reply-To: From: Rob Herring Date: Tue, 4 May 2021 08:44:36 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] dt-bindings: gpio: Add devicetree binding for IDT 79RC32434 GPIO controller To: Linus Walleij Cc: Thomas Bogendoerfer , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, May 1, 2021 at 7:13 AM Linus Walleij wrote: > > On Mon, Apr 26, 2021 at 11:54 AM Thomas Bogendoerfer > wrote: > > > Add YAML devicetree binding for IDT 79RC32434 GPIO controller > > > > Signed-off-by: Thomas Bogendoerfer > > --- > > Changes in v4: > > - renamed to idt,32434-gpio this time for real > > Overall looks good to me. > > > +required: > (...) > > + - ngpios > > Is there a *technical* reason why this is required? > > Can't the driver just default to 32 gpios when not specified? > > > + - interrupt-controller > > + - "#interrupt-cells" > > + - interrupts > > Why can't interrupt support be made optional? > > It is fine if the driver errors out if not provided, but > for the bindings this feels optional. > > Or does the thing break unless you handle the IRQs? If the hardware has interrupts, then we should describe that. It's the OS driver that may or may not support interrupts. Rob