All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Andy Gross <agross@kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Rishabh Bhatnagar <rishabhb@codeaurora.org>,
	Doug Anderson <dianders@chromium.org>,
	linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCHv2 0/3] Add LLCC support for SC7180 SoC
Date: Thu, 24 Oct 2019 17:33:04 -0500	[thread overview]
Message-ID: <CAL_Jsq+5p7gQzDfGipNFr1ry-Pc3pDJpcXnAqdX9eo0HLETATQ@mail.gmail.com> (raw)
In-Reply-To: <2fbab8bc38be37fba976d34b2f89e720@codeaurora.org>

On Thu, Oct 24, 2019 at 6:00 AM Sai Prakash Ranjan
<saiprakash.ranjan@codeaurora.org> wrote:
>
> Hi Rob,
>
> On 2019-10-24 01:19, Rob Herring wrote:
> > On Sun, Oct 20, 2019 at 10:32 PM Bjorn Andersson
> > <bjorn.andersson@linaro.org> wrote:
> >>
> >> On Sat 19 Oct 04:37 PDT 2019, Sai Prakash Ranjan wrote:
> >>
> >> > LLCC behaviour is controlled by the configuration data set
> >> > in the llcc-qcom driver, add the same for SC7180 SoC.
> >> > Also convert the existing bindings to json-schema and add
> >> > the compatible for SC7180 SoC.
> >> >
> >>
> >> Thanks for the patches and thanks for the review Stephen. Series
> >> applied
> >
> > And they break dt_binding_check. Please fix.
> >
>
> I did check this and think that the error log from dt_binding_check is
> not valid because it says cache-level is a required property [1], but
> there is no such property in LLCC bindings.

Then you should point out the issue and not just submit stuff ignoring
it. It has to be resolved one way or another.

If you refer to the DT spec[1], cache-level is required. The schema is
just enforcing that now. It's keying off the node name of
'cache-controller'.

Rob

[1] https://github.com/devicetree-org/devicetree-specification/blob/master/source/devicenodes.rst#multi-level-and-shared-cache-nodes-cpuscpul-cache

  reply	other threads:[~2019-10-24 22:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-19 11:37 [PATCHv2 0/3] Add LLCC support for SC7180 SoC Sai Prakash Ranjan
2019-10-19 11:37 ` [PATCHv2 1/3] soc: qcom: llcc: Add configuration data for SC7180 Sai Prakash Ranjan
2019-10-20 18:20   ` Stephen Boyd
2019-10-19 11:37 ` [PATCHv2 2/3] dt-bindings: msm: Convert LLCC bindings to YAML Sai Prakash Ranjan
2019-10-20 18:20   ` Stephen Boyd
2019-10-19 11:37 ` [PATCHv2 3/3] dt-bindings: msm: Add LLCC for SC7180 Sai Prakash Ranjan
2019-10-20 18:20   ` Stephen Boyd
2019-10-21  3:32 ` [PATCHv2 0/3] Add LLCC support for SC7180 SoC Bjorn Andersson
2019-10-23 19:49   ` Rob Herring
2019-10-24 11:00     ` Sai Prakash Ranjan
2019-10-24 22:33       ` Rob Herring [this message]
2019-10-25  7:54         ` Sai Prakash Ranjan
2019-11-13 15:00           ` Sai Prakash Ranjan
2019-11-14 16:49             ` Stephen Boyd
2019-11-15 11:24               ` Sai Prakash Ranjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_Jsq+5p7gQzDfGipNFr1ry-Pc3pDJpcXnAqdX9eo0HLETATQ@mail.gmail.com \
    --to=robh+dt@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=linux-arm-msm-owner@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rishabhb@codeaurora.org \
    --cc=rnayak@codeaurora.org \
    --cc=saiprakash.ranjan@codeaurora.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.