All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Scott Branden <scott.branden@broadcom.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v4] PCI: improve host drivers compile test coverage
Date: Sat, 19 May 2018 14:22:27 -0500	[thread overview]
Message-ID: <CAL_Jsq+83D37Hj5bZ8ZamPnX6AYNd+QvFJEwWK+D=mWQ+QK+=Q@mail.gmail.com> (raw)
In-Reply-To: <20180518214211.GD41790@bhelgaas-glaptop.roam.corp.google.com>

On Fri, May 18, 2018 at 4:42 PM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> Hi Rob,
>
> On Thu, Apr 05, 2018 at 02:31:54PM -0500, Rob Herring wrote:
>> Add COMPILE_TEST on driver config options with it. Some ARM drivers
>> still have arch dependencies, so we have to keep those dependent on ARM.
>>
>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> Cc: Bjorn Helgaas <bhelgaas@google.com>
>> Cc: linux-pci@vger.kernel.org
>> Signed-off-by: Rob Herring <robh@kernel.org>
>
>>  config PCIE_ALTERA
>>       bool "Altera PCIe controller"
>> -     depends on ARM || NIOS2
>> -     depends on OF_PCI
>> +     depends on ARM || NIOS2 || COMPILE_TEST
>
> Did you intend to drop the OF_PCI dependency?

No, that should have been removed when OF_PCI was in commit
4670d610d592 ("PCI: Move OF-related PCI functions into PCI core").

> I see that CONFIG_OF_PCI doesn't exist, so that looks bogus.
>
> But drivers/pci/host/pcie-altera.c still uses
> devm_of_pci_get_host_bridge_resources(), so I think this should probably
> still depend on CONFIG_OF?

There's an empty version so it shouldn't matter.

Rob

  reply	other threads:[~2018-05-19 19:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-05 19:31 Rob Herring
2018-05-18 21:42 ` Bjorn Helgaas
2018-05-19 19:22   ` Rob Herring [this message]
2018-06-12 17:02 ` [v4] " Guenter Roeck
2018-06-13 10:09   ` Lorenzo Pieralisi
2018-06-13 18:11     ` Guenter Roeck
2018-06-14 16:53       ` Lorenzo Pieralisi
2018-06-15 12:58       ` Lorenzo Pieralisi
2018-06-15 17:55         ` Scott Branden
2018-06-15 17:58           ` Scott Branden
2018-06-18 11:34             ` Lorenzo Pieralisi
2018-06-15 18:34           ` Rob Herring
2018-06-18  9:32             ` Lorenzo Pieralisi
2018-06-18 11:42               ` Jan Kiszka
2018-06-18 12:52                 ` Lorenzo Pieralisi
2018-06-18 16:53                   ` Jan Kiszka
2018-06-19  9:27                     ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_Jsq+83D37Hj5bZ8ZamPnX6AYNd+QvFJEwWK+D=mWQ+QK+=Q@mail.gmail.com' \
    --to=robh@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=scott.branden@broadcom.com \
    --subject='Re: [PATCH v4] PCI: improve host drivers compile test coverage' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.