From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AC65C433FE for ; Tue, 28 Sep 2021 19:36:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85C2C60F70 for ; Tue, 28 Sep 2021 19:36:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242544AbhI1Th7 (ORCPT ); Tue, 28 Sep 2021 15:37:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:51702 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242535AbhI1Th5 (ORCPT ); Tue, 28 Sep 2021 15:37:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BF3FA61131; Tue, 28 Sep 2021 19:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632857777; bh=/hPKLMPJTNrhU1SP0bMA34z2EYxtK4mD++/ujAwU6A4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=h6eGGH0fk6/SkY3p+QaFpdTDka6h9KtK4CpJIjQVf8LiUKr8o+llRxPFcV7LkqV8M Z3+hSITUMhBWOBM2/ITWO0IyxyiKGeDl607P7bOazNx5NQbndOq4lieEc+Wyw12tN8 JOgzDoGxiFUZDjfFNrLZI/af0nt8o+C8qPTkKeGO7Vy4ezfLCYV83GcDdeGAZvFLJD nsaEh2q2AhB3eyn708Mfk0UpJq3UzrhLpjTcz80BwIrbgPIoogknndzNBguE5Y/kqL e1nweHR9yTNeX6ZXkne0h52alGpPBYgo8VDGfJ/BdTfu8ejPsguJBhAbS/yE4lX/RY N20xF3Twn9VIw== Received: by mail-ed1-f45.google.com with SMTP id r18so11548545edv.12; Tue, 28 Sep 2021 12:36:17 -0700 (PDT) X-Gm-Message-State: AOAM532jdaDAcW49axkMVF+rx0kVtRbH+NvDM/6yM0rictaltYDnVGZU V4E+64ttQcMKGd548XNSvnVCVdsFOOIIdB+SaA== X-Google-Smtp-Source: ABdhPJxkN1rAEe0u7at9IuCHUo7sUflpWJWdcsHHnqh3vlDJJdBMkZRw+1OPM2MmSyluZXfETP88gy0YMvDpRaQqOk4= X-Received: by 2002:a17:906:fa8a:: with SMTP id lt10mr8741415ejb.320.1632857776271; Tue, 28 Sep 2021 12:36:16 -0700 (PDT) MIME-Version: 1.0 References: <20210928182139.652896-1-f.fainelli@gmail.com> <20210928182139.652896-10-f.fainelli@gmail.com> In-Reply-To: <20210928182139.652896-10-f.fainelli@gmail.com> From: Rob Herring Date: Tue, 28 Sep 2021 14:36:04 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 09/14] irqchip: Provide platform_device to of_irq_init_cb_t To: Florian Fainelli Cc: "linux-kernel@vger.kernel.org" , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Frank Rowand , "moderated list:ARM SUB-ARCHITECTURES" , "open list:MIPS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 28, 2021 at 1:22 PM Florian Fainelli wrote: > > Provide the platform device mapping to the interrupt controller node to > the of_irq_init_cb_t callback such that drivers can make use of it. > > Signed-off-by: Florian Fainelli > --- > drivers/irqchip/irqchip.c | 2 +- > drivers/of/irq.c | 2 +- > include/linux/of_irq.h | 5 ++++- > 3 files changed, 6 insertions(+), 3 deletions(-) Less invasive than I thought as we lose any function typing. Maybe at least the one platform driver, drivers/irqchip/qcom-pdc.c, should have its function parameters updated. Reviewed-by: Rob Herring > > diff --git a/drivers/irqchip/irqchip.c b/drivers/irqchip/irqchip.c > index 3570f0a588c4..289784eefd00 100644 > --- a/drivers/irqchip/irqchip.c > +++ b/drivers/irqchip/irqchip.c > @@ -55,6 +55,6 @@ int platform_irqchip_probe(struct platform_device *pdev) > if (par_np && !irq_find_matching_host(par_np, DOMAIN_BUS_ANY)) > return -EPROBE_DEFER; > > - return irq_init_cb(np, par_np); > + return irq_init_cb(np, par_np, pdev); > } > EXPORT_SYMBOL_GPL(platform_irqchip_probe); > diff --git a/drivers/of/irq.c b/drivers/of/irq.c > index 352e14b007e7..18f3f5c00c87 100644 > --- a/drivers/of/irq.c > +++ b/drivers/of/irq.c > @@ -538,7 +538,7 @@ void __init of_irq_init(const struct of_device_id *matches) > desc->dev, > desc->dev, desc->interrupt_parent); > ret = desc->irq_init_cb(desc->dev, > - desc->interrupt_parent); > + desc->interrupt_parent, NULL); > if (ret) { > of_node_clear_flag(desc->dev, OF_POPULATED); > kfree(desc); > diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h > index aaf219bd0354..89acc8b089f0 100644 > --- a/include/linux/of_irq.h > +++ b/include/linux/of_irq.h > @@ -9,7 +9,10 @@ > #include > #include > > -typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *); > +struct platform_device; > + > +typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *, > + struct platform_device *); > > /* > * Workarounds only applied to 32bit powermac machines > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8105C433F5 for ; Tue, 28 Sep 2021 19:38:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DEFF6109E for ; Tue, 28 Sep 2021 19:38:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8DEFF6109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nk/blULv3aq9JxYdFpizLAaEMR6ah+wcCcOO+IwqbxM=; b=LxBSaiq/J4LH66 rXNydytM7UyYRk+88m6t4FHtpqaZ7ldJ/+tp70XXZS3uxML2IZxyP55QAR1LAy4gcao4ZhYD7HcMs YSsZYu5HnYSAvz+x6T6Bv45/DtWwa8Pl8gBwOpOI0jumxQDmDerosE9uHR6SXNMAyG3LY83x1OaHz BFZ9TztFxNUZTJAXrmyFmnGGi56R094e/tz7drl4UWsqsot2ovAF9ZVRD842RIWE2ZKltuZbCrRBu 1RYW5pwkuVJWzWf8tTkbxMDQL2KYvsKJnKw+ycnGY7w1ppoWlR8NJaMOKgqcJWLMBBA3oCLGHdCeJ kadLjUR42AeLLdqMdDKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVIts-008g7h-BB; Tue, 28 Sep 2021 19:36:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVIto-008g6J-0t for linux-arm-kernel@lists.infradead.org; Tue, 28 Sep 2021 19:36:21 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 34987610FC for ; Tue, 28 Sep 2021 19:36:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632857779; bh=/hPKLMPJTNrhU1SP0bMA34z2EYxtK4mD++/ujAwU6A4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=UF2gC9d9GS/g6XVHUvxJ87Mf2PDfnVIieVi8oUK/uO+8e2uQsqWVHe0F+0NgnG6VE DARdmtVrAqLMvXUM5LK34eGo23eF1vEyu0C+fxZZWmZ3/UhcGA1yoTQbzKSdD2RGEY WbHnU14CQBSOO2omXRo8GsIZvevFXsYBIUvfA4M/Swlj2hRIOKLox03KSzPWasCY3+ s+dc17Ewr5TktkVivBXRCRHk+9Wz7qeNwcB3DTPSKLufpdplmbVPuZt+AYDDTWDIid Xc9O4/goG4LFMIEm2f/HsNBQ2T00/YvtvDyvAHcBgJIdLGvdi0oLa2MyXSTQ+gekMn xnMnWUs371eFw== Received: by mail-ed1-f44.google.com with SMTP id v18so51715259edc.11 for ; Tue, 28 Sep 2021 12:36:19 -0700 (PDT) X-Gm-Message-State: AOAM532NjxUVyX/4lompLSPxB+qFM7GLVGofyuPKl6VLyHNpuv6w4908 YYkspdq1MNJlW51moJNRo3PPYFDB1qTfWwIUbg== X-Google-Smtp-Source: ABdhPJxkN1rAEe0u7at9IuCHUo7sUflpWJWdcsHHnqh3vlDJJdBMkZRw+1OPM2MmSyluZXfETP88gy0YMvDpRaQqOk4= X-Received: by 2002:a17:906:fa8a:: with SMTP id lt10mr8741415ejb.320.1632857776271; Tue, 28 Sep 2021 12:36:16 -0700 (PDT) MIME-Version: 1.0 References: <20210928182139.652896-1-f.fainelli@gmail.com> <20210928182139.652896-10-f.fainelli@gmail.com> In-Reply-To: <20210928182139.652896-10-f.fainelli@gmail.com> From: Rob Herring Date: Tue, 28 Sep 2021 14:36:04 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 09/14] irqchip: Provide platform_device to of_irq_init_cb_t To: Florian Fainelli Cc: "linux-kernel@vger.kernel.org" , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Frank Rowand , "moderated list:ARM SUB-ARCHITECTURES" , "open list:MIPS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_123620_157398_3DD50DA4 X-CRM114-Status: GOOD ( 22.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 28, 2021 at 1:22 PM Florian Fainelli wrote: > > Provide the platform device mapping to the interrupt controller node to > the of_irq_init_cb_t callback such that drivers can make use of it. > > Signed-off-by: Florian Fainelli > --- > drivers/irqchip/irqchip.c | 2 +- > drivers/of/irq.c | 2 +- > include/linux/of_irq.h | 5 ++++- > 3 files changed, 6 insertions(+), 3 deletions(-) Less invasive than I thought as we lose any function typing. Maybe at least the one platform driver, drivers/irqchip/qcom-pdc.c, should have its function parameters updated. Reviewed-by: Rob Herring > > diff --git a/drivers/irqchip/irqchip.c b/drivers/irqchip/irqchip.c > index 3570f0a588c4..289784eefd00 100644 > --- a/drivers/irqchip/irqchip.c > +++ b/drivers/irqchip/irqchip.c > @@ -55,6 +55,6 @@ int platform_irqchip_probe(struct platform_device *pdev) > if (par_np && !irq_find_matching_host(par_np, DOMAIN_BUS_ANY)) > return -EPROBE_DEFER; > > - return irq_init_cb(np, par_np); > + return irq_init_cb(np, par_np, pdev); > } > EXPORT_SYMBOL_GPL(platform_irqchip_probe); > diff --git a/drivers/of/irq.c b/drivers/of/irq.c > index 352e14b007e7..18f3f5c00c87 100644 > --- a/drivers/of/irq.c > +++ b/drivers/of/irq.c > @@ -538,7 +538,7 @@ void __init of_irq_init(const struct of_device_id *matches) > desc->dev, > desc->dev, desc->interrupt_parent); > ret = desc->irq_init_cb(desc->dev, > - desc->interrupt_parent); > + desc->interrupt_parent, NULL); > if (ret) { > of_node_clear_flag(desc->dev, OF_POPULATED); > kfree(desc); > diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h > index aaf219bd0354..89acc8b089f0 100644 > --- a/include/linux/of_irq.h > +++ b/include/linux/of_irq.h > @@ -9,7 +9,10 @@ > #include > #include > > -typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *); > +struct platform_device; > + > +typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *, > + struct platform_device *); > > /* > * Workarounds only applied to 32bit powermac machines > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel