All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Nicolas Saenz Julienne <nsaenzju@redhat.com>
Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devicetree@vger.kernel.org,
	"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
	<bcm-kernel-feedback-list@broadcom.com>,
	"moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" 
	<linux-rpi-kernel@lists.infradead.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stefan Wahren <stefan.wahren@i2se.com>
Subject: Re: [PATCH v2 1/2] ARM: dts: bcm2711-rpi-4-b: Fix pcie0's unit address formatting
Date: Tue, 31 Aug 2021 08:50:34 -0500	[thread overview]
Message-ID: <CAL_Jsq+R06nrnzuY8MxpCsxzcmTg1NW2L5eSNxM2ne+GqwMdgQ@mail.gmail.com> (raw)
In-Reply-To: <20210831125843.1233488-1-nsaenzju@redhat.com>

On Tue, Aug 31, 2021 at 7:59 AM Nicolas Saenz Julienne
<nsaenzju@redhat.com> wrote:
>
> dtbs_check currently complains that:
>
> arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning
> (pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format
> error, expected "0,0"
>
> Unsurprisingly pci@0,0 is the right address, as illustrated by its reg
> property:
>
>     &pcie0 {
>             pci@0,0 {
>                     /*
>                      * As defined in the IEEE Std 1275-1994 document,
>                      * reg is a five-cell address encoded as (phys.hi
>                      * phys.mid phys.lo size.hi size.lo). phys.hi
>                      * should contain the device's BDF as 0b00000000
>                      * bbbbbbbb dddddfff 00000000. The other cells
>                      * should be zero.
>                      */
>                     reg = <0 0 0 0 0>;
>             };
>     };
>
> The device is clearly 0. So fix it.
>
> Also add a missing 'device_type = "pci"'.
>
> Fixes: 258f92d2f840 ("ARM: dts: bcm2711: Add reset controller to xHCI node")
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzju@redhat.com>
> ---
>
> Changes since v1:
>  - s/bus/device/ when talking about unit addresses
>  - Add device_type
>  - Add Suggested-by
>
>  arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Rob Herring <robh@kernel.org>

WARNING: multiple messages have this Message-ID
From: Rob Herring <robh+dt@kernel.org>
To: Nicolas Saenz Julienne <nsaenzju@redhat.com>
Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devicetree@vger.kernel.org,
	 "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
	<bcm-kernel-feedback-list@broadcom.com>,
	 "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE"
	<linux-rpi-kernel@lists.infradead.org>,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stefan Wahren <stefan.wahren@i2se.com>
Subject: Re: [PATCH v2 1/2] ARM: dts: bcm2711-rpi-4-b: Fix pcie0's unit address formatting
Date: Tue, 31 Aug 2021 08:50:34 -0500	[thread overview]
Message-ID: <CAL_Jsq+R06nrnzuY8MxpCsxzcmTg1NW2L5eSNxM2ne+GqwMdgQ@mail.gmail.com> (raw)
In-Reply-To: <20210831125843.1233488-1-nsaenzju@redhat.com>

On Tue, Aug 31, 2021 at 7:59 AM Nicolas Saenz Julienne
<nsaenzju@redhat.com> wrote:
>
> dtbs_check currently complains that:
>
> arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning
> (pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format
> error, expected "0,0"
>
> Unsurprisingly pci@0,0 is the right address, as illustrated by its reg
> property:
>
>     &pcie0 {
>             pci@0,0 {
>                     /*
>                      * As defined in the IEEE Std 1275-1994 document,
>                      * reg is a five-cell address encoded as (phys.hi
>                      * phys.mid phys.lo size.hi size.lo). phys.hi
>                      * should contain the device's BDF as 0b00000000
>                      * bbbbbbbb dddddfff 00000000. The other cells
>                      * should be zero.
>                      */
>                     reg = <0 0 0 0 0>;
>             };
>     };
>
> The device is clearly 0. So fix it.
>
> Also add a missing 'device_type = "pci"'.
>
> Fixes: 258f92d2f840 ("ARM: dts: bcm2711: Add reset controller to xHCI node")
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzju@redhat.com>
> ---
>
> Changes since v1:
>  - s/bus/device/ when talking about unit addresses
>  - Add device_type
>  - Add Suggested-by
>
>  arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-08-31 13:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 12:58 Nicolas Saenz Julienne
2021-08-31 12:58 ` Nicolas Saenz Julienne
2021-08-31 12:58 ` [PATCH v2 2/2] ARM: dts: bcm2711-rpi-4-b: Fix usb's unit address Nicolas Saenz Julienne
2021-08-31 12:58   ` Nicolas Saenz Julienne
2021-08-31 13:50   ` Rob Herring
2021-08-31 13:50     ` Rob Herring
2021-08-31 13:50 ` Rob Herring [this message]
2021-08-31 13:50   ` [PATCH v2 1/2] ARM: dts: bcm2711-rpi-4-b: Fix pcie0's unit address formatting Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_Jsq+R06nrnzuY8MxpCsxzcmTg1NW2L5eSNxM2ne+GqwMdgQ@mail.gmail.com \
    --to=robh+dt@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=nsaenz@kernel.org \
    --cc=nsaenzju@redhat.com \
    --cc=stefan.wahren@i2se.com \
    --subject='Re: [PATCH v2 1/2] ARM: dts: bcm2711-rpi-4-b: Fix pcie0'\''s unit address formatting' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.