From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 423B9C433E4 for ; Fri, 17 Jul 2020 18:56:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F0542074B for ; Fri, 17 Jul 2020 18:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595012184; bh=I9y75J42IaBzL+25s+fqD6Tv/7wRsnJAIgF5M/KtE8s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=HErwePAuj5lCItml72JmBkVEQJj/GKs4YgAm1IwD3ppJqsLUQc4YH+8BKYtAZHCut Cd3DbN8Je3V82VfoaNNn76DDtBeMFj/GtEIgEQR6Y0Fvd/79QxBfESeryDv6/3l+5R 2EFo6AJTEOdX6sqDA0tx5CUWfbwW+LRwtKb14axE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728268AbgGQS4X (ORCPT ); Fri, 17 Jul 2020 14:56:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:59454 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727821AbgGQS4W (ORCPT ); Fri, 17 Jul 2020 14:56:22 -0400 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 282992076A; Fri, 17 Jul 2020 18:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595012182; bh=I9y75J42IaBzL+25s+fqD6Tv/7wRsnJAIgF5M/KtE8s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=YOgbEyq8cf4E8Nzby24S64YuwCPk30Pyc6TNnN/7KLYSfVxUlRfo1LKhyrR1mxvky +WKAv9mBFQCbvz0vPdtusnhCt+1CL9ug4b0T469Si4vy4cJvJHsD2BUfA5WF5cfTXu Ip34uThPZIACCqnZWc/Fy2nh0q2P7d7z2nDgCfPo= Received: by mail-ot1-f49.google.com with SMTP id n24so7584082otr.13; Fri, 17 Jul 2020 11:56:22 -0700 (PDT) X-Gm-Message-State: AOAM530qIsmAXEaTjrYq9QFK+J/sBdSxFgxfeZgVBICnTp8fVmvoLkTP YHvAmVgrvKdj8FTidbfMDb2qHeCKrLeWH9eoBw== X-Google-Smtp-Source: ABdhPJywlK24TqAj8hYZIsgs4xNwf07oJW+ZcpWB866d/ln/mXcc0o7YOwYsKhM3niloEukzN1I53bEoEo12QLx0uaA= X-Received: by 2002:a9d:2646:: with SMTP id a64mr9524072otb.107.1595012181490; Fri, 17 Jul 2020 11:56:21 -0700 (PDT) MIME-Version: 1.0 References: <1594878139-3402-1-git-send-email-rnayak@codeaurora.org> <1594878139-3402-2-git-send-email-rnayak@codeaurora.org> <20200716195913.GA2744252@bogus> In-Reply-To: From: Rob Herring Date: Fri, 17 Jul 2020 12:56:10 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/4] dt-bindings: media: venus: Add an optional power domain for perf voting To: Rajendra Nayak Cc: Stanimir Varbanov , Andy Gross , Bjorn Andersson , linux-arm-msm , Linux Media Mailing List , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Matthias Kaehlcke Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Jul 16, 2020 at 11:52 PM Rajendra Nayak wrote: > > > On 7/17/2020 1:29 AM, Rob Herring wrote: > > On Thu, Jul 16, 2020 at 11:12:16AM +0530, Rajendra Nayak wrote: > >> Add an optional power domain which when specified can be used for > >> setting the performance state of Venus. > > > > The h/w suddenly grew a new power island/domain? Seems like an abuse of > > power-domains... > > The power-domain always existed, we have just managed to survive without > having venus support DVFS and have the domain always be at a high performance > level (set statically by boot code) > Now, if we care to do DVFS and support better PM on the SoC, its important > for the devices to manage this additional power domain (and dynamically > scale it) > > That said, if the name 'opp-pd' makes it look like a software construct, > like Bjorn mentioned, I am fine to give it a real name like 'cx-pd' > Does that sound good? He suggested 'cx' as '-pd' would be redundant. I have no idea what 'cx' means, but fine. > PS: Like I mentioned earlier [1], cx is a shared power island, > not a power island specific to this block, and definitely not a software > pm-domain construct. Put this context/detail into your patches. Assume I don't remember what happened last week. Unfortunately, gmail seems to have no way to filter on unread mails in reply to my replies and doesn't move the thread up in 'Sent' filter, so older threads get lost. Rob > [1] https://lore.kernel.org/patchwork/patch/1241077/