From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Date: Thu, 16 Nov 2017 09:58:35 -0600 Message-ID: References: <20171115194203.13572-1-dmurphy@ti.com> <20171116154139.wed7qmpmv2ffyzv2@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dan Murphy Cc: Mark Rutland , Richard Purdie , Jacek Anaszewski , Pavel Machek , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux LED Subsystem List-Id: linux-leds@vger.kernel.org On Thu, Nov 16, 2017 at 9:45 AM, Dan Murphy wrote: > Rob > > Thanks for the review > > On 11/16/2017 09:41 AM, Rob Herring wrote: >> On Wed, Nov 15, 2017 at 01:42:02PM -0600, Dan Murphy wrote: >>> This adds the devicetree bindings for the LM3692x >>> I2C LED string driver. >>> >>> Acked-by: Pavel Machek >>> Signed-off-by: Dan Murphy >>> --- >>> >>> v3 - No changes >>> v2 - No changes - https://patchwork.kernel.org/patch/10056677/ >>> >>> .../devicetree/bindings/leds/leds-lm3692x.txt | 28 ++++++++++++++++++++++ >>> 1 file changed, 28 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3692x.txt >>> >>> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt >>> new file mode 100644 >>> index 000000000000..cfef67bd4100 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt >>> @@ -0,0 +1,28 @@ >>> +* Texas Instruments - LM3692x Highly Efficient Dual-String White LED Driver >>> + >>> +The LM36922 is an ultra-compact, highly efficient, >>> +two string white-LED driver designed for LCD display >>> +backlighting. >>> + >>> +Required properties: >>> + - compatible: >>> + "ti,lm3692x" >> >> Don't use wildcards in compatible strings. > > Do you mean to remove the x? How do we denote a family of parts then? Yes. With a compatible string for each one. You can have multiple compatible strings if some are a superset of others. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964836AbdKPP7E (ORCPT ); Thu, 16 Nov 2017 10:59:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:51670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbdKPP65 (ORCPT ); Thu, 16 Nov 2017 10:58:57 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B2BC21925 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org X-Google-Smtp-Source: AGs4zMZecz7e+fGNpc97ZpruWms9d1G8tuEHKJLecJlNLCD/uS8bM2FyXGACI7t1ew3OWDXjkfFZUc0FWEQE+WRQX+4= MIME-Version: 1.0 In-Reply-To: References: <20171115194203.13572-1-dmurphy@ti.com> <20171116154139.wed7qmpmv2ffyzv2@rob-hp-laptop> From: Rob Herring Date: Thu, 16 Nov 2017 09:58:35 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver To: Dan Murphy Cc: Mark Rutland , Richard Purdie , Jacek Anaszewski , Pavel Machek , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux LED Subsystem Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 16, 2017 at 9:45 AM, Dan Murphy wrote: > Rob > > Thanks for the review > > On 11/16/2017 09:41 AM, Rob Herring wrote: >> On Wed, Nov 15, 2017 at 01:42:02PM -0600, Dan Murphy wrote: >>> This adds the devicetree bindings for the LM3692x >>> I2C LED string driver. >>> >>> Acked-by: Pavel Machek >>> Signed-off-by: Dan Murphy >>> --- >>> >>> v3 - No changes >>> v2 - No changes - https://patchwork.kernel.org/patch/10056677/ >>> >>> .../devicetree/bindings/leds/leds-lm3692x.txt | 28 ++++++++++++++++++++++ >>> 1 file changed, 28 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3692x.txt >>> >>> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt >>> new file mode 100644 >>> index 000000000000..cfef67bd4100 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt >>> @@ -0,0 +1,28 @@ >>> +* Texas Instruments - LM3692x Highly Efficient Dual-String White LED Driver >>> + >>> +The LM36922 is an ultra-compact, highly efficient, >>> +two string white-LED driver designed for LCD display >>> +backlighting. >>> + >>> +Required properties: >>> + - compatible: >>> + "ti,lm3692x" >> >> Don't use wildcards in compatible strings. > > Do you mean to remove the x? How do we denote a family of parts then? Yes. With a compatible string for each one. You can have multiple compatible strings if some are a superset of others. Rob