From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BED8C3815B for ; Wed, 15 Apr 2020 14:13:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E049B208E4 for ; Wed, 15 Apr 2020 14:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586959996; bh=g9zc9gWFrZts6nCro79E4zNLwGrqjr25+7GmsmkzvQs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=V3Fc6MzW0syCz9KZ/Ya3IWFvQ75XeoJDFrO0+PfhQxsu7UuejG/w2edJQQAIuv3pA a6Tu8lgR1ZVYm68pMfzrdTMoay4vGHx/mSGgrjrHF4mg81MXXEbqTmINQj9nl++M6c 32AWfc8RZxSuEXiQ6GVg2WxofO/VVDXUw42tUiFY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2636489AbgDOONE (ORCPT ); Wed, 15 Apr 2020 10:13:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:49622 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2636464AbgDOOMN (ORCPT ); Wed, 15 Apr 2020 10:12:13 -0400 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 77B722078B; Wed, 15 Apr 2020 14:12:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586959932; bh=g9zc9gWFrZts6nCro79E4zNLwGrqjr25+7GmsmkzvQs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZdESDpha5XBMMH2NumasO7B5X8dXw9HFSztHTSiLifxEnAtw7voFnYGdpI6EuoHdU /ExqpEmsqp0/LnjQX+zOXaD6GTUv5AQ5l84baZvQtB4517udMY6ZG9NdsAZfO/Opr3 DN9/nwsr2l7i0O6illGKVq5zZAke9OzzviJ626A8= Received: by mail-qt1-f178.google.com with SMTP id x2so13298084qtr.0; Wed, 15 Apr 2020 07:12:12 -0700 (PDT) X-Gm-Message-State: AGi0PuagO850FeY1scw2rjKb/80hAINyNkQzSXYbA7vSp8oIqAtX4fkq 04+/o0Tmt1IH7xGdoChOGMlis7ngC7L0MLWCJw== X-Google-Smtp-Source: APiQypKpcfRLgsq5L44xqX/Nd5yT1RL98k+9haGwOML5QU4TMV8UysP823kpICcUXqUoiZVvAG/C9S9NizqCtatbW/E= X-Received: by 2002:ac8:6695:: with SMTP id d21mr21432863qtp.110.1586959931603; Wed, 15 Apr 2020 07:12:11 -0700 (PDT) MIME-Version: 1.0 References: <68208297b49e85adfddf843bc205d154790a49de.1585726761.git.shengjiu.wang@nxp.com> <20200414154643.GA29098@bogus> In-Reply-To: From: Rob Herring Date: Wed, 15 Apr 2020 09:11:58 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 6/7] ASoC: dt-bindings: fsl_easrc: Add document for EASRC To: Shengjiu Wang Cc: Shengjiu Wang , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-ALSA , Timur Tabi , Xiubo Li , linuxppc-dev , Takashi Iwai , Liam Girdwood , Nicolin Chen , Mark Brown , Fabio Estevam , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2020 at 9:56 PM Shengjiu Wang wrote: > > Hi Rob > > On Tue, Apr 14, 2020 at 11:49 PM Rob Herring wrote: > > > > On Wed, Apr 01, 2020 at 04:45:39PM +0800, Shengjiu Wang wrote: > > > EASRC (Enhanced Asynchronous Sample Rate Converter) is a new > > > IP module found on i.MX8MN. > > > > > > Signed-off-by: Shengjiu Wang > > > --- > > > .../devicetree/bindings/sound/fsl,easrc.yaml | 101 ++++++++++++++++++ > > > 1 file changed, 101 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > > new file mode 100644 > > > index 000000000000..14ea60084420 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > > @@ -0,0 +1,101 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/sound/fsl,easrc.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: NXP Asynchronous Sample Rate Converter (ASRC) Controller > > > + > > > +maintainers: > > > + - Shengjiu Wang > > > + > > > +properties: > > > + $nodename: > > > + pattern: "^easrc@.*" > > > + > > > + compatible: > > > + const: fsl,imx8mn-easrc > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + clocks: > > > + items: > > > + - description: Peripheral clock > > > + > > > + clock-names: > > > + items: > > > + - const: mem > > > + > > > + dmas: > > > + maxItems: 8 > > > + > > > + dma-names: > > > + items: > > > + - const: ctx0_rx > > > + - const: ctx0_tx > > > + - const: ctx1_rx > > > + - const: ctx1_tx > > > + - const: ctx2_rx > > > + - const: ctx2_tx > > > + - const: ctx3_rx > > > + - const: ctx3_tx > > > + > > > + firmware-name: > > > + allOf: > > > + - $ref: /schemas/types.yaml#/definitions/string > > > + - const: imx/easrc/easrc-imx8mn.bin > > > + description: The coefficient table for the filters > > > + > > > + fsl,asrc-rate: > > > > fsl,asrc-rate-hz > > Can we keep "fsl,asrc-rate", because I want this property > align with the one in fsl,asrc.txt. These two asrc modules > can share same property name. Oh, yes. So with the example fixed: Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9258C2BA19 for ; Wed, 15 Apr 2020 14:13:15 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66AE320857 for ; Wed, 15 Apr 2020 14:13:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Tuim4rp9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZdESDpha" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66AE320857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BABD486E; Wed, 15 Apr 2020 16:12:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BABD486E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1586959993; bh=g9zc9gWFrZts6nCro79E4zNLwGrqjr25+7GmsmkzvQs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Tuim4rp93bnnS8s014qr1fWpLH9No7W2FFLwNuqzT3F0gbe5vzROpJdO9DSRoxgpB OySIB0Ds0tdY2lwy9MOXYv7DM9icj4CciXK/kKW+pkMoR9ALGRI8I+mRbc/8hoJuQo 7dNDELB+pWOhgZD9hdMqXFauyypiK/6qQDzpdTh0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2F20FF80229; Wed, 15 Apr 2020 16:12:23 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BFA1FF80115; Wed, 15 Apr 2020 16:12:21 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1215DF80115 for ; Wed, 15 Apr 2020 16:12:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1215DF80115 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZdESDpha" Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 82A8720857 for ; Wed, 15 Apr 2020 14:12:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586959932; bh=g9zc9gWFrZts6nCro79E4zNLwGrqjr25+7GmsmkzvQs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZdESDpha5XBMMH2NumasO7B5X8dXw9HFSztHTSiLifxEnAtw7voFnYGdpI6EuoHdU /ExqpEmsqp0/LnjQX+zOXaD6GTUv5AQ5l84baZvQtB4517udMY6ZG9NdsAZfO/Opr3 DN9/nwsr2l7i0O6illGKVq5zZAke9OzzviJ626A8= Received: by mail-qt1-f176.google.com with SMTP id w24so13237079qts.11 for ; Wed, 15 Apr 2020 07:12:12 -0700 (PDT) X-Gm-Message-State: AGi0PuaZpVMG/Solt6iUJMla/7VTY9L3qyYWHUNjL4a4W3hUDhmByJaP 4X/TBBcOPpnKfu2U6YvopGoG1RfSkkSPS0Mihg== X-Google-Smtp-Source: APiQypKpcfRLgsq5L44xqX/Nd5yT1RL98k+9haGwOML5QU4TMV8UysP823kpICcUXqUoiZVvAG/C9S9NizqCtatbW/E= X-Received: by 2002:ac8:6695:: with SMTP id d21mr21432863qtp.110.1586959931603; Wed, 15 Apr 2020 07:12:11 -0700 (PDT) MIME-Version: 1.0 References: <68208297b49e85adfddf843bc205d154790a49de.1585726761.git.shengjiu.wang@nxp.com> <20200414154643.GA29098@bogus> In-Reply-To: From: Rob Herring Date: Wed, 15 Apr 2020 09:11:58 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 6/7] ASoC: dt-bindings: fsl_easrc: Add document for EASRC To: Shengjiu Wang Content-Type: text/plain; charset="UTF-8" Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-ALSA , Timur Tabi , Xiubo Li , Fabio Estevam , Shengjiu Wang , Takashi Iwai , Liam Girdwood , Nicolin Chen , Mark Brown , linuxppc-dev , linux-kernel X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Apr 14, 2020 at 9:56 PM Shengjiu Wang wrote: > > Hi Rob > > On Tue, Apr 14, 2020 at 11:49 PM Rob Herring wrote: > > > > On Wed, Apr 01, 2020 at 04:45:39PM +0800, Shengjiu Wang wrote: > > > EASRC (Enhanced Asynchronous Sample Rate Converter) is a new > > > IP module found on i.MX8MN. > > > > > > Signed-off-by: Shengjiu Wang > > > --- > > > .../devicetree/bindings/sound/fsl,easrc.yaml | 101 ++++++++++++++++++ > > > 1 file changed, 101 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > > new file mode 100644 > > > index 000000000000..14ea60084420 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > > @@ -0,0 +1,101 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/sound/fsl,easrc.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: NXP Asynchronous Sample Rate Converter (ASRC) Controller > > > + > > > +maintainers: > > > + - Shengjiu Wang > > > + > > > +properties: > > > + $nodename: > > > + pattern: "^easrc@.*" > > > + > > > + compatible: > > > + const: fsl,imx8mn-easrc > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + clocks: > > > + items: > > > + - description: Peripheral clock > > > + > > > + clock-names: > > > + items: > > > + - const: mem > > > + > > > + dmas: > > > + maxItems: 8 > > > + > > > + dma-names: > > > + items: > > > + - const: ctx0_rx > > > + - const: ctx0_tx > > > + - const: ctx1_rx > > > + - const: ctx1_tx > > > + - const: ctx2_rx > > > + - const: ctx2_tx > > > + - const: ctx3_rx > > > + - const: ctx3_tx > > > + > > > + firmware-name: > > > + allOf: > > > + - $ref: /schemas/types.yaml#/definitions/string > > > + - const: imx/easrc/easrc-imx8mn.bin > > > + description: The coefficient table for the filters > > > + > > > + fsl,asrc-rate: > > > > fsl,asrc-rate-hz > > Can we keep "fsl,asrc-rate", because I want this property > align with the one in fsl,asrc.txt. These two asrc modules > can share same property name. Oh, yes. So with the example fixed: Reviewed-by: Rob Herring