From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx4/pfuT7c+6havF2MQ2RMbkXQk88r8z1NZu4fnhcN0qyO/9PNasTbYcefxfppd/pE5uLP8Jr ARC-Seal: i=1; a=rsa-sha256; t=1524154087; cv=none; d=google.com; s=arc-20160816; b=kWH/LbU3/eMGuuNGyTqJp+ZI0wDrw/3W8yecBdvh3QIWkAXn7Htn8ndf6Hs4nlI2fO f3inP+aesewkmd1L/aGUwl6OL8yX4IUxxy7iVZ22gj0Cp9CKfu+9njlisNgsE60yeoKO jlD/Be4ePLePTCM4F7Dm5QqHb/jObnATY2fCRAnQ1tZMwbdgzT9L0/6cOLnKCdlrHTKZ 0JJGdQfmBsBZQYhwvOeSPYRfZrFkw1ityBjhwAJsxly0ha/JJeZbJ+KCDKkXiPds7Dlf +XiN/p/dWdjv6X/6kotJblX1odHBC6d1trIBHPGDfr4vjdILSacnkcUjt5HbbwJKMYjL XFcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:dmarc-filter:arc-authentication-results; bh=yHWsX5oZRz/8Tb7GguR6vCd2JUvntecoOj+xJKJ3np0=; b=cpA5qM5FKw136yRvcwdCOweFU2N+AFhm+e5TfY5yUNIelLAevcuPaZisMzGu3liNTA If+KtlhOcdXOVuej0WYAiGRHtCfv/NtvY7y4ZDD3Atxnw6KIA3uu/cdqp2Taz2nR79zu lNrBEAAfpEgwY8ClAddss/Rtu3hze+txtMcEEof88gyuEmYpl/WVQN6/sPy/vo6WJzQB cF5RnekuxwguqYseO3TS9WP2lXWjsSxQWgqqaQgAaNkoWZAVJy21/f1wC0lHEE5rfV/q L483/9zixbBrm7etL1KkI8G672yjZ5Dxu0HnzDkyVlySrFLf4oTmO9ttiMKF4+LAI4Do vEgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of robh+dt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=robh+dt@kernel.org Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of robh+dt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=robh+dt@kernel.org DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64303217D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org MIME-Version: 1.0 In-Reply-To: <1524151019-82823-4-git-send-email-phil@raspberrypi.org> References: <1524151019-82823-1-git-send-email-phil@raspberrypi.org> <1524151019-82823-4-git-send-email-phil@raspberrypi.org> From: Rob Herring Date: Thu, 19 Apr 2018 11:07:45 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH resend v3 3/3] dt-bindings: Document the DT bindings for lan78xx To: Phil Elwell Cc: Woojung Huh , Microchip Linux Driver Support , Mark Rutland , Andrew Lunn , Florian Fainelli , "David S. Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Linus Walleij , Andrew Morton , Randy Dunlap , netdev , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux USB List Content-Type: text/plain; charset="UTF-8" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1598185373794294157?= X-GMAIL-MSGID: =?utf-8?q?1598191397025626599?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, Apr 19, 2018 at 10:16 AM, Phil Elwell wrote: > The Microchip LAN78XX family of devices are Ethernet controllers with > a USB interface. Despite being discoverable devices it can be useful to > be able to configure them from Device Tree, particularly in low-cost > applications without an EEPROM or programmed OTP. > > Document the supported properties in a bindings file. > > Signed-off-by: Phil Elwell > --- > .../devicetree/bindings/net/microchip,lan78xx.txt | 54 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/microchip,lan78xx.txt > > diff --git a/Documentation/devicetree/bindings/net/microchip,lan78xx.txt b/Documentation/devicetree/bindings/net/microchip,lan78xx.txt > new file mode 100644 > index 0000000..a5d701b > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/microchip,lan78xx.txt > @@ -0,0 +1,54 @@ > +Microchip LAN78xx Gigabit Ethernet controller > + > +The LAN78XX devices are usually configured by programming their OTP or with > +an external EEPROM, but some platforms (e.g. Raspberry Pi 3 B+) have neither. > +The Device Tree properties, if present, override the OTP and EEPROM. > + > +Required properties: > +- compatible: Should be one of "usb424,7800", "usb424,7801" or "usb424,7850". > + > +Optional properties: > +- local-mac-address: see ethernet.txt > +- mac-address: see ethernet.txt > + > +Optional properties of the embedded PHY: > +- microchip,led-modes: a 0..4 element vector, with each element configuring > + the operating mode of an LED. Omitted LEDs are turned off. Allowed values > + are defined in "include/dt-bindings/net/microchip-lan78xx.h". > + > +Example: > + > +/* Based on the configuration for a Raspberry Pi 3 B+ */ > +&usb { > + usb1@1 { Same comments as in the dts file: usb-port@1 > + compatible = "usb424,2514"; > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + usb1_1@1 { usb-port@1 > + compatible = "usb424,2514"; > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet: usbether@1 { ethernet@1 > + compatible = "usb424,7800"; > + reg = <1>; > + local-mac-address = [ 00 11 22 33 44 55 ]; > + > + mdio { > + #address-cells = <0x1>; > + #size-cells = <0x0>; > + eth_phy: ethernet-phy@1 { > + reg = <1>; > + microchip,led-modes = < > + LAN78XX_LINK_1000_ACTIVITY > + LAN78XX_LINK_10_100_ACTIVITY > + >; > + }; > + }; > + }; > + }; > + }; > +}; > diff --git a/MAINTAINERS b/MAINTAINERS > index 23735d9..91cb961 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14572,6 +14572,7 @@ M: Woojung Huh > M: Microchip Linux Driver Support > L: netdev@vger.kernel.org > S: Maintained > +F: Documentation/devicetree/bindings/net/microchip,lan78xx.txt > F: drivers/net/usb/lan78xx.* > F: include/dt-bindings/net/microchip-lan78xx.h > > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [resend,v3,3/3] dt-bindings: Document the DT bindings for lan78xx From: Rob Herring Message-Id: Date: Thu, 19 Apr 2018 11:07:45 -0500 To: Phil Elwell Cc: Woojung Huh , Microchip Linux Driver Support , Mark Rutland , Andrew Lunn , Florian Fainelli , "David S. Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Linus Walleij , Andrew Morton , Randy Dunlap , netdev , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux USB List List-ID: T24gVGh1LCBBcHIgMTksIDIwMTggYXQgMTA6MTYgQU0sIFBoaWwgRWx3ZWxsIDxwaGlsQHJhc3Bi ZXJyeXBpLm9yZz4gd3JvdGU6Cj4gVGhlIE1pY3JvY2hpcCBMQU43OFhYIGZhbWlseSBvZiBkZXZp Y2VzIGFyZSBFdGhlcm5ldCBjb250cm9sbGVycyB3aXRoCj4gYSBVU0IgaW50ZXJmYWNlLiBEZXNw aXRlIGJlaW5nIGRpc2NvdmVyYWJsZSBkZXZpY2VzIGl0IGNhbiBiZSB1c2VmdWwgdG8KPiBiZSBh YmxlIHRvIGNvbmZpZ3VyZSB0aGVtIGZyb20gRGV2aWNlIFRyZWUsIHBhcnRpY3VsYXJseSBpbiBs b3ctY29zdAo+IGFwcGxpY2F0aW9ucyB3aXRob3V0IGFuIEVFUFJPTSBvciBwcm9ncmFtbWVkIE9U UC4KPgo+IERvY3VtZW50IHRoZSBzdXBwb3J0ZWQgcHJvcGVydGllcyBpbiBhIGJpbmRpbmdzIGZp bGUuCj4KPiBTaWduZWQtb2ZmLWJ5OiBQaGlsIEVsd2VsbCA8cGhpbEByYXNwYmVycnlwaS5vcmc+ Cj4gLS0tCj4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL25ldC9taWNyb2NoaXAsbGFuNzh4eC50 eHQgIHwgNTQgKysrKysrKysrKysrKysrKysrKysrKwo+ICBNQUlOVEFJTkVSUyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAxICsKPiAgMiBmaWxlcyBjaGFuZ2VkLCA1 NSBpbnNlcnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvbmV0L21pY3JvY2hpcCxsYW43OHh4LnR4dAo+Cj4gZGlmZiAtLWdpdCBh L0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQvbWljcm9jaGlwLGxhbjc4eHgu dHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL25ldC9taWNyb2NoaXAsbGFu Nzh4eC50eHQKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAuLmE1ZDcwMWIK PiAtLS0gL2Rldi9udWxsCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L25ldC9taWNyb2NoaXAsbGFuNzh4eC50eHQKPiBAQCAtMCwwICsxLDU0IEBACj4gK01pY3JvY2hp cCBMQU43OHh4IEdpZ2FiaXQgRXRoZXJuZXQgY29udHJvbGxlcgo+ICsKPiArVGhlIExBTjc4WFgg ZGV2aWNlcyBhcmUgdXN1YWxseSBjb25maWd1cmVkIGJ5IHByb2dyYW1taW5nIHRoZWlyIE9UUCBv ciB3aXRoCj4gK2FuIGV4dGVybmFsIEVFUFJPTSwgYnV0IHNvbWUgcGxhdGZvcm1zIChlLmcuIFJh c3BiZXJyeSBQaSAzIEIrKSBoYXZlIG5laXRoZXIuCj4gK1RoZSBEZXZpY2UgVHJlZSBwcm9wZXJ0 aWVzLCBpZiBwcmVzZW50LCBvdmVycmlkZSB0aGUgT1RQIGFuZCBFRVBST00uCj4gKwo+ICtSZXF1 aXJlZCBwcm9wZXJ0aWVzOgo+ICstIGNvbXBhdGlibGU6IFNob3VsZCBiZSBvbmUgb2YgInVzYjQy NCw3ODAwIiwgInVzYjQyNCw3ODAxIiBvciAidXNiNDI0LDc4NTAiLgo+ICsKPiArT3B0aW9uYWwg cHJvcGVydGllczoKPiArLSBsb2NhbC1tYWMtYWRkcmVzczogICBzZWUgZXRoZXJuZXQudHh0Cj4g Ky0gbWFjLWFkZHJlc3M6ICAgICAgICAgc2VlIGV0aGVybmV0LnR4dAo+ICsKPiArT3B0aW9uYWwg cHJvcGVydGllcyBvZiB0aGUgZW1iZWRkZWQgUEhZOgo+ICstIG1pY3JvY2hpcCxsZWQtbW9kZXM6 IGEgMC4uNCBlbGVtZW50IHZlY3Rvciwgd2l0aCBlYWNoIGVsZW1lbnQgY29uZmlndXJpbmcKPiAr ICB0aGUgb3BlcmF0aW5nIG1vZGUgb2YgYW4gTEVELiBPbWl0dGVkIExFRHMgYXJlIHR1cm5lZCBv ZmYuIEFsbG93ZWQgdmFsdWVzCj4gKyAgYXJlIGRlZmluZWQgaW4gImluY2x1ZGUvZHQtYmluZGlu Z3MvbmV0L21pY3JvY2hpcC1sYW43OHh4LmgiLgo+ICsKPiArRXhhbXBsZToKPiArCj4gKy8qIEJh c2VkIG9uIHRoZSBjb25maWd1cmF0aW9uIGZvciBhIFJhc3BiZXJyeSBQaSAzIEIrICovCj4gKyZ1 c2Igewo+ICsgICAgICAgdXNiMUAxIHsKClNhbWUgY29tbWVudHMgYXMgaW4gdGhlIGR0cyBmaWxl OgoKdXNiLXBvcnRAMQoKPiArICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJ1c2I0MjQsMjUx NCI7Cj4gKyAgICAgICAgICAgICAgIHJlZyA9IDwxPjsKPiArICAgICAgICAgICAgICAgI2FkZHJl c3MtY2VsbHMgPSA8MT47Cj4gKyAgICAgICAgICAgICAgICNzaXplLWNlbGxzID0gPDA+Owo+ICsK PiArICAgICAgICAgICAgICAgdXNiMV8xQDEgewoKdXNiLXBvcnRAMQoKPiArICAgICAgICAgICAg ICAgICAgICAgICBjb21wYXRpYmxlID0gInVzYjQyNCwyNTE0IjsKPiArICAgICAgICAgICAgICAg ICAgICAgICByZWcgPSA8MT47Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgI2FkZHJlc3MtY2Vs bHMgPSA8MT47Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgI3NpemUtY2VsbHMgPSA8MD47Cj4g Kwo+ICsgICAgICAgICAgICAgICAgICAgICAgIGV0aGVybmV0OiB1c2JldGhlckAxIHsKCmV0aGVy bmV0QDEKCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gInVz YjQyNCw3ODAwIjsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwxPjsK PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxvY2FsLW1hYy1hZGRyZXNzID0gWyAw MCAxMSAyMiAzMyA0NCA1NSBdOwo+ICsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IG1kaW8gewo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAjYWRkcmVz cy1jZWxscyA9IDwweDE+Owo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAjc2l6ZS1jZWxscyA9IDwweDA+Owo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBldGhfcGh5OiBldGhlcm5ldC1waHlAMSB7Cj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDE+Owo+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1pY3JvY2hpcCxsZWQtbW9kZXMgPSA8Cj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBM QU43OFhYX0xJTktfMTAwMF9BQ1RJVklUWQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgTEFONzhYWF9MSU5LXzEwXzEwMF9BQ1RJVklUWQo+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgID47Cj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH07Cj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB9Owo+ICsgICAgICAgICAgICAgICAgICAgICAgIH07Cj4gKyAgICAg ICAgICAgICAgIH07Cj4gKyAgICAgICB9Owo+ICt9Owo+IGRpZmYgLS1naXQgYS9NQUlOVEFJTkVS UyBiL01BSU5UQUlORVJTCj4gaW5kZXggMjM3MzVkOS4uOTFjYjk2MSAxMDA2NDQKPiAtLS0gYS9N QUlOVEFJTkVSUwo+ICsrKyBiL01BSU5UQUlORVJTCj4gQEAgLTE0NTcyLDYgKzE0NTcyLDcgQEAg TTogICAgICBXb29qdW5nIEh1aCA8d29vanVuZy5odWhAbWljcm9jaGlwLmNvbT4KPiAgTTogICAg IE1pY3JvY2hpcCBMaW51eCBEcml2ZXIgU3VwcG9ydCA8VU5HTGludXhEcml2ZXJAbWljcm9jaGlw LmNvbT4KPiAgTDogICAgIG5ldGRldkB2Z2VyLmtlcm5lbC5vcmcKPiAgUzogICAgIE1haW50YWlu ZWQKPiArRjogICAgIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQvbWljcm9j aGlwLGxhbjc4eHgudHh0Cj4gIEY6ICAgICBkcml2ZXJzL25ldC91c2IvbGFuNzh4eC4qCj4gIEY6 ICAgICBpbmNsdWRlL2R0LWJpbmRpbmdzL25ldC9taWNyb2NoaXAtbGFuNzh4eC5oCj4KPiAtLQo+ IDIuNy40Cj4KLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5l ICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpv cmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2Vy Lmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo=