From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752030AbeEQQXr (ORCPT ); Thu, 17 May 2018 12:23:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:41112 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbeEQQXo (ORCPT ); Thu, 17 May 2018 12:23:44 -0400 X-Google-Smtp-Source: AB8JxZobk1e9Zry5SsWSEjRSp3R/noASUKfM3gSxqJRHJYHXdoprrWkGm0P0TRAPxQtm2RrZ972lckKkEOH+9zng5CE= MIME-Version: 1.0 In-Reply-To: References: From: Rob Herring Date: Thu, 17 May 2018 11:23:22 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 6/9] dt-bindings: counter: Document stm32 quadrature encoder To: William Breathitt Gray Cc: Jonathan Cameron , Benjamin Gaignard , Fabrice Gasnier , linux-iio@vger.kernel.org, "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Mark Rutland Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 16, 2018 at 12:51 PM, William Breathitt Gray wrote: > From: Benjamin Gaignard v6? Where's v1-v5? > Add bindings for STM32 Timer quadrature encoder. > It is a sub-node of STM32 Timer which implement the > counter part of the hardware. > > Cc: Rob Herring > Cc: Mark Rutland > Signed-off-by: Benjamin Gaignard > Signed-off-by: William Breathitt Gray > --- > .../bindings/counter/stm32-timer-cnt.txt | 26 +++++++++++++++++++ > .../devicetree/bindings/mfd/stm32-timers.txt | 7 +++++ > 2 files changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt > > diff --git a/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt b/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt > new file mode 100644 > index 000000000000..377728128bef > --- /dev/null > +++ b/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt > @@ -0,0 +1,26 @@ > +STMicroelectronics STM32 Timer quadrature encoder > + > +STM32 Timer provides quadrature encoder counter mode to detect 'mode' does not sound like a sub-block of the timers block. > +angular position and direction of rotary elements, > +from IN1 and IN2 input signals. > + > +Must be a sub-node of an STM32 Timer device tree node. > +See ../mfd/stm32-timers.txt for details about the parent node. > + > +Required properties: > +- compatible: Must be "st,stm32-timer-counter". > +- pinctrl-names: Set to "default". > +- pinctrl-0: List of phandles pointing to pin configuration nodes, > + to set IN1/IN2 pins in mode of operation for Low-Power > + Timer input on external pin. > + > +Example: > + timers@40010000 { > + compatible = "st,stm32-timers"; > + ... > + counter { > + compatible = "st,stm32-timer-counter"; Is there only 1? How is the counter addressed? > + pinctrl-names = "default"; > + pinctrl-0 = <&tim1_in_pins>; > + }; > + }; From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh+dt@kernel.org (Rob Herring) Date: Thu, 17 May 2018 11:23:22 -0500 Subject: [PATCH v6 6/9] dt-bindings: counter: Document stm32 quadrature encoder In-Reply-To: References: Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, May 16, 2018 at 12:51 PM, William Breathitt Gray wrote: > From: Benjamin Gaignard v6? Where's v1-v5? > Add bindings for STM32 Timer quadrature encoder. > It is a sub-node of STM32 Timer which implement the > counter part of the hardware. > > Cc: Rob Herring > Cc: Mark Rutland > Signed-off-by: Benjamin Gaignard > Signed-off-by: William Breathitt Gray > --- > .../bindings/counter/stm32-timer-cnt.txt | 26 +++++++++++++++++++ > .../devicetree/bindings/mfd/stm32-timers.txt | 7 +++++ > 2 files changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt > > diff --git a/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt b/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt > new file mode 100644 > index 000000000000..377728128bef > --- /dev/null > +++ b/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt > @@ -0,0 +1,26 @@ > +STMicroelectronics STM32 Timer quadrature encoder > + > +STM32 Timer provides quadrature encoder counter mode to detect 'mode' does not sound like a sub-block of the timers block. > +angular position and direction of rotary elements, > +from IN1 and IN2 input signals. > + > +Must be a sub-node of an STM32 Timer device tree node. > +See ../mfd/stm32-timers.txt for details about the parent node. > + > +Required properties: > +- compatible: Must be "st,stm32-timer-counter". > +- pinctrl-names: Set to "default". > +- pinctrl-0: List of phandles pointing to pin configuration nodes, > + to set IN1/IN2 pins in mode of operation for Low-Power > + Timer input on external pin. > + > +Example: > + timers at 40010000 { > + compatible = "st,stm32-timers"; > + ... > + counter { > + compatible = "st,stm32-timer-counter"; Is there only 1? How is the counter addressed? > + pinctrl-names = "default"; > + pinctrl-0 = <&tim1_in_pins>; > + }; > + };