From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: dts: fun with chip names Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Date: Thu, 16 Nov 2017 14:36:01 -0600 Message-ID: References: <20171115194203.13572-1-dmurphy@ti.com> <20171116154139.wed7qmpmv2ffyzv2@rob-hp-laptop> <20171116201121.GA28848@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail.kernel.org ([198.145.29.99]:58484 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759251AbdKPUgX (ORCPT ); Thu, 16 Nov 2017 15:36:23 -0500 In-Reply-To: <20171116201121.GA28848@amd> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Pavel Machek Cc: Dan Murphy , Mark Rutland , Richard Purdie , Jacek Anaszewski , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux LED Subsystem On Thu, Nov 16, 2017 at 2:11 PM, Pavel Machek wrote: > Hi! > >> >> +Required properties: >> >> + - compatible: >> >> + "ti,lm3692x" >> > >> > Don't use wildcards in compatible strings. >> >> Do you mean to remove the x? How do we denote a family of parts >> then? > > I guess you should specify the exact chip. > > Which will present interesting problem for me on Nokia N9/N950; in one > case, compatible chip is produced by two companies, and it looks like > some machines have one and some have the other; but we'd like to share > the dts as user has no chance telling them apart (and it is not > important, anyway). > > In second case, chip is refered as APDS990X and I don't know where to > get more exact data. There's always exceptions to rules. Just make the case for it. IIRC, there was the same case for the BT chip. Rob