From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE951C63777 for ; Mon, 30 Nov 2020 20:30:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 551A0206ED for ; Mon, 30 Nov 2020 20:30:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="W+iVilSO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730164AbgK3UaB (ORCPT ); Mon, 30 Nov 2020 15:30:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:60140 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728959AbgK3UaA (ORCPT ); Mon, 30 Nov 2020 15:30:00 -0500 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A74742073C for ; Mon, 30 Nov 2020 20:29:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606768160; bh=8p6NimbOeCayqmrZMD8vIX/ZAIUnX0r/wxjNZ1WnXaY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=W+iVilSO1VWZAI5uV16yR1HA16GxYYT2Dj/k6we3Iy77DnVtZTjvG5EtIPyjCtsPn H3pZ8VB7/poFR8T+ER5v1oogysTBrCEJfyDyJbQ645zP0FB4KNNviXO4UnhsrJsn4x 8LMLojOTM8uAsBybQS1LJhUoyCs0K/WMfJaCnGaY= Received: by mail-ed1-f50.google.com with SMTP id m16so18108187edr.3 for ; Mon, 30 Nov 2020 12:29:19 -0800 (PST) X-Gm-Message-State: AOAM5310S7i8j27eFtTUyXOiSQ8zUPvAQX+wo5DeNv8PxNwYVhbT1PDl TiS+YxEkOluQLzT/EyNO0MW5cy5mCP/4sA2MCQ== X-Google-Smtp-Source: ABdhPJx253fAf5hg88WZhzFWnVy0Qrr8HJJkGqNvc+PO7FdlAlN4nMcqcJFZZwVUmJlwsPlgwbYTIlwO2QOQfdpd9TI= X-Received: by 2002:aa7:c816:: with SMTP id a22mr7112436edt.373.1606768158104; Mon, 30 Nov 2020 12:29:18 -0800 (PST) MIME-Version: 1.0 References: <1606746513-30909-1-git-send-email-kevin3.tang@gmail.com> <1606746513-30909-2-git-send-email-kevin3.tang@gmail.com> In-Reply-To: <1606746513-30909-2-git-send-email-kevin3.tang@gmail.com> From: Rob Herring Date: Mon, 30 Nov 2020 13:29:06 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/6] dt-bindings: display: add Unisoc's drm master bindings To: Kevin Tang Cc: Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , Mark Rutland , Orson Zhai , Lyra Zhang , "linux-kernel@vger.kernel.org" , dri-devel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 30, 2020 at 7:28 AM Kevin Tang wrote: > > From: Kevin Tang Once again, DT patches must Cc the DT list if you want them reviewed. > > The Unisoc DRM master device is a virtual device needed to list all > DPU devices or other display interface nodes that comprise the > graphics subsystem > > Cc: Orson Zhai > Cc: Chunyan Zhang > Signed-off-by: Kevin Tang > --- > .../display/sprd/sprd,display-subsystem.yaml | 39 ++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml > > diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml > new file mode 100644 > index 0000000..9487a39 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/sprd/sprd,display-subsystem.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Unisoc DRM master device > + > +maintainers: > + - Kevin Tang > + > +description: | > + The Unisoc DRM master device is a virtual device needed to list all > + DPU devices or other display interface nodes that comprise the > + graphics subsystem. > + > +properties: > + compatible: > + const: sprd,display-subsystem As I said before, we try to avoid these virtual nodes. Make the DRM driver bind to the DPU node. The case where this might be needed is if you have h/w that's a mixture of shared and discrete blocks. I don't see anything here matching that. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7812CC64E7B for ; Mon, 30 Nov 2020 20:29:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E76720855 for ; Mon, 30 Nov 2020 20:29:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="W+iVilSO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E76720855 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 252806E886; Mon, 30 Nov 2020 20:29:21 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 653286E886 for ; Mon, 30 Nov 2020 20:29:20 +0000 (UTC) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF2872087C for ; Mon, 30 Nov 2020 20:29:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606768160; bh=8p6NimbOeCayqmrZMD8vIX/ZAIUnX0r/wxjNZ1WnXaY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=W+iVilSO1VWZAI5uV16yR1HA16GxYYT2Dj/k6we3Iy77DnVtZTjvG5EtIPyjCtsPn H3pZ8VB7/poFR8T+ER5v1oogysTBrCEJfyDyJbQ645zP0FB4KNNviXO4UnhsrJsn4x 8LMLojOTM8uAsBybQS1LJhUoyCs0K/WMfJaCnGaY= Received: by mail-ed1-f44.google.com with SMTP id b2so5928624edy.13 for ; Mon, 30 Nov 2020 12:29:19 -0800 (PST) X-Gm-Message-State: AOAM530X5+OnwQelnoJgt1o8LfduHFYCnDOISm2zdOZJfHs2H94XeMGe qSr+5CAhZ+qwZVR8AHSZZfkW01SiXZTpEv+gYA== X-Google-Smtp-Source: ABdhPJx253fAf5hg88WZhzFWnVy0Qrr8HJJkGqNvc+PO7FdlAlN4nMcqcJFZZwVUmJlwsPlgwbYTIlwO2QOQfdpd9TI= X-Received: by 2002:aa7:c816:: with SMTP id a22mr7112436edt.373.1606768158104; Mon, 30 Nov 2020 12:29:18 -0800 (PST) MIME-Version: 1.0 References: <1606746513-30909-1-git-send-email-kevin3.tang@gmail.com> <1606746513-30909-2-git-send-email-kevin3.tang@gmail.com> In-Reply-To: <1606746513-30909-2-git-send-email-kevin3.tang@gmail.com> From: Rob Herring Date: Mon, 30 Nov 2020 13:29:06 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/6] dt-bindings: display: add Unisoc's drm master bindings To: Kevin Tang X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , Lyra Zhang , "linux-kernel@vger.kernel.org" , dri-devel , Orson Zhai , Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Nov 30, 2020 at 7:28 AM Kevin Tang wrote: > > From: Kevin Tang Once again, DT patches must Cc the DT list if you want them reviewed. > > The Unisoc DRM master device is a virtual device needed to list all > DPU devices or other display interface nodes that comprise the > graphics subsystem > > Cc: Orson Zhai > Cc: Chunyan Zhang > Signed-off-by: Kevin Tang > --- > .../display/sprd/sprd,display-subsystem.yaml | 39 ++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml > > diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml > new file mode 100644 > index 0000000..9487a39 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/sprd/sprd,display-subsystem.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Unisoc DRM master device > + > +maintainers: > + - Kevin Tang > + > +description: | > + The Unisoc DRM master device is a virtual device needed to list all > + DPU devices or other display interface nodes that comprise the > + graphics subsystem. > + > +properties: > + compatible: > + const: sprd,display-subsystem As I said before, we try to avoid these virtual nodes. Make the DRM driver bind to the DPU node. The case where this might be needed is if you have h/w that's a mixture of shared and discrete blocks. I don't see anything here matching that. Rob _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel