From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7312BC4338F for ; Thu, 29 Jul 2021 17:20:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5341D60C41 for ; Thu, 29 Jul 2021 17:20:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231574AbhG2RU4 (ORCPT ); Thu, 29 Jul 2021 13:20:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:38740 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbhG2RUy (ORCPT ); Thu, 29 Jul 2021 13:20:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C67E760F42; Thu, 29 Jul 2021 17:20:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627579250; bh=3u51lRqQafrXq5f6IqvWMxZ1ptNInQdEddFA3TjKAb0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bbTDTTZUuX1tvZrjspUiyv7DKa8/vf8E/FZBxFhlf4W1jolNX6oBAnUQmJLMA+/HO os+AFaPTyDu57ZXYiK1ZmRz+uv4PsMw0xMU5NsT4xSr2TCKBn4DlXJQPC9aOVprzve OXGhvZsI9KJS8jfurdZYrJmlILa2SrwZumTm2BeTDTueOvNKqD7DpMpMemfTMHwQtP m7OWv5mIHK07aUFQSE73K7t6wqG3gJKYxq8Cv36//b5YyWFrVKc2ohRCANV5aEPjFA js5QvQdGh2cPcaatgPANzygIq1RoxijBd88J8YAo6KIOtXqCmuSd4gLTGtZ0TAwS1H 3ysTC+kA1fsag== Received: by mail-ej1-f48.google.com with SMTP id e19so11929870ejs.9; Thu, 29 Jul 2021 10:20:50 -0700 (PDT) X-Gm-Message-State: AOAM532WgPfHP1QJVQvUosrjizcT70WnF0mKtZUW3IjL7SbnwBIGnPIn vRUygH3UR6wGhX9Vti6hopcJNpJ8dapK/6Dmow== X-Google-Smtp-Source: ABdhPJzuipRyW+xyNT+RtqOAnbQFg0W4CvcPJqdZSA4Ju9OA/O4unHd//H8Jvub6DcKsikWuNgfrKfNfwMj6Ur9hAJQ= X-Received: by 2002:a17:906:d287:: with SMTP id ay7mr5417811ejb.360.1627579249347; Thu, 29 Jul 2021 10:20:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Rob Herring Date: Thu, 29 Jul 2021 11:20:37 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/5] DT schema changes for HiKey970 PCIe hardware to work To: Mauro Carvalho Chehab Cc: Linuxarm , mauro.chehab@huawei.com, Binghui Wang , Gustavo Pimentel , Jingoo Han , Xiaowei Song , devicetree@vger.kernel.org, linux-arm-kernel , "linux-kernel@vger.kernel.org" , PCI , linux-phy@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 29, 2021 at 5:56 AM Mauro Carvalho Chehab wrote: > > Hi Rob, > > After our discussions, I'm opting to submit first the DT bindings for the > Kirin 970 PCIe support. > > Patch 1 is there just because patch 2 needs. You already acked on it. > > Patch 5 is also there just as an example of the entire stuff added to > the DTS file. > > The core of this series are patches 2 to 4. They contain the conversion > of the kirin-pcie.txt file to the DT schema, and adds the needed > bindings. > > Currently, it generates some warnings: > > Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@f5000000: pcie@4,0:compatible: None of ['pciclass,0604'] are valid under the given schema > From schema: Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.yaml This should be fixed now in dtschema master. > Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@4,0: reset-gpios: [[4294967295, 1, 0]] is too short Your proposed change to pci-bus.yaml is wrong. It's requiring 4 entries. You need 'minItems: 1'. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C032C4338F for ; Thu, 29 Jul 2021 17:22:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C27D60EE6 for ; Thu, 29 Jul 2021 17:22:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1C27D60EE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6F9sVzugCAaSUn1r54JIcc7gY/TYXHIXTMNDLciaA88=; b=fX3w/OcWS5ptyP BpQGB1oMdSJxCKK4mk3HLwDLhjl3iGh0fQXdtEjDjX4mWGH4XQFwCJNJcNVPGiyXO+UUgTSnBXgMm Vg9O11ZPTjCU5UCRYDv+i/6WHlPkK1/2qTCcqwr6bthgrRj6tN6M9EXaOfv9QCJrZK7f0ZvpkqUkJ Otlp36UmFTZSlVzC3rnjceleLECW65e/RgNDd4QG4BvNyKuWfhgElUvFKMelLUA+sRHzLJokUMvqB ytXiwHGQ6nVl7hhM7vlJTJkzC/ssY/+c9Ylat4PTs8TPBfIgHKE2WpwwvJLwu+1luoglw16M3941U PwjDHJ3Ijy6N7Z76WZNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m99iJ-005J2a-Jq; Thu, 29 Jul 2021 17:20:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m99iF-005J15-6d; Thu, 29 Jul 2021 17:20:52 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C477260F23; Thu, 29 Jul 2021 17:20:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627579250; bh=3u51lRqQafrXq5f6IqvWMxZ1ptNInQdEddFA3TjKAb0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bbTDTTZUuX1tvZrjspUiyv7DKa8/vf8E/FZBxFhlf4W1jolNX6oBAnUQmJLMA+/HO os+AFaPTyDu57ZXYiK1ZmRz+uv4PsMw0xMU5NsT4xSr2TCKBn4DlXJQPC9aOVprzve OXGhvZsI9KJS8jfurdZYrJmlILa2SrwZumTm2BeTDTueOvNKqD7DpMpMemfTMHwQtP m7OWv5mIHK07aUFQSE73K7t6wqG3gJKYxq8Cv36//b5YyWFrVKc2ohRCANV5aEPjFA js5QvQdGh2cPcaatgPANzygIq1RoxijBd88J8YAo6KIOtXqCmuSd4gLTGtZ0TAwS1H 3ysTC+kA1fsag== Received: by mail-ej1-f46.google.com with SMTP id qk33so11883242ejc.12; Thu, 29 Jul 2021 10:20:50 -0700 (PDT) X-Gm-Message-State: AOAM533kfjdkq3lZJ+GoY/HMYIWy/wcillB+JHHbwdVexM4WQfNSD4tV 9rWcgtKwwb0G/Tw1OIYF2gQe7ysAa2w5jZkpXg== X-Google-Smtp-Source: ABdhPJzuipRyW+xyNT+RtqOAnbQFg0W4CvcPJqdZSA4Ju9OA/O4unHd//H8Jvub6DcKsikWuNgfrKfNfwMj6Ur9hAJQ= X-Received: by 2002:a17:906:d287:: with SMTP id ay7mr5417811ejb.360.1627579249347; Thu, 29 Jul 2021 10:20:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Rob Herring Date: Thu, 29 Jul 2021 11:20:37 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/5] DT schema changes for HiKey970 PCIe hardware to work To: Mauro Carvalho Chehab Cc: Linuxarm , mauro.chehab@huawei.com, Binghui Wang , Gustavo Pimentel , Jingoo Han , Xiaowei Song , devicetree@vger.kernel.org, linux-arm-kernel , "linux-kernel@vger.kernel.org" , PCI , linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_102051_323783_309AEEBA X-CRM114-Status: GOOD ( 13.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 29, 2021 at 5:56 AM Mauro Carvalho Chehab wrote: > > Hi Rob, > > After our discussions, I'm opting to submit first the DT bindings for the > Kirin 970 PCIe support. > > Patch 1 is there just because patch 2 needs. You already acked on it. > > Patch 5 is also there just as an example of the entire stuff added to > the DTS file. > > The core of this series are patches 2 to 4. They contain the conversion > of the kirin-pcie.txt file to the DT schema, and adds the needed > bindings. > > Currently, it generates some warnings: > > Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@f5000000: pcie@4,0:compatible: None of ['pciclass,0604'] are valid under the given schema > From schema: Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.yaml This should be fixed now in dtschema master. > Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@4,0: reset-gpios: [[4294967295, 1, 0]] is too short Your proposed change to pci-bus.yaml is wrong. It's requiring 4 entries. You need 'minItems: 1'. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 375E8C4338F for ; Thu, 29 Jul 2021 17:21:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED8B560EE6 for ; Thu, 29 Jul 2021 17:21:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ED8B560EE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MaMdCXQUZWOf8OPV8BKzkrobfZ17Pk++2UYezXAh/xA=; b=Lymw/qq9YMxpZE 5ilIsPVr/8/pLRYvuRUVAYJuReoquQJiJaGWlF7dHXGhOCwY5OTeEjiiyZKImOAVBbj+AZNO6IQWA epHWcF1xwne0euphC+3y0ETSMCb/Ug2EOsJWnV8zbEvjDy3HK1JoVHc90aFytTHDc1ZZhY87/A8xK 9zGG5QRX5UeV4ijNCmpLM50azUiAMt6UHk6SAjpJmzbHrAeondRBQO8wlhkEOnjN0VLD80VpLBMnq oSxVlOMXrEzqJ2wb0EKc5WPzuYj3JO6R8chpYAVWj/GaELH2YJGbw+KEMikT3sGOa8bv/uk+t/Ikq R6g8AMjNAyCzsaMpW2vA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m99iT-005J48-FU; Thu, 29 Jul 2021 17:21:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m99iF-005J15-6d; Thu, 29 Jul 2021 17:20:52 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C477260F23; Thu, 29 Jul 2021 17:20:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627579250; bh=3u51lRqQafrXq5f6IqvWMxZ1ptNInQdEddFA3TjKAb0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bbTDTTZUuX1tvZrjspUiyv7DKa8/vf8E/FZBxFhlf4W1jolNX6oBAnUQmJLMA+/HO os+AFaPTyDu57ZXYiK1ZmRz+uv4PsMw0xMU5NsT4xSr2TCKBn4DlXJQPC9aOVprzve OXGhvZsI9KJS8jfurdZYrJmlILa2SrwZumTm2BeTDTueOvNKqD7DpMpMemfTMHwQtP m7OWv5mIHK07aUFQSE73K7t6wqG3gJKYxq8Cv36//b5YyWFrVKc2ohRCANV5aEPjFA js5QvQdGh2cPcaatgPANzygIq1RoxijBd88J8YAo6KIOtXqCmuSd4gLTGtZ0TAwS1H 3ysTC+kA1fsag== Received: by mail-ej1-f46.google.com with SMTP id qk33so11883242ejc.12; Thu, 29 Jul 2021 10:20:50 -0700 (PDT) X-Gm-Message-State: AOAM533kfjdkq3lZJ+GoY/HMYIWy/wcillB+JHHbwdVexM4WQfNSD4tV 9rWcgtKwwb0G/Tw1OIYF2gQe7ysAa2w5jZkpXg== X-Google-Smtp-Source: ABdhPJzuipRyW+xyNT+RtqOAnbQFg0W4CvcPJqdZSA4Ju9OA/O4unHd//H8Jvub6DcKsikWuNgfrKfNfwMj6Ur9hAJQ= X-Received: by 2002:a17:906:d287:: with SMTP id ay7mr5417811ejb.360.1627579249347; Thu, 29 Jul 2021 10:20:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Rob Herring Date: Thu, 29 Jul 2021 11:20:37 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/5] DT schema changes for HiKey970 PCIe hardware to work To: Mauro Carvalho Chehab Cc: Linuxarm , mauro.chehab@huawei.com, Binghui Wang , Gustavo Pimentel , Jingoo Han , Xiaowei Song , devicetree@vger.kernel.org, linux-arm-kernel , "linux-kernel@vger.kernel.org" , PCI , linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_102051_323783_309AEEBA X-CRM114-Status: GOOD ( 13.13 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Thu, Jul 29, 2021 at 5:56 AM Mauro Carvalho Chehab wrote: > > Hi Rob, > > After our discussions, I'm opting to submit first the DT bindings for the > Kirin 970 PCIe support. > > Patch 1 is there just because patch 2 needs. You already acked on it. > > Patch 5 is also there just as an example of the entire stuff added to > the DTS file. > > The core of this series are patches 2 to 4. They contain the conversion > of the kirin-pcie.txt file to the DT schema, and adds the needed > bindings. > > Currently, it generates some warnings: > > Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@f5000000: pcie@4,0:compatible: None of ['pciclass,0604'] are valid under the given schema > From schema: Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.yaml This should be fixed now in dtschema master. > Documentation/devicetree/bindings/pci/hisilicon,kirin-pcie.example.dt.yaml: pcie@4,0: reset-gpios: [[4294967295, 1, 0]] is too short Your proposed change to pci-bus.yaml is wrong. It's requiring 4 entries. You need 'minItems: 1'. Rob -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy