From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752471AbdC0Uan (ORCPT ); Mon, 27 Mar 2017 16:30:43 -0400 Received: from mail.kernel.org ([198.145.29.136]:36884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677AbdC0Uac (ORCPT ); Mon, 27 Mar 2017 16:30:32 -0400 MIME-Version: 1.0 In-Reply-To: <1490621848-24828-8-git-send-email-stefan.wahren@i2se.com> References: <1490621848-24828-1-git-send-email-stefan.wahren@i2se.com> <1490621848-24828-8-git-send-email-stefan.wahren@i2se.com> From: Rob Herring Date: Mon, 27 Mar 2017 15:30:01 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART To: Stefan Wahren Cc: Mark Rutland , "David S. Miller" , Greg Kroah-Hartman , Jiri Slaby , Marcel Holtmann , Sebastian Reichel , netdev , "devicetree@vger.kernel.org" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren wrote: > This is the serdev binding for the QCA7000 UART driver (Ethernet over UART). > > Signed-off-by: Stefan Wahren > --- > > According to this binding are still some questions: > > Where should be the optional hardware flow control defined (at master or slave side)? Probably should be in the slave side. We already have uart-has-rtscts and rts/cts-gpios for the UART. Those mean we have RTS/CTS, but not necessarily that we want to enable them. In many cases, the driver may know what it needs. > Is it okay to have two bindings (qca-qca7000-spi and qca-qca7000-uart) or should they be merged? Are they mutually-exclusive or both are used at the same time? What are the dependencies between the interfaces? > > > .../devicetree/bindings/net/qca-qca7000-uart.txt | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/qca-qca7000-uart.txt > > diff --git a/Documentation/devicetree/bindings/net/qca-qca7000-uart.txt b/Documentation/devicetree/bindings/net/qca-qca7000-uart.txt > new file mode 100644 > index 0000000..f2e0450 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/qca-qca7000-uart.txt > @@ -0,0 +1,31 @@ > +* Qualcomm QCA7000 (Ethernet over UART protocol) > + > +Note: This binding applies in case the QCA7000 is configured as a > +UART slave device. It is possible to preconfigure the UART settings > +of the QCA7000 firmware, which can't be changed during runtime. > + > +Required properties: > +- compatible : Should be "qca,qca7000-uart" > + > +Optional properties: > +- local-mac-address : 6 bytes, Specifies MAC address The description can be "see ./ethernet.txt" > +- current-speed : Specifies the serial device speed in > + bits per second (default = 115200), which is > + predefined by the QCA7000 firmware configuration Add this to the slave binding doc with some caveats as to when this should or should not be used as we discussed. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART Date: Mon, 27 Mar 2017 15:30:01 -0500 Message-ID: References: <1490621848-24828-1-git-send-email-stefan.wahren@i2se.com> <1490621848-24828-8-git-send-email-stefan.wahren@i2se.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Mark Rutland , "David S. Miller" , Greg Kroah-Hartman , Jiri Slaby , Marcel Holtmann , Sebastian Reichel , netdev , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" To: Stefan Wahren Return-path: In-Reply-To: <1490621848-24828-8-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren wrote: > This is the serdev binding for the QCA7000 UART driver (Ethernet over UART). > > Signed-off-by: Stefan Wahren > --- > > According to this binding are still some questions: > > Where should be the optional hardware flow control defined (at master or slave side)? Probably should be in the slave side. We already have uart-has-rtscts and rts/cts-gpios for the UART. Those mean we have RTS/CTS, but not necessarily that we want to enable them. In many cases, the driver may know what it needs. > Is it okay to have two bindings (qca-qca7000-spi and qca-qca7000-uart) or should they be merged? Are they mutually-exclusive or both are used at the same time? What are the dependencies between the interfaces? > > > .../devicetree/bindings/net/qca-qca7000-uart.txt | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/qca-qca7000-uart.txt > > diff --git a/Documentation/devicetree/bindings/net/qca-qca7000-uart.txt b/Documentation/devicetree/bindings/net/qca-qca7000-uart.txt > new file mode 100644 > index 0000000..f2e0450 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/qca-qca7000-uart.txt > @@ -0,0 +1,31 @@ > +* Qualcomm QCA7000 (Ethernet over UART protocol) > + > +Note: This binding applies in case the QCA7000 is configured as a > +UART slave device. It is possible to preconfigure the UART settings > +of the QCA7000 firmware, which can't be changed during runtime. > + > +Required properties: > +- compatible : Should be "qca,qca7000-uart" > + > +Optional properties: > +- local-mac-address : 6 bytes, Specifies MAC address The description can be "see ./ethernet.txt" > +- current-speed : Specifies the serial device speed in > + bits per second (default = 115200), which is > + predefined by the QCA7000 firmware configuration Add this to the slave binding doc with some caveats as to when this should or should not be used as we discussed. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html