From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933933AbdDETFJ convert rfc822-to-8bit (ORCPT ); Wed, 5 Apr 2017 15:05:09 -0400 Received: from mail.kernel.org ([198.145.29.136]:45792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933447AbdDETEe (ORCPT ); Wed, 5 Apr 2017 15:04:34 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170402133304.56824-1-icenowy@aosc.io> <20170402133304.56824-2-icenowy@aosc.io> <20170404144715.fa5sy427u2cz4e6z@rob-hp-laptop> From: Rob Herring Date: Wed, 5 Apr 2017 14:04:02 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3 To: Icenowy Zheng Cc: "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Quentin Schulz , linux-sunxi , Jonathan Cameron , Maxime Ripard , Chen-Yu Tsai , Lee Jones , Zhang Rui , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 4, 2017 at 10:02 AM, Icenowy Zheng wrote: > > > 在 2017年04月04日 22:47, Rob Herring 写道: >> >> On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote: >>> >>> Allwinner H3 features a thermal sensor like the one in A33, but has its >>> register re-arranged, the clock divider moved to CCU (originally the >>> clock divider is in ADC) and added a pair of bus clock and reset. >>> >>> Update the binding document to cover H3. >>> >>> Signed-off-by: Icenowy Zheng >>> --- >>> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 23 >>> ++++++++++++++++++++-- >>> 1 file changed, 21 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> index badff3611a98..7753133ca0ff 100644 >>> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act as >>> a thermal sensor >>> and sometimes as a touchscreen controller. >>> >>> Required properties: >>> - - compatible: "allwinner,sun8i-a33-ths", >>> + - compatible: must contain one of the following compatibles: >>> + - "allwinner,sun8i-a33-ths" >>> + - "allwinner,sun8i-h3-ths" >>> - reg: mmio address range of the chip, >>> - #thermal-sensor-cells: shall be 0, >>> - #io-channel-cells: shall be 0, >>> >>> -Example: >>> +Required properties for the following compatibles: >>> + - "allwinner,sun8i-h3-ths" >>> + - clocks: the bus clock and the input clock of the ADC, >>> + - clock-names: should be "bus" and "ths", >>> + - resets: the bus reset of the ADC, >>> + >>> +Example for A33: >>> ths: ths@01c25000 { >>> compatible = "allwinner,sun8i-a33-ths"; >>> reg = <0x01c25000 0x100>; >>> @@ -17,6 +25,17 @@ Example: >>> #io-channel-cells = <0>; >>> }; >>> >>> +Example for H3: >>> + ths: ths@01c25000 { >> >> >> adc@... > > > It's a thermal sensor, so I think call it THS is more appropriate > here. It's implemented as an ADC driver just because the internal > code reusing of Linux. From device tree binding view I choose to > call it ths. There's numerous occurrences in this file and the filename that call it an ADC. Furthermore, node names are supposed to be generic, not part #'s or whatever you decide to make up. So pick from adc or temperature-sensor as those are the standard names . Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3 Date: Wed, 5 Apr 2017 14:04:02 -0500 Message-ID: References: <20170402133304.56824-1-icenowy@aosc.io> <20170402133304.56824-2-icenowy@aosc.io> <20170404144715.fa5sy427u2cz4e6z@rob-hp-laptop> Reply-To: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Quentin Schulz , linux-sunxi , Jonathan Cameron , Maxime Ripard , Chen-Yu Tsai , Lee Jones , Zhang Rui , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, Apr 4, 2017 at 10:02 AM, Icenowy Zheng wrote: > > > =E5=9C=A8 2017=E5=B9=B404=E6=9C=8804=E6=97=A5 22:47, Rob Herring =E5=86= =99=E9=81=93: >> >> On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote: >>> >>> Allwinner H3 features a thermal sensor like the one in A33, but has its >>> register re-arranged, the clock divider moved to CCU (originally the >>> clock divider is in ADC) and added a pair of bus clock and reset. >>> >>> Update the binding document to cover H3. >>> >>> Signed-off-by: Icenowy Zheng >>> --- >>> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 23 >>> ++++++++++++++++++++-- >>> 1 file changed, 21 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> index badff3611a98..7753133ca0ff 100644 >>> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act = as >>> a thermal sensor >>> and sometimes as a touchscreen controller. >>> >>> Required properties: >>> - - compatible: "allwinner,sun8i-a33-ths", >>> + - compatible: must contain one of the following compatibles: >>> + - "allwinner,sun8i-a33-ths" >>> + - "allwinner,sun8i-h3-ths" >>> - reg: mmio address range of the chip, >>> - #thermal-sensor-cells: shall be 0, >>> - #io-channel-cells: shall be 0, >>> >>> -Example: >>> +Required properties for the following compatibles: >>> + - "allwinner,sun8i-h3-ths" >>> + - clocks: the bus clock and the input clock of the ADC, >>> + - clock-names: should be "bus" and "ths", >>> + - resets: the bus reset of the ADC, >>> + >>> +Example for A33: >>> ths: ths@01c25000 { >>> compatible =3D "allwinner,sun8i-a33-ths"; >>> reg =3D <0x01c25000 0x100>; >>> @@ -17,6 +25,17 @@ Example: >>> #io-channel-cells =3D <0>; >>> }; >>> >>> +Example for H3: >>> + ths: ths@01c25000 { >> >> >> adc@... > > > It's a thermal sensor, so I think call it THS is more appropriate > here. It's implemented as an ADC driver just because the internal > code reusing of Linux. From device tree binding view I choose to > call it ths. There's numerous occurrences in this file and the filename that call it an = ADC. Furthermore, node names are supposed to be generic, not part #'s or whatever you decide to make up. So pick from adc or temperature-sensor as those are the standard names . Rob --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.136]:45792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933447AbdDETEe (ORCPT ); Wed, 5 Apr 2017 15:04:34 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170402133304.56824-1-icenowy@aosc.io> <20170402133304.56824-2-icenowy@aosc.io> <20170404144715.fa5sy427u2cz4e6z@rob-hp-laptop> From: Rob Herring Date: Wed, 5 Apr 2017 14:04:02 -0500 Message-ID: Subject: Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3 To: Icenowy Zheng Cc: "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Quentin Schulz , linux-sunxi , Jonathan Cameron , Maxime Ripard , Chen-Yu Tsai , Lee Jones , Zhang Rui , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Tue, Apr 4, 2017 at 10:02 AM, Icenowy Zheng wrote: > > > 在 2017年04月04日 22:47, Rob Herring 写道: >> >> On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote: >>> >>> Allwinner H3 features a thermal sensor like the one in A33, but has its >>> register re-arranged, the clock divider moved to CCU (originally the >>> clock divider is in ADC) and added a pair of bus clock and reset. >>> >>> Update the binding document to cover H3. >>> >>> Signed-off-by: Icenowy Zheng >>> --- >>> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 23 >>> ++++++++++++++++++++-- >>> 1 file changed, 21 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> index badff3611a98..7753133ca0ff 100644 >>> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act as >>> a thermal sensor >>> and sometimes as a touchscreen controller. >>> >>> Required properties: >>> - - compatible: "allwinner,sun8i-a33-ths", >>> + - compatible: must contain one of the following compatibles: >>> + - "allwinner,sun8i-a33-ths" >>> + - "allwinner,sun8i-h3-ths" >>> - reg: mmio address range of the chip, >>> - #thermal-sensor-cells: shall be 0, >>> - #io-channel-cells: shall be 0, >>> >>> -Example: >>> +Required properties for the following compatibles: >>> + - "allwinner,sun8i-h3-ths" >>> + - clocks: the bus clock and the input clock of the ADC, >>> + - clock-names: should be "bus" and "ths", >>> + - resets: the bus reset of the ADC, >>> + >>> +Example for A33: >>> ths: ths@01c25000 { >>> compatible = "allwinner,sun8i-a33-ths"; >>> reg = <0x01c25000 0x100>; >>> @@ -17,6 +25,17 @@ Example: >>> #io-channel-cells = <0>; >>> }; >>> >>> +Example for H3: >>> + ths: ths@01c25000 { >> >> >> adc@... > > > It's a thermal sensor, so I think call it THS is more appropriate > here. It's implemented as an ADC driver just because the internal > code reusing of Linux. From device tree binding view I choose to > call it ths. There's numerous occurrences in this file and the filename that call it an ADC. Furthermore, node names are supposed to be generic, not part #'s or whatever you decide to make up. So pick from adc or temperature-sensor as those are the standard names . Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Wed, 5 Apr 2017 14:04:02 -0500 Subject: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3 In-Reply-To: References: <20170402133304.56824-1-icenowy@aosc.io> <20170402133304.56824-2-icenowy@aosc.io> <20170404144715.fa5sy427u2cz4e6z@rob-hp-laptop> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Apr 4, 2017 at 10:02 AM, Icenowy Zheng wrote: > > > ? 2017?04?04? 22:47, Rob Herring ??: >> >> On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote: >>> >>> Allwinner H3 features a thermal sensor like the one in A33, but has its >>> register re-arranged, the clock divider moved to CCU (originally the >>> clock divider is in ADC) and added a pair of bus clock and reset. >>> >>> Update the binding document to cover H3. >>> >>> Signed-off-by: Icenowy Zheng >>> --- >>> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 23 >>> ++++++++++++++++++++-- >>> 1 file changed, 21 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> index badff3611a98..7753133ca0ff 100644 >>> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>> @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act as >>> a thermal sensor >>> and sometimes as a touchscreen controller. >>> >>> Required properties: >>> - - compatible: "allwinner,sun8i-a33-ths", >>> + - compatible: must contain one of the following compatibles: >>> + - "allwinner,sun8i-a33-ths" >>> + - "allwinner,sun8i-h3-ths" >>> - reg: mmio address range of the chip, >>> - #thermal-sensor-cells: shall be 0, >>> - #io-channel-cells: shall be 0, >>> >>> -Example: >>> +Required properties for the following compatibles: >>> + - "allwinner,sun8i-h3-ths" >>> + - clocks: the bus clock and the input clock of the ADC, >>> + - clock-names: should be "bus" and "ths", >>> + - resets: the bus reset of the ADC, >>> + >>> +Example for A33: >>> ths: ths at 01c25000 { >>> compatible = "allwinner,sun8i-a33-ths"; >>> reg = <0x01c25000 0x100>; >>> @@ -17,6 +25,17 @@ Example: >>> #io-channel-cells = <0>; >>> }; >>> >>> +Example for H3: >>> + ths: ths at 01c25000 { >> >> >> adc at ... > > > It's a thermal sensor, so I think call it THS is more appropriate > here. It's implemented as an ADC driver just because the internal > code reusing of Linux. From device tree binding view I choose to > call it ths. There's numerous occurrences in this file and the filename that call it an ADC. Furthermore, node names are supposed to be generic, not part #'s or whatever you decide to make up. So pick from adc or temperature-sensor as those are the standard names . Rob