From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73892C4727C for ; Wed, 30 Sep 2020 15:08:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 332712076B for ; Wed, 30 Sep 2020 15:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601478493; bh=6QqV+ps2byZU4rC+O9EPuG5NtciAPCEeD4gdtKBD0V8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=ouaYJP59fLH5njRCGO5+wxr/cn72sNCLH+m2owQ2spcoqJjWm07RPUQ6kjKIbHwby eP0oRUzjofk3ENazGshE8IfqjA4WIjFDtRMWPTa4dBZEgoGe9I/RztwUXWnl/H4ZrG VQ5pOk1dYESuG6x11gd6SJZAMp7aluMkTGDqEeOI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729032AbgI3PIM (ORCPT ); Wed, 30 Sep 2020 11:08:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:33320 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbgI3PIL (ORCPT ); Wed, 30 Sep 2020 11:08:11 -0400 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 17EDB2076B; Wed, 30 Sep 2020 15:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601478491; bh=6QqV+ps2byZU4rC+O9EPuG5NtciAPCEeD4gdtKBD0V8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=A/ivvxVa7Lw2T1yu1urk7UClaBhy0Oxhld0Oi/R59aBUlQYOSgRnn3e5XkE6gGSKk rg2DyNJrcQeKFp9HT57WyYGU+Uz+BYjh0JVagdB2kBzeg0MiiUi0Q6mkixYcsdOAH9 6YHijAkeVYgXNQFyX75GqYhfsqet0wuli9JzkKIc= Received: by mail-ot1-f51.google.com with SMTP id n61so2121324ota.10; Wed, 30 Sep 2020 08:08:11 -0700 (PDT) X-Gm-Message-State: AOAM530AwIcolv0SkYZdw+3KUKAC0ufHiKUO5NkhkBWQbRZVDqalSmjg z1aUgZe+OSSkW6S0b50pRkcGc+XSKmwnttXknw== X-Google-Smtp-Source: ABdhPJxR8X69n4RLWzWvWtjlNHfj6t2hbM954Jp9nfbLK/knvYLAEl3iGmFm2iq7eVu7IxfjcLQLw9d0+fG5PpGV/sQ= X-Received: by 2002:a9d:6ada:: with SMTP id m26mr1897519otq.192.1601478490346; Wed, 30 Sep 2020 08:08:10 -0700 (PDT) MIME-Version: 1.0 References: <20200929131328.13779-1-Zhiqiang.Hou@nxp.com> <6e6d021b-bc46-63b4-7e84-6ca2c8e631f9@ti.com> In-Reply-To: <6e6d021b-bc46-63b4-7e84-6ca2c8e631f9@ti.com> From: Rob Herring Date: Wed, 30 Sep 2020 10:07:58 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] PCI: layerscape: Change back to the default error response behavior To: Kishon Vijay Abraham I Cc: Zhiqiang Hou , PCI , "linux-kernel@vger.kernel.org" , linux-arm-kernel , Lorenzo Pieralisi , Bjorn Helgaas , Minghuan Lian , Roy Zang , Mingkai Hu , Yang-Leo Li Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2020 at 8:29 AM Kishon Vijay Abraham I wrote: > > Hi Hou, > > On 29/09/20 6:43 pm, Zhiqiang Hou wrote: > > From: Hou Zhiqiang > > > > In the current error response behavior, it will send a SLVERR response > > to device's internal AXI slave system interface when the PCIe controller > > experiences an erroneous completion (UR, CA and CT) from an external > > completer for its outbound non-posted request, which will result in > > SError and crash the kernel directly. > > This patch change back it to the default behavior to increase the > > robustness of the kernel. In the default behavior, it always sends an > > OKAY response to the internal AXI slave interface when the controller > > gets these erroneous completions. And the AER driver will report and > > try to recover these errors. > > I don't think not forwarding any error interrupts is a good idea. Interrupts would be fine. Abort/SError is not. I think it is pretty clear what the correct behavior is for config accesses. > Maybe > you could disable it while reading configuration space registers > (vendorID and deviceID) and then enable error forwarding back? To add to the locking (or lack of) problems in config accesses? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45104C4727C for ; Wed, 30 Sep 2020 15:10:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAE35206FC for ; Wed, 30 Sep 2020 15:10:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0YHFWuU7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="A/ivvxVa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAE35206FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kGTNGQLH99SiW/pmYyj57OJe3z/ltMPW9ZrEwbKl+HE=; b=0YHFWuU7Q2WvRNkWKVacPm4M6 d7Mw+0CEyB63FFuG5tWpmsIOu7lOxpX5m6SXBNnuBIusU/Qp+r3zHjheikN9f4oTyJQ9L1hvCMuOZ oeSickJMg0PqELSjdAvRl4fNGNobK0r61m9AccXnYiqyBsXHYpITWEQs2dP7jLuUDQ5b81N/Dfcmv 0xrIdYFqyR50kxMmyz5LgBhodHFY/8f3JaM+U64tQUZD7de2wHUE4/ryLIx2lY6DL4LoNzdDImlbJ 5Tb5JAf5TOpFfUnT9shq+8aggCBFaNAEz8TZTkhNBv/3R4K+qBmiX9pIbz0VdGLPgeBsN0SOv4IV1 n91fM9OfQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNdiJ-0002xx-B9; Wed, 30 Sep 2020 15:08:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNdiH-0002xD-4Y for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 15:08:13 +0000 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1BD1A20789 for ; Wed, 30 Sep 2020 15:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601478491; bh=6QqV+ps2byZU4rC+O9EPuG5NtciAPCEeD4gdtKBD0V8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=A/ivvxVa7Lw2T1yu1urk7UClaBhy0Oxhld0Oi/R59aBUlQYOSgRnn3e5XkE6gGSKk rg2DyNJrcQeKFp9HT57WyYGU+Uz+BYjh0JVagdB2kBzeg0MiiUi0Q6mkixYcsdOAH9 6YHijAkeVYgXNQFyX75GqYhfsqet0wuli9JzkKIc= Received: by mail-ot1-f47.google.com with SMTP id m12so2167758otr.0 for ; Wed, 30 Sep 2020 08:08:11 -0700 (PDT) X-Gm-Message-State: AOAM530GxjwbRq3nEE1Y6k2oSO0liiAOPASxNiH1Zak/j23Nxg6JG+GH vQtLUiI9pbm3etyDMx8v3fNoByAp27pEVXr3KQ== X-Google-Smtp-Source: ABdhPJxR8X69n4RLWzWvWtjlNHfj6t2hbM954Jp9nfbLK/knvYLAEl3iGmFm2iq7eVu7IxfjcLQLw9d0+fG5PpGV/sQ= X-Received: by 2002:a9d:6ada:: with SMTP id m26mr1897519otq.192.1601478490346; Wed, 30 Sep 2020 08:08:10 -0700 (PDT) MIME-Version: 1.0 References: <20200929131328.13779-1-Zhiqiang.Hou@nxp.com> <6e6d021b-bc46-63b4-7e84-6ca2c8e631f9@ti.com> In-Reply-To: <6e6d021b-bc46-63b4-7e84-6ca2c8e631f9@ti.com> From: Rob Herring Date: Wed, 30 Sep 2020 10:07:58 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] PCI: layerscape: Change back to the default error response behavior To: Kishon Vijay Abraham I X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_110813_243685_95B96C31 X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roy Zang , Lorenzo Pieralisi , PCI , Zhiqiang Hou , "linux-kernel@vger.kernel.org" , Yang-Leo Li , Minghuan Lian , Mingkai Hu , Bjorn Helgaas , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 30, 2020 at 8:29 AM Kishon Vijay Abraham I wrote: > > Hi Hou, > > On 29/09/20 6:43 pm, Zhiqiang Hou wrote: > > From: Hou Zhiqiang > > > > In the current error response behavior, it will send a SLVERR response > > to device's internal AXI slave system interface when the PCIe controller > > experiences an erroneous completion (UR, CA and CT) from an external > > completer for its outbound non-posted request, which will result in > > SError and crash the kernel directly. > > This patch change back it to the default behavior to increase the > > robustness of the kernel. In the default behavior, it always sends an > > OKAY response to the internal AXI slave interface when the controller > > gets these erroneous completions. And the AER driver will report and > > try to recover these errors. > > I don't think not forwarding any error interrupts is a good idea. Interrupts would be fine. Abort/SError is not. I think it is pretty clear what the correct behavior is for config accesses. > Maybe > you could disable it while reading configuration space registers > (vendorID and deviceID) and then enable error forwarding back? To add to the locking (or lack of) problems in config accesses? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel