From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <20190221084729.101784-1-pihsun@chromium.org> <20190221084729.101784-2-pihsun@chromium.org> <20190222144316.GA19284@bogus> In-Reply-To: From: Rob Herring Date: Mon, 4 Mar 2019 11:51:55 -0600 Message-ID: Subject: Re: [PATCH v5 1/6] dt-bindings: Add a binding for Mediatek SCP Content-Type: text/plain; charset="UTF-8" To: Pi-Hsun Shih Cc: Erin Lo , Ohad Ben-Cohen , Bjorn Andersson , Mark Rutland , Matthias Brugger , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , open list List-ID: On Mon, Feb 25, 2019 at 12:15 AM Pi-Hsun Shih wrote: > > On Fri, Feb 22, 2019 at 10:43 PM Rob Herring wrote: > > > > On Thu, Feb 21, 2019 at 04:47:24PM +0800, Pi-Hsun Shih wrote: > > > From: Erin Lo > > > > > > Add a DT binding documentation of SCP for the > > > MT8183 SoC from Mediatek. > > > > > > Signed-off-by: Erin Lo > > > --- > > > Changes from v4: > > > - Add detail of more properties. > > > - Document the usage of mtk,rpmsg-name in subnode from the new design. > > > > > > Changes from v3: > > > - No change. > > > > > > Changes from v2: > > > - No change. I realized that for this patch series, there's no need to > > > add anything under the mt8183-scp node (neither the mt8183-rpmsg or > > > the cros-ec-rpmsg) for them to work, since mt8183-rpmsg is added > > > directly as a rproc_subdev by code, and cros-ec-rpmsg is dynamically > > > created by SCP name service. > > > > > > Changes from v1: > > > - No change. > > > --- > > > .../bindings/remoteproc/mtk,scp.txt | 37 +++++++++++++++++++ > > > 1 file changed, 37 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,scp.txt > > > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt b/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt > > > new file mode 100644 > > > index 00000000000000..8cf8b0e0d98a4c > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt > > > @@ -0,0 +1,37 @@ > > > +Mediatek SCP Bindings > > > +---------------------------------------- > > > + > > > +This binding provides support for ARM Cortex M4 Co-processor found on some > > > +Mediatek SoCs. > > > + > > > +Required properties: > > > +- compatible Should be "mediatek,mt8183-scp" > > > +- reg Should contain the address ranges for the two memory > > > + regions, SRAM and CFG. > > > +- reg-names Contains the corresponding names for the two memory > > > + regions. These should be named "sram" & "cfg". > > > +- clocks Clock for co-processor (See: ../clock/clock-bindings.txt) > > > +- clock-names Contains the corresponding name for the clock. This > > > + should be named "main". > > > + > > > +Subnodes > > > +-------- > > > + > > > +When CONFIG_RPMSG_MTK_SCP is enabled, subnodes of the SCP represent rpmsg > > > > Bindings can't depend on kernel config options. > > > > What's the recommendation here if the subnode only has effect when the > config is enabled? Should I just skip the sentence "When ... is > enabled"? Sure. > > > > +devices. The names of the devices are not important. The properties of these > > > +nodes are defined by the individual bindings for the rpmsg devices - but must > > > +contain the following property: > > > + > > > +- mtk,rpmsg-name Contains the name for the rpmsg device. Used to match > > > + the subnode to rpmsg device announced by SCP. > > > > I don't think this belongs in DT, but without some examples I'm not > > really sure. > > > > This is similar to the qcom,smd-channels property in > Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt, a example DT > for this: QCom has lots of strange buses and communication channels. Probably not the best place for inspiration. > scp { > compatible = "mediatek,mt8183-scp"; > ... > cros_ec { > compatible = "google,cros-ec-rpmsg"; > mtk,rpmsg-name = "cros-ec-rpmsg"; Why do we need the same string twice? It's just the compatible string minus the vendor prefix. > > cros_ec_codec { > compatible = "google,cros-ec-codec"; > ... What's this? I can't review bindings piece by piece. > }; > }; > }; > > > > + > > > +Example: > > > + > > > + scp: scp@10500000 { > > > + compatible = "mediatek,mt8183-scp"; > > > + reg = <0 0x10500000 0 0x80000>, > > > + <0 0x105c0000 0 0x5000>; > > > + reg-names = "sram", "cfg"; > > > + clocks = <&infracfg CLK_INFRA_SCPSYS>; > > > + clock-names = "main"; > > > + }; > > > -- > > > 2.21.0.rc0.258.g878e2cd30e-goog > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80027C43381 for ; Mon, 4 Mar 2019 17:52:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B55B206DD for ; Mon, 4 Mar 2019 17:52:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551721930; bh=XN98+D5gbw1pc30bDaFbg45JEEaPqeNXKhfBuMF63Zg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=ANFknR6AlbxmYF1jgmLbg/F4KJ0aXsEjC32mdYu28g2PbGrYrRuWKDAV1sZa18ji+ XyRXM417HGHYb/hQhDusDi207PSAY8SOk68Ewl3vr5CfLVmXIXUtXNodCVg4Gs26GQ 9JfNbIEKV3sL5hiWUm4DriZgw4FCItEge2nsZKDs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727505AbfCDRwJ (ORCPT ); Mon, 4 Mar 2019 12:52:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:51508 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726181AbfCDRwI (ORCPT ); Mon, 4 Mar 2019 12:52:08 -0500 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2198B2146E; Mon, 4 Mar 2019 17:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551721927; bh=XN98+D5gbw1pc30bDaFbg45JEEaPqeNXKhfBuMF63Zg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=SmTfKeT2l2FNJbzv18gg4wy7J0RpsC9WES4Z3gLF2p86cx4GhRfiT5L+YYIdiTdiM CmxSMgAQSgrgT6y0Zkuuh6cUiLmUOa7qWNiXbu01aTb1palNJvnsMOlSk+pZGtwU3A USXlHvrMfmk5WJFunEfVCQNLfp1J8CjQXo18uYHQ= Received: by mail-qt1-f178.google.com with SMTP id y4so6055566qtc.10; Mon, 04 Mar 2019 09:52:07 -0800 (PST) X-Gm-Message-State: APjAAAUevnpOLbo8jfXjZDPBmY2jfv4xHs+zmMsdW1vOlL5nJmSqqQVo cUHE2z7pRLid9kHOUMMUzWWMqLosMfu7IqjY+g== X-Google-Smtp-Source: APXvYqzkpBfsfpjMj6yuvUtfeTDH9r0unzVPvf8mimwSTIYtBGwaXXtx6UGIICLfiHuD1BnGGoS7qddEhTP8hgrMERI= X-Received: by 2002:ac8:25d1:: with SMTP id f17mr14929040qtf.38.1551721926271; Mon, 04 Mar 2019 09:52:06 -0800 (PST) MIME-Version: 1.0 References: <20190221084729.101784-1-pihsun@chromium.org> <20190221084729.101784-2-pihsun@chromium.org> <20190222144316.GA19284@bogus> In-Reply-To: From: Rob Herring Date: Mon, 4 Mar 2019 11:51:55 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 1/6] dt-bindings: Add a binding for Mediatek SCP To: Pi-Hsun Shih Cc: Erin Lo , Ohad Ben-Cohen , Bjorn Andersson , Mark Rutland , Matthias Brugger , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 25, 2019 at 12:15 AM Pi-Hsun Shih wrote: > > On Fri, Feb 22, 2019 at 10:43 PM Rob Herring wrote: > > > > On Thu, Feb 21, 2019 at 04:47:24PM +0800, Pi-Hsun Shih wrote: > > > From: Erin Lo > > > > > > Add a DT binding documentation of SCP for the > > > MT8183 SoC from Mediatek. > > > > > > Signed-off-by: Erin Lo > > > --- > > > Changes from v4: > > > - Add detail of more properties. > > > - Document the usage of mtk,rpmsg-name in subnode from the new design. > > > > > > Changes from v3: > > > - No change. > > > > > > Changes from v2: > > > - No change. I realized that for this patch series, there's no need to > > > add anything under the mt8183-scp node (neither the mt8183-rpmsg or > > > the cros-ec-rpmsg) for them to work, since mt8183-rpmsg is added > > > directly as a rproc_subdev by code, and cros-ec-rpmsg is dynamically > > > created by SCP name service. > > > > > > Changes from v1: > > > - No change. > > > --- > > > .../bindings/remoteproc/mtk,scp.txt | 37 +++++++++++++++++++ > > > 1 file changed, 37 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,scp.txt > > > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt b/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt > > > new file mode 100644 > > > index 00000000000000..8cf8b0e0d98a4c > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt > > > @@ -0,0 +1,37 @@ > > > +Mediatek SCP Bindings > > > +---------------------------------------- > > > + > > > +This binding provides support for ARM Cortex M4 Co-processor found on some > > > +Mediatek SoCs. > > > + > > > +Required properties: > > > +- compatible Should be "mediatek,mt8183-scp" > > > +- reg Should contain the address ranges for the two memory > > > + regions, SRAM and CFG. > > > +- reg-names Contains the corresponding names for the two memory > > > + regions. These should be named "sram" & "cfg". > > > +- clocks Clock for co-processor (See: ../clock/clock-bindings.txt) > > > +- clock-names Contains the corresponding name for the clock. This > > > + should be named "main". > > > + > > > +Subnodes > > > +-------- > > > + > > > +When CONFIG_RPMSG_MTK_SCP is enabled, subnodes of the SCP represent rpmsg > > > > Bindings can't depend on kernel config options. > > > > What's the recommendation here if the subnode only has effect when the > config is enabled? Should I just skip the sentence "When ... is > enabled"? Sure. > > > > +devices. The names of the devices are not important. The properties of these > > > +nodes are defined by the individual bindings for the rpmsg devices - but must > > > +contain the following property: > > > + > > > +- mtk,rpmsg-name Contains the name for the rpmsg device. Used to match > > > + the subnode to rpmsg device announced by SCP. > > > > I don't think this belongs in DT, but without some examples I'm not > > really sure. > > > > This is similar to the qcom,smd-channels property in > Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt, a example DT > for this: QCom has lots of strange buses and communication channels. Probably not the best place for inspiration. > scp { > compatible = "mediatek,mt8183-scp"; > ... > cros_ec { > compatible = "google,cros-ec-rpmsg"; > mtk,rpmsg-name = "cros-ec-rpmsg"; Why do we need the same string twice? It's just the compatible string minus the vendor prefix. > > cros_ec_codec { > compatible = "google,cros-ec-codec"; > ... What's this? I can't review bindings piece by piece. > }; > }; > }; > > > > + > > > +Example: > > > + > > > + scp: scp@10500000 { > > > + compatible = "mediatek,mt8183-scp"; > > > + reg = <0 0x10500000 0 0x80000>, > > > + <0 0x105c0000 0 0x5000>; > > > + reg-names = "sram", "cfg"; > > > + clocks = <&infracfg CLK_INFRA_SCPSYS>; > > > + clock-names = "main"; > > > + }; > > > -- > > > 2.21.0.rc0.258.g878e2cd30e-goog > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FD97C43381 for ; Mon, 4 Mar 2019 17:52:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 419D4206DD for ; Mon, 4 Mar 2019 17:52:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jkzaaZjs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="SmTfKeT2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 419D4206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0m9rM84Yhq1E3xw7LO9RBh5gsS4G4K/8HDtfKzUJEiE=; b=jkzaaZjsO/I9up zGp6pEwxtyinVcUJvHnrXz37pmoOQQoTAxxn8VbldfUpHrx0TM/IwzZz1g9mvy0mt5bosW8rwLYMI 4IrtYzeeOHeMU/+CpSpk4/5lKFYud2Y0c1KaBRWvGa+OnFtPGMK6BIGcfFSXEPkhpLGa0UquDIXVH yRQg5cOXYp8ZuyjpX/i3ldTvrJMfOPn8e9+lhC1Nt6M3YqU/mlVlpzuZVpLW4Nk15c4/d5pLgv+Ff t7A9b95IWOL8ps5Ki2tssKze06vXfiKso7SDpCU6RX7ZJ0EGGU4Qvbe9LA4tdSskFoGG/KhaN351x r2Jr2zQD4HtQc/fdlYTg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0rl4-00084e-VC; Mon, 04 Mar 2019 17:52:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0rl1-000845-II; Mon, 04 Mar 2019 17:52:09 +0000 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1A4EA208E4; Mon, 4 Mar 2019 17:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551721927; bh=XN98+D5gbw1pc30bDaFbg45JEEaPqeNXKhfBuMF63Zg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=SmTfKeT2l2FNJbzv18gg4wy7J0RpsC9WES4Z3gLF2p86cx4GhRfiT5L+YYIdiTdiM CmxSMgAQSgrgT6y0Zkuuh6cUiLmUOa7qWNiXbu01aTb1palNJvnsMOlSk+pZGtwU3A USXlHvrMfmk5WJFunEfVCQNLfp1J8CjQXo18uYHQ= Received: by mail-qt1-f177.google.com with SMTP id d18so6044043qtg.12; Mon, 04 Mar 2019 09:52:07 -0800 (PST) X-Gm-Message-State: APjAAAWnz4irD2PXUMItzh9kTyOUIujAxWoj4DgIdXmWnBHO2o3BWCND jsQ+A0+lRLaJx9UR1fvghsXciBYuwuxvQpOLNw== X-Google-Smtp-Source: APXvYqzkpBfsfpjMj6yuvUtfeTDH9r0unzVPvf8mimwSTIYtBGwaXXtx6UGIICLfiHuD1BnGGoS7qddEhTP8hgrMERI= X-Received: by 2002:ac8:25d1:: with SMTP id f17mr14929040qtf.38.1551721926271; Mon, 04 Mar 2019 09:52:06 -0800 (PST) MIME-Version: 1.0 References: <20190221084729.101784-1-pihsun@chromium.org> <20190221084729.101784-2-pihsun@chromium.org> <20190222144316.GA19284@bogus> In-Reply-To: From: Rob Herring Date: Mon, 4 Mar 2019 11:51:55 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 1/6] dt-bindings: Add a binding for Mediatek SCP To: Pi-Hsun Shih X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_095207_640651_F5834A90 X-CRM114-Status: GOOD ( 30.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ohad Ben-Cohen , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Erin Lo , "open list:REMOTE PROCESSOR \(REMOTEPROC\) SUBSYSTEM" , open list , Bjorn Andersson , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 25, 2019 at 12:15 AM Pi-Hsun Shih wrote: > > On Fri, Feb 22, 2019 at 10:43 PM Rob Herring wrote: > > > > On Thu, Feb 21, 2019 at 04:47:24PM +0800, Pi-Hsun Shih wrote: > > > From: Erin Lo > > > > > > Add a DT binding documentation of SCP for the > > > MT8183 SoC from Mediatek. > > > > > > Signed-off-by: Erin Lo > > > --- > > > Changes from v4: > > > - Add detail of more properties. > > > - Document the usage of mtk,rpmsg-name in subnode from the new design. > > > > > > Changes from v3: > > > - No change. > > > > > > Changes from v2: > > > - No change. I realized that for this patch series, there's no need to > > > add anything under the mt8183-scp node (neither the mt8183-rpmsg or > > > the cros-ec-rpmsg) for them to work, since mt8183-rpmsg is added > > > directly as a rproc_subdev by code, and cros-ec-rpmsg is dynamically > > > created by SCP name service. > > > > > > Changes from v1: > > > - No change. > > > --- > > > .../bindings/remoteproc/mtk,scp.txt | 37 +++++++++++++++++++ > > > 1 file changed, 37 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,scp.txt > > > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt b/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt > > > new file mode 100644 > > > index 00000000000000..8cf8b0e0d98a4c > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt > > > @@ -0,0 +1,37 @@ > > > +Mediatek SCP Bindings > > > +---------------------------------------- > > > + > > > +This binding provides support for ARM Cortex M4 Co-processor found on some > > > +Mediatek SoCs. > > > + > > > +Required properties: > > > +- compatible Should be "mediatek,mt8183-scp" > > > +- reg Should contain the address ranges for the two memory > > > + regions, SRAM and CFG. > > > +- reg-names Contains the corresponding names for the two memory > > > + regions. These should be named "sram" & "cfg". > > > +- clocks Clock for co-processor (See: ../clock/clock-bindings.txt) > > > +- clock-names Contains the corresponding name for the clock. This > > > + should be named "main". > > > + > > > +Subnodes > > > +-------- > > > + > > > +When CONFIG_RPMSG_MTK_SCP is enabled, subnodes of the SCP represent rpmsg > > > > Bindings can't depend on kernel config options. > > > > What's the recommendation here if the subnode only has effect when the > config is enabled? Should I just skip the sentence "When ... is > enabled"? Sure. > > > > +devices. The names of the devices are not important. The properties of these > > > +nodes are defined by the individual bindings for the rpmsg devices - but must > > > +contain the following property: > > > + > > > +- mtk,rpmsg-name Contains the name for the rpmsg device. Used to match > > > + the subnode to rpmsg device announced by SCP. > > > > I don't think this belongs in DT, but without some examples I'm not > > really sure. > > > > This is similar to the qcom,smd-channels property in > Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt, a example DT > for this: QCom has lots of strange buses and communication channels. Probably not the best place for inspiration. > scp { > compatible = "mediatek,mt8183-scp"; > ... > cros_ec { > compatible = "google,cros-ec-rpmsg"; > mtk,rpmsg-name = "cros-ec-rpmsg"; Why do we need the same string twice? It's just the compatible string minus the vendor prefix. > > cros_ec_codec { > compatible = "google,cros-ec-codec"; > ... What's this? I can't review bindings piece by piece. > }; > }; > }; > > > > + > > > +Example: > > > + > > > + scp: scp@10500000 { > > > + compatible = "mediatek,mt8183-scp"; > > > + reg = <0 0x10500000 0 0x80000>, > > > + <0 0x105c0000 0 0x5000>; > > > + reg-names = "sram", "cfg"; > > > + clocks = <&infracfg CLK_INFRA_SCPSYS>; > > > + clock-names = "main"; > > > + }; > > > -- > > > 2.21.0.rc0.258.g878e2cd30e-goog > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel