From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 11/19] PCI: Move setting pci_host_bridge.busnr out of host drivers Date: Thu, 23 Jul 2020 09:26:01 -0600 Message-ID: References: <20200722022514.1283916-1-robh@kernel.org> <20200722022514.1283916-12-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20200722022514.1283916-12-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bjorn Helgaas , Lorenzo Pieralisi Cc: Fabio Estevam , Gustavo Pimentel , Heiko Stuebner , Hou Zhiqiang , Jingoo Han , Jonathan Hunter , Karthikeyan Mitran , Linus Walleij , Lucas Stach , Marek Vasut , Michal Simek , Murali Karicheri , NXP Linux Team , Pengutronix Kernel Team , Richard Zhu , Ryder Lee , Sascha Hauer , Shawn Guo , Shawn Lin List-Id: linux-tegra@vger.kernel.org On Tue, Jul 21, 2020 at 8:25 PM Rob Herring wrote: > > Most host drivers only parse the DT bus range to set the root bus number > in pci_host_bridge.busnr. The ones that don't set busnr are buggy in > that they ignore what's in DT. Let's set busnr in pci_scan_root_bus_bridge() > where we already check for the bus resource and remove setting it in > host drivers. > > Cc: Jingoo Han > Cc: Gustavo Pimentel > Cc: Lorenzo Pieralisi > Cc: Bjorn Helgaas > Cc: Thomas Petazzoni > Cc: Will Deacon > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: Linus Walleij > Cc: Ryder Lee > Cc: Marek Vasut > Cc: Yoshihiro Shimoda > Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Signed-off-by: Rob Herring > --- > drivers/pci/controller/dwc/pcie-designware-host.c | 4 ---- > drivers/pci/controller/dwc/pcie-designware.h | 1 - > drivers/pci/controller/pci-aardvark.c | 5 ++--- > drivers/pci/controller/pci-host-common.c | 1 - > drivers/pci/controller/pci-tegra.c | 4 +--- > drivers/pci/controller/pci-v3-semi.c | 2 -- > drivers/pci/controller/pcie-mediatek.c | 8 +------- > drivers/pci/controller/pcie-rcar-host.c | 1 - > drivers/pci/probe.c | 1 + > 9 files changed, 5 insertions(+), 22 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > index 9e8a9cfc6d3a..fa922cb876a3 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -374,9 +374,6 @@ int dw_pcie_host_init(struct pcie_port *pp) > pp->cfg0_base = pp->cfg->start; > pp->cfg1_base = pp->cfg->start + pp->cfg0_size; > break; > - case IORESOURCE_BUS: > - pp->busn = win->res; > - break; > } > } > > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h > index fd2146298b58..9fb44290ed43 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.h > +++ b/drivers/pci/controller/dwc/pcie-designware.h > @@ -188,7 +188,6 @@ struct pcie_port { > struct resource *cfg; > struct resource *io; > struct resource *mem; > - struct resource *busn; > int irq; > const struct dw_pcie_host_ops *ops; > int msi_irq; These 2 hunks should be dropped as they are breaking the Amazon driver. Lorenzo, do you want to fixup or I can send a fix? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA4C1C433E1 for ; Thu, 23 Jul 2020 15:26:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C680C22B40 for ; Thu, 23 Jul 2020 15:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595517974; bh=LVhZXIdkdKrrk3YqkOpZYcc+YEG1SCDuwu0ZS4IUGgM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=BFutqueGqFQ5R0N/FndNUeOkZ7R5hRXTxT+zENNmJSwJaVxm/UGRH2vxrzWdEzDw0 kLe8fFDdAjejk1FKoVm9HE7OuZLYTtSZjXgUShYA1XZeQb2Dv0dVAWnyuqOs9JTkPH Mi9i0y3pckqn51x/7klZyOF7DItT60l3l1JxC2FI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729471AbgGWP0O (ORCPT ); Thu, 23 Jul 2020 11:26:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:53514 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727996AbgGWP0O (ORCPT ); Thu, 23 Jul 2020 11:26:14 -0400 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4E3E822B43; Thu, 23 Jul 2020 15:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595517973; bh=LVhZXIdkdKrrk3YqkOpZYcc+YEG1SCDuwu0ZS4IUGgM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=e0Q5iPvq0aYhQMQ93Nj0StQPvdQC04wLHBe3X1Txb93hQiAyN2gBdhUJnWxSD1Aiy 2KX/vVFZ/CirNgDYbBgwCQVGolScvRDxEh90ajbGlE82PTVGupyi1qunooX9upUKwZ aUXzgixohBJRhgWVYRFrPtwnbl7QTcgOltbXgQL0= Received: by mail-ot1-f49.google.com with SMTP id t18so4625914otq.5; Thu, 23 Jul 2020 08:26:13 -0700 (PDT) X-Gm-Message-State: AOAM5328sEOhl4Nj03f76bVII3MUeDy91vbUj8Se1dlWZjJMjCfz8/os 4aHKBKAEnhuCKQ6zFRNsdTSzkmDQ+XfITzTgOA== X-Google-Smtp-Source: ABdhPJwjqGRmo1UpccJeOoC1JymzSWvGPVrWo+4vb2FMRak7++d6g0GGlvyUxomInzkLdL3VTPFVVOlmvL7TW+o7adM= X-Received: by 2002:a9d:2646:: with SMTP id a64mr4390973otb.107.1595517972599; Thu, 23 Jul 2020 08:26:12 -0700 (PDT) MIME-Version: 1.0 References: <20200722022514.1283916-1-robh@kernel.org> <20200722022514.1283916-12-robh@kernel.org> In-Reply-To: <20200722022514.1283916-12-robh@kernel.org> From: Rob Herring Date: Thu, 23 Jul 2020 09:26:01 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/19] PCI: Move setting pci_host_bridge.busnr out of host drivers To: Bjorn Helgaas , Lorenzo Pieralisi Cc: Fabio Estevam , Gustavo Pimentel , Heiko Stuebner , Hou Zhiqiang , Jingoo Han , Jonathan Hunter , Karthikeyan Mitran , Linus Walleij , Lucas Stach , Marek Vasut , Michal Simek , Murali Karicheri , NXP Linux Team , Pengutronix Kernel Team , Richard Zhu , Ryder Lee , Sascha Hauer , Shawn Guo , Shawn Lin , Thierry Reding , Thomas Petazzoni , Tom Joseph , Will Deacon , Yoshihiro Shimoda , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , PCI , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , "open list:ARM/Rockchip SoC..." , linux-tegra Content-Type: text/plain; charset="UTF-8" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Tue, Jul 21, 2020 at 8:25 PM Rob Herring wrote: > > Most host drivers only parse the DT bus range to set the root bus number > in pci_host_bridge.busnr. The ones that don't set busnr are buggy in > that they ignore what's in DT. Let's set busnr in pci_scan_root_bus_bridge() > where we already check for the bus resource and remove setting it in > host drivers. > > Cc: Jingoo Han > Cc: Gustavo Pimentel > Cc: Lorenzo Pieralisi > Cc: Bjorn Helgaas > Cc: Thomas Petazzoni > Cc: Will Deacon > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: Linus Walleij > Cc: Ryder Lee > Cc: Marek Vasut > Cc: Yoshihiro Shimoda > Cc: linux-tegra@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-renesas-soc@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/pci/controller/dwc/pcie-designware-host.c | 4 ---- > drivers/pci/controller/dwc/pcie-designware.h | 1 - > drivers/pci/controller/pci-aardvark.c | 5 ++--- > drivers/pci/controller/pci-host-common.c | 1 - > drivers/pci/controller/pci-tegra.c | 4 +--- > drivers/pci/controller/pci-v3-semi.c | 2 -- > drivers/pci/controller/pcie-mediatek.c | 8 +------- > drivers/pci/controller/pcie-rcar-host.c | 1 - > drivers/pci/probe.c | 1 + > 9 files changed, 5 insertions(+), 22 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > index 9e8a9cfc6d3a..fa922cb876a3 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -374,9 +374,6 @@ int dw_pcie_host_init(struct pcie_port *pp) > pp->cfg0_base = pp->cfg->start; > pp->cfg1_base = pp->cfg->start + pp->cfg0_size; > break; > - case IORESOURCE_BUS: > - pp->busn = win->res; > - break; > } > } > > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h > index fd2146298b58..9fb44290ed43 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.h > +++ b/drivers/pci/controller/dwc/pcie-designware.h > @@ -188,7 +188,6 @@ struct pcie_port { > struct resource *cfg; > struct resource *io; > struct resource *mem; > - struct resource *busn; > int irq; > const struct dw_pcie_host_ops *ops; > int msi_irq; These 2 hunks should be dropped as they are breaking the Amazon driver. Lorenzo, do you want to fixup or I can send a fix? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3938AC433E5 for ; Thu, 23 Jul 2020 15:26:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05F22206D8 for ; Thu, 23 Jul 2020 15:26:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VLQi0OmY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="e0Q5iPvq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05F22206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VlnGQViLwEVLGO2ldQv4GJ1lA56Zl+c8449RVcmhnyE=; b=VLQi0OmYueAU0oK2bRdkXoBEn MTNk7MfNmlH2MuRF2KgW65Bmeg9VKKvPWgrDtcBLHj+sOBMbbgEWTZRHOzfOf8R47T+7JFuc+/v4R 7ILPORWQCUJCY3G34D9TO6usVwsnjagd2sfa1b+mq2h1wgNmd3SCyYLzc8cWW81JRYuDV4HkVXl3P tGqARBqsxrlEyetoqMVJ6/44kXWb0dlD0aCyWVXCtj3FR9zL2CFQVOS0/L6esxXEGKOj7uo7+/DMw uZaTlm7FTkGtzWi5Tti1jioJh6CtZUIIiTJjpO3Nil8vCm6MNZqJv1JM7wvPSeoZ31JSGYzrfYn6r NqvLy2I8g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyd72-0007EJ-5U; Thu, 23 Jul 2020 15:26:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyd6u-00079D-4N; Thu, 23 Jul 2020 15:26:17 +0000 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A2A022CBB; Thu, 23 Jul 2020 15:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595517973; bh=LVhZXIdkdKrrk3YqkOpZYcc+YEG1SCDuwu0ZS4IUGgM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=e0Q5iPvq0aYhQMQ93Nj0StQPvdQC04wLHBe3X1Txb93hQiAyN2gBdhUJnWxSD1Aiy 2KX/vVFZ/CirNgDYbBgwCQVGolScvRDxEh90ajbGlE82PTVGupyi1qunooX9upUKwZ aUXzgixohBJRhgWVYRFrPtwnbl7QTcgOltbXgQL0= Received: by mail-ot1-f41.google.com with SMTP id g37so4605993otb.9; Thu, 23 Jul 2020 08:26:13 -0700 (PDT) X-Gm-Message-State: AOAM533SXoUZwotBNpUgPoTGxzwZpMm9ywHEYu2TsmQR1a+UasHxYPMz QdXGzuVHLbHdmxMxPjIFyeIiYJN9JorVWImtbg== X-Google-Smtp-Source: ABdhPJwjqGRmo1UpccJeOoC1JymzSWvGPVrWo+4vb2FMRak7++d6g0GGlvyUxomInzkLdL3VTPFVVOlmvL7TW+o7adM= X-Received: by 2002:a9d:2646:: with SMTP id a64mr4390973otb.107.1595517972599; Thu, 23 Jul 2020 08:26:12 -0700 (PDT) MIME-Version: 1.0 References: <20200722022514.1283916-1-robh@kernel.org> <20200722022514.1283916-12-robh@kernel.org> In-Reply-To: <20200722022514.1283916-12-robh@kernel.org> From: Rob Herring Date: Thu, 23 Jul 2020 09:26:01 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/19] PCI: Move setting pci_host_bridge.busnr out of host drivers To: Bjorn Helgaas , Lorenzo Pieralisi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_112616_309299_546FB414 X-CRM114-Status: GOOD ( 19.26 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Karthikeyan Mitran , PCI , Shawn Lin , Thierry Reding , Thomas Petazzoni , Fabio Estevam , Marek Vasut , Linus Walleij , Ryder Lee , Will Deacon , Michal Simek , Jonathan Hunter , "open list:ARM/Rockchip SoC..." , Murali Karicheri , NXP Linux Team , Hou Zhiqiang , Richard Zhu , Sascha Hauer , "moderated list:ARM/Mediatek SoC support" , linux-tegra , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Gustavo Pimentel , Yoshihiro Shimoda , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Tom Joseph , Pengutronix Kernel Team , Jingoo Han , Shawn Guo , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Jul 21, 2020 at 8:25 PM Rob Herring wrote: > > Most host drivers only parse the DT bus range to set the root bus number > in pci_host_bridge.busnr. The ones that don't set busnr are buggy in > that they ignore what's in DT. Let's set busnr in pci_scan_root_bus_bridge() > where we already check for the bus resource and remove setting it in > host drivers. > > Cc: Jingoo Han > Cc: Gustavo Pimentel > Cc: Lorenzo Pieralisi > Cc: Bjorn Helgaas > Cc: Thomas Petazzoni > Cc: Will Deacon > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: Linus Walleij > Cc: Ryder Lee > Cc: Marek Vasut > Cc: Yoshihiro Shimoda > Cc: linux-tegra@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-renesas-soc@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/pci/controller/dwc/pcie-designware-host.c | 4 ---- > drivers/pci/controller/dwc/pcie-designware.h | 1 - > drivers/pci/controller/pci-aardvark.c | 5 ++--- > drivers/pci/controller/pci-host-common.c | 1 - > drivers/pci/controller/pci-tegra.c | 4 +--- > drivers/pci/controller/pci-v3-semi.c | 2 -- > drivers/pci/controller/pcie-mediatek.c | 8 +------- > drivers/pci/controller/pcie-rcar-host.c | 1 - > drivers/pci/probe.c | 1 + > 9 files changed, 5 insertions(+), 22 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > index 9e8a9cfc6d3a..fa922cb876a3 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -374,9 +374,6 @@ int dw_pcie_host_init(struct pcie_port *pp) > pp->cfg0_base = pp->cfg->start; > pp->cfg1_base = pp->cfg->start + pp->cfg0_size; > break; > - case IORESOURCE_BUS: > - pp->busn = win->res; > - break; > } > } > > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h > index fd2146298b58..9fb44290ed43 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.h > +++ b/drivers/pci/controller/dwc/pcie-designware.h > @@ -188,7 +188,6 @@ struct pcie_port { > struct resource *cfg; > struct resource *io; > struct resource *mem; > - struct resource *busn; > int irq; > const struct dw_pcie_host_ops *ops; > int msi_irq; These 2 hunks should be dropped as they are breaking the Amazon driver. Lorenzo, do you want to fixup or I can send a fix? Rob _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8A51C433EB for ; Thu, 23 Jul 2020 15:28:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88EF82067D for ; Thu, 23 Jul 2020 15:28:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N3l6C3Un"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="e0Q5iPvq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88EF82067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S23SH0lXLQd9rt04lLTiKcluVxe3fMQ5v46b0sIA7as=; b=N3l6C3UnCMMTTv/w9Cgl1j4wS i/ueSxN3Znldz55ckRC5LWLqlx+gxLNTrUYtqVqOJaWm9nuA6wtbLG6HXEZZCLVKLtUnfjwsWxONh oXb6D5YuoXRbl57YoMy/dHc3JlUUhR4/REAT/sR5Ckd3rw3gW2mYMP+gXUltUDMILjuOdcgbBEgXZ /abIPKdd3OMwfz+oDWrkjZUzzxAXdI8vOdPvbM2rQYe3J0LGwNZOm8+iR9LMj32s5QtHUKlVyIiYZ 27PLyGCjv7i4AD8Avk8CHDIRoOjn+ja2zty8l8bDxBQMVdUMUztpb2msIStkEN8mi/dklP3+5pXoq Vj3O2jKTA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyd6x-0007Cf-20; Thu, 23 Jul 2020 15:26:19 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyd6u-00079D-4N; Thu, 23 Jul 2020 15:26:17 +0000 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A2A022CBB; Thu, 23 Jul 2020 15:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595517973; bh=LVhZXIdkdKrrk3YqkOpZYcc+YEG1SCDuwu0ZS4IUGgM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=e0Q5iPvq0aYhQMQ93Nj0StQPvdQC04wLHBe3X1Txb93hQiAyN2gBdhUJnWxSD1Aiy 2KX/vVFZ/CirNgDYbBgwCQVGolScvRDxEh90ajbGlE82PTVGupyi1qunooX9upUKwZ aUXzgixohBJRhgWVYRFrPtwnbl7QTcgOltbXgQL0= Received: by mail-ot1-f41.google.com with SMTP id g37so4605993otb.9; Thu, 23 Jul 2020 08:26:13 -0700 (PDT) X-Gm-Message-State: AOAM533SXoUZwotBNpUgPoTGxzwZpMm9ywHEYu2TsmQR1a+UasHxYPMz QdXGzuVHLbHdmxMxPjIFyeIiYJN9JorVWImtbg== X-Google-Smtp-Source: ABdhPJwjqGRmo1UpccJeOoC1JymzSWvGPVrWo+4vb2FMRak7++d6g0GGlvyUxomInzkLdL3VTPFVVOlmvL7TW+o7adM= X-Received: by 2002:a9d:2646:: with SMTP id a64mr4390973otb.107.1595517972599; Thu, 23 Jul 2020 08:26:12 -0700 (PDT) MIME-Version: 1.0 References: <20200722022514.1283916-1-robh@kernel.org> <20200722022514.1283916-12-robh@kernel.org> In-Reply-To: <20200722022514.1283916-12-robh@kernel.org> From: Rob Herring Date: Thu, 23 Jul 2020 09:26:01 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/19] PCI: Move setting pci_host_bridge.busnr out of host drivers To: Bjorn Helgaas , Lorenzo Pieralisi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_112616_309299_546FB414 X-CRM114-Status: GOOD ( 19.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Karthikeyan Mitran , PCI , Shawn Lin , Thierry Reding , Thomas Petazzoni , Fabio Estevam , Marek Vasut , Linus Walleij , Ryder Lee , Will Deacon , Michal Simek , Jonathan Hunter , "open list:ARM/Rockchip SoC..." , Murali Karicheri , NXP Linux Team , Hou Zhiqiang , Richard Zhu , Sascha Hauer , "moderated list:ARM/Mediatek SoC support" , linux-tegra , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Gustavo Pimentel , Yoshihiro Shimoda , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Tom Joseph , Pengutronix Kernel Team , Jingoo Han , Shawn Guo , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 21, 2020 at 8:25 PM Rob Herring wrote: > > Most host drivers only parse the DT bus range to set the root bus number > in pci_host_bridge.busnr. The ones that don't set busnr are buggy in > that they ignore what's in DT. Let's set busnr in pci_scan_root_bus_bridge() > where we already check for the bus resource and remove setting it in > host drivers. > > Cc: Jingoo Han > Cc: Gustavo Pimentel > Cc: Lorenzo Pieralisi > Cc: Bjorn Helgaas > Cc: Thomas Petazzoni > Cc: Will Deacon > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: Linus Walleij > Cc: Ryder Lee > Cc: Marek Vasut > Cc: Yoshihiro Shimoda > Cc: linux-tegra@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-renesas-soc@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/pci/controller/dwc/pcie-designware-host.c | 4 ---- > drivers/pci/controller/dwc/pcie-designware.h | 1 - > drivers/pci/controller/pci-aardvark.c | 5 ++--- > drivers/pci/controller/pci-host-common.c | 1 - > drivers/pci/controller/pci-tegra.c | 4 +--- > drivers/pci/controller/pci-v3-semi.c | 2 -- > drivers/pci/controller/pcie-mediatek.c | 8 +------- > drivers/pci/controller/pcie-rcar-host.c | 1 - > drivers/pci/probe.c | 1 + > 9 files changed, 5 insertions(+), 22 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > index 9e8a9cfc6d3a..fa922cb876a3 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -374,9 +374,6 @@ int dw_pcie_host_init(struct pcie_port *pp) > pp->cfg0_base = pp->cfg->start; > pp->cfg1_base = pp->cfg->start + pp->cfg0_size; > break; > - case IORESOURCE_BUS: > - pp->busn = win->res; > - break; > } > } > > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h > index fd2146298b58..9fb44290ed43 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.h > +++ b/drivers/pci/controller/dwc/pcie-designware.h > @@ -188,7 +188,6 @@ struct pcie_port { > struct resource *cfg; > struct resource *io; > struct resource *mem; > - struct resource *busn; > int irq; > const struct dw_pcie_host_ops *ops; > int msi_irq; These 2 hunks should be dropped as they are breaking the Amazon driver. Lorenzo, do you want to fixup or I can send a fix? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel