From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AE7AFA372A for ; Wed, 16 Oct 2019 15:02:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6183521925 for ; Wed, 16 Oct 2019 15:02:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571238139; bh=WfD3t0sOjn0IeRh/fxGxBgyuFYh2uz6Bl2g2olvFPCs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=xkFW6naylnPyyMU2LfQaVdoSGLVkouaTuZi7s/DIrRuhpSMtmTB1KAX7+ZSjnUjwp VjSPInLBcCZL9dyZQHMJXHAaqQRX5oWtcbyeBEEayiSrnraS5aT1p+iVoIpgngwksR 9APByP/9H0lkY1WMZiGcnEkYcRs/SWHrgT0pSv0c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393283AbfJPPCS (ORCPT ); Wed, 16 Oct 2019 11:02:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:39618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393123AbfJPPCQ (ORCPT ); Wed, 16 Oct 2019 11:02:16 -0400 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A129A21A4C; Wed, 16 Oct 2019 15:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571238135; bh=WfD3t0sOjn0IeRh/fxGxBgyuFYh2uz6Bl2g2olvFPCs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=oVcWndIeLBrN1dxqtfaQdGl5ih419TuNLsVrvVkSNtG6HzaoxUpnbuGwRrcUSGPii Ltm5cEek/qy2eQgJ/wS062dHuO63leEnK9QAwK4U45nDTvZkYUM9LCkWo7to2tERKm gFBZgIXi6BfM5S/bLwAvaEers78yLTAaHJcia9eI= Received: by mail-qk1-f174.google.com with SMTP id f16so23034718qkl.9; Wed, 16 Oct 2019 08:02:15 -0700 (PDT) X-Gm-Message-State: APjAAAX+ICjvdv0/U+jbsQbPPDAEQ2AmdFx66z2WAo+RwCFus7vNrVdI 8kB8vWdVoO7a94cwpRRWQZPElma5PgIZ16Jzlw== X-Google-Smtp-Source: APXvYqwIgxUwPf/s3sC4AudetBNSqYxFoA0xPNh/UnC4v7MU1s4IRnaWSFhGgS/6m+dhMqCc0QMp0cOsku4Rj7MAdD0= X-Received: by 2002:a37:9847:: with SMTP id a68mr4997426qke.223.1571238134770; Wed, 16 Oct 2019 08:02:14 -0700 (PDT) MIME-Version: 1.0 References: <20191016144747.29538-1-geert+renesas@glider.be> <20191016144747.29538-3-geert+renesas@glider.be> In-Reply-To: <20191016144747.29538-3-geert+renesas@glider.be> From: Rob Herring Date: Wed, 16 Oct 2019 10:02:03 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/4] clocksource/drivers/timer-of: Use unique device name instead of timer To: Geert Uytterhoeven Cc: Daniel Lezcano , Thomas Gleixner , Chris Brandt , Jacopo Mondi , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 16, 2019 at 9:52 AM Geert Uytterhoeven wrote: > > If a hardware-specific driver does not provide a name, the timer-of core > falls back to device_node.name. Due to generic DT node naming policies, > that name is almost always "timer", and thus doesn't identify the actual > timer used. > > Fix this by using device_node.full_name instead, which includes the unit > addrees. > > Example impact on /proc/timer_list: > > -Clock Event Device: timer > +Clock Event Device: timer@fcfec400 > > Signed-off-by: Geert Uytterhoeven > --- > v4: > - New. > --- > drivers/clocksource/timer-of.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Good. One less device_node.name pointer use to get rid of. I want to drop it from the struct and stop storing both node name strings. Reviewed-by: Rob Herring Rob