From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932569AbcILDFf (ORCPT ); Sun, 11 Sep 2016 23:05:35 -0400 Received: from mail.kernel.org ([198.145.29.136]:59174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932254AbcILDFc (ORCPT ); Sun, 11 Sep 2016 23:05:32 -0400 MIME-Version: 1.0 In-Reply-To: <20160911221424.2d56682a@lxorguk.ukuu.org.uk> References: <20160909223711.26238-1-robh@kernel.org> <20160911221424.2d56682a@lxorguk.ukuu.org.uk> From: Rob Herring Date: Sun, 11 Sep 2016 22:05:07 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/9] tty: tty_struct dependency clean-ups To: One Thousand Gnomes Cc: Alan Cox , Greg Kroah-Hartman , Jiri Slaby , Peter Hurley , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 11, 2016 at 4:14 PM, One Thousand Gnomes wrote: > On Fri, 9 Sep 2016 17:37:01 -0500 > Rob Herring wrote: > >> This patch series removes or prepares to remove some of the dependencies >> on tty_struct within tty_port drivers. This will allow using tty_ports >> directly for so called UART slave devices. > > You can create a tty_struct kernel side with the two tiny changes I > posted before. Why do you want to do invasive tree wide changes when you > can do simple ones ? Well, I don't want to do invasive changes, but I thought the idea was to use tty_port struct without a tty_struct. >> Next up after this are moving some functions to the tty_port ops. I've >> got some WIP patches for some of that, but nothing ready to send out >> quite yet. > > I think before this lot happens you need to decide where these structures > belong. Termios and termios_locked for example could live in the tty_port > as the physical tty is incapable of having multiple sets of terminal data > at once. I was planning to keep termios out of tty_port and make clients of tty_port carry it if for nothing else not quite understanding all the details around the lifetime, init and locking of it. If there's always a tty_struct then there's not much point moving it other than which struct makes more sense. But that would cause some churn. Rob