From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B46C24C95; Fri, 16 Sep 2022 12:04:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69580C43140; Fri, 16 Sep 2022 12:04:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663329847; bh=SDyVHic+g5Ln/swY+PozT5sqObg8/WxJ+rqngYuzFro=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=DvQwyaMWXD82NwWUoeJrKeV4DUHsMIooQCYHcmXosyl/K7WeLRGRkRndoqJ3SrkK1 LcvCsmmGFAY+MhYDrz7xpw3FxMi5d+PzQ0fW/asv+Cr0i1n49A0F1qWoS+FI3A47Xy 4B/5WOw0w9/sSli5YXJHD7wXhQ4foTYIZj90a1gBp8ARlG4GJBQK3lyl2LSF6ogojF J6EfBXoXGGAmXN0TxKx6qWywOKVawa0f9COqJsXsBYSXOC1nyzun57z3AbI0LIna/s TwatmS31qbtoiZnWx2n5l9+Hob6BiCu2PxJc5cgSzrVV5jiJdbnLsOTt3755sFgYE1 9aCKWkFxhJIoQ== Received: by mail-vk1-f179.google.com with SMTP id b81so10563354vkf.1; Fri, 16 Sep 2022 05:04:07 -0700 (PDT) X-Gm-Message-State: ACrzQf1q5+slm5UOdqCwXTEXqBIjCD+Api0y9QhunZnl3ktCUD24Xo75 9M8/Y5OHB7TrZkHepjRi35itWxpgz4s+szZU7w== X-Google-Smtp-Source: AMsMyM7R+47aUUSWrJkPcclUE1JWWBatBMqC16j/7ya6IfwoPKPQZf1oKfsbs1hf02nYS8dtX20SyZppgT1c6KwVmjA= X-Received: by 2002:a1f:1d4d:0:b0:382:59cd:596c with SMTP id d74-20020a1f1d4d000000b0038259cd596cmr1736330vkd.35.1663329846359; Fri, 16 Sep 2022 05:04:06 -0700 (PDT) Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220916094152.87137-1-j@jannau.net> <20220916094152.87137-5-j@jannau.net> In-Reply-To: <20220916094152.87137-5-j@jannau.net> From: Rob Herring Date: Fri, 16 Sep 2022 07:03:55 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 4/5] iommu/io-pgtable-dart: Add DART PTE support for t6000 To: Janne Grunau Cc: iommu@lists.linux.dev, Konrad Dybcio , asahi@lists.linux.dev, Sven Peter , Alyssa Rosenzweig , Hector Martin , Joerg Roedel , Will Deacon , Linux IOMMU , linux-arm-kernel , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" On Fri, Sep 16, 2022 at 4:42 AM Janne Grunau wrote: > > From: Sven Peter > > The DARTs present in the M1 Pro/Max/Ultra SoC use a diffent PTE format. > They support a 42bit physical address space by shifting the paddr and > extending its mask inside the PTE. > They also come with mandatory sub-page protection now which we just > configure to always allow access to the entire page. This feature is > already present but optional on the previous DARTs which allows to > unconditionally configure it. > > Signed-off-by: Sven Peter > Co-developed-by: Janne Grunau > Signed-off-by: Janne Grunau > > --- > > (no changes since v3) > > Changes in v3: > - apply change to io-pgtable-dart.c > - handle pte <> paddr conversion based on the pte format instead of > the output address size > > Changes in v2: > - add APPLE_DART2 PTE format > > drivers/iommu/io-pgtable-dart.c | 49 ++++++++++++++++++++++++++++----- > drivers/iommu/io-pgtable.c | 1 + > include/linux/io-pgtable.h | 1 + > 3 files changed, 44 insertions(+), 7 deletions(-) Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD00CC54EE9 for ; Fri, 16 Sep 2022 12:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2NPP24RsP1++7k1ZMZL7uzkmtQgk1PEcz0tK29sr/vA=; b=Mny/8WDXQyVMdT kXnM4CajH+MqShJNF89ZSrdp9F+3gn9AHuidX7TF6zAQlQM8N4uuGJMzjQjGi9QvDLLOBec5haSZI dwaT2K+NsrI5sEFpCEj0vvbFpMDhcy0xr5nOYmKFLeNI8n9To7eIbLjAXlHIDBmu/+mLbo4/IG0pX k7LNqP6trVjc8QI060fp5Cva/khuzNkffXd9gBlTFUn7OXnNepbYCVfTK//nZ0eUEecRx6/wO7pAO y16QK9j+Cr9zaaRoTz4KAhiAhEPmq93n7vh9QYeB3YuNvpgvyy0NNkjkx3GmH5gz7jI3NbLYNlKpl xpxsxHqnA7b8Ao0eC5pQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZA4q-00Czls-BH; Fri, 16 Sep 2022 12:04:12 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZA4n-00CzkW-T1 for linux-arm-kernel@lists.infradead.org; Fri, 16 Sep 2022 12:04:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 929AB62B4A for ; Fri, 16 Sep 2022 12:04:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71A72C43142 for ; Fri, 16 Sep 2022 12:04:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663329847; bh=SDyVHic+g5Ln/swY+PozT5sqObg8/WxJ+rqngYuzFro=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=DvQwyaMWXD82NwWUoeJrKeV4DUHsMIooQCYHcmXosyl/K7WeLRGRkRndoqJ3SrkK1 LcvCsmmGFAY+MhYDrz7xpw3FxMi5d+PzQ0fW/asv+Cr0i1n49A0F1qWoS+FI3A47Xy 4B/5WOw0w9/sSli5YXJHD7wXhQ4foTYIZj90a1gBp8ARlG4GJBQK3lyl2LSF6ogojF J6EfBXoXGGAmXN0TxKx6qWywOKVawa0f9COqJsXsBYSXOC1nyzun57z3AbI0LIna/s TwatmS31qbtoiZnWx2n5l9+Hob6BiCu2PxJc5cgSzrVV5jiJdbnLsOTt3755sFgYE1 9aCKWkFxhJIoQ== Received: by mail-vk1-f169.google.com with SMTP id bi53so10545196vkb.12 for ; Fri, 16 Sep 2022 05:04:07 -0700 (PDT) X-Gm-Message-State: ACrzQf1fiR2X39Ytyd62DBR3r/asr5+qLjE+Mv0Swuzlx8lE2RTGcySv ozq9LWzVT6nhHTg+DWZyGJ7tHw7+B/fkHtCuOg== X-Google-Smtp-Source: AMsMyM7R+47aUUSWrJkPcclUE1JWWBatBMqC16j/7ya6IfwoPKPQZf1oKfsbs1hf02nYS8dtX20SyZppgT1c6KwVmjA= X-Received: by 2002:a1f:1d4d:0:b0:382:59cd:596c with SMTP id d74-20020a1f1d4d000000b0038259cd596cmr1736330vkd.35.1663329846359; Fri, 16 Sep 2022 05:04:06 -0700 (PDT) MIME-Version: 1.0 References: <20220916094152.87137-1-j@jannau.net> <20220916094152.87137-5-j@jannau.net> In-Reply-To: <20220916094152.87137-5-j@jannau.net> From: Rob Herring Date: Fri, 16 Sep 2022 07:03:55 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 4/5] iommu/io-pgtable-dart: Add DART PTE support for t6000 To: Janne Grunau Cc: iommu@lists.linux.dev, Konrad Dybcio , asahi@lists.linux.dev, Sven Peter , Alyssa Rosenzweig , Hector Martin , Joerg Roedel , Will Deacon , Linux IOMMU , linux-arm-kernel , "linux-kernel@vger.kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220916_050409_997670_2972B918 X-CRM114-Status: GOOD ( 18.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 16, 2022 at 4:42 AM Janne Grunau wrote: > > From: Sven Peter > > The DARTs present in the M1 Pro/Max/Ultra SoC use a diffent PTE format. > They support a 42bit physical address space by shifting the paddr and > extending its mask inside the PTE. > They also come with mandatory sub-page protection now which we just > configure to always allow access to the entire page. This feature is > already present but optional on the previous DARTs which allows to > unconditionally configure it. > > Signed-off-by: Sven Peter > Co-developed-by: Janne Grunau > Signed-off-by: Janne Grunau > > --- > > (no changes since v3) > > Changes in v3: > - apply change to io-pgtable-dart.c > - handle pte <> paddr conversion based on the pte format instead of > the output address size > > Changes in v2: > - add APPLE_DART2 PTE format > > drivers/iommu/io-pgtable-dart.c | 49 ++++++++++++++++++++++++++++----- > drivers/iommu/io-pgtable.c | 1 + > include/linux/io-pgtable.h | 1 + > 3 files changed, 44 insertions(+), 7 deletions(-) Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel