From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754493AbbCQAZu (ORCPT ); Mon, 16 Mar 2015 20:25:50 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:36001 "EHLO mail-we0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbbCQAZs (ORCPT ); Mon, 16 Mar 2015 20:25:48 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Rob Herring Date: Mon, 16 Mar 2015 19:25:26 -0500 Message-ID: Subject: Re: kexec fails if OF_UNITTEST=y (was: Re: [PATCH v2] Removes OF_UNITTEST dependency on OF_DYNAMIC config symbol) To: Geert Uytterhoeven Cc: Gaurav Minocha , "devicetree@vger.kernel.org" , Grant Likely , Rob Herring , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2015 at 5:58 AM, Geert Uytterhoeven wrote: > On Fri, Jan 23, 2015 at 2:03 PM, Geert Uytterhoeven > wrote: >> On Sun, Jan 11, 2015 at 8:19 AM, Gaurav Minocha >> wrote: >>> This patch intends to remove the unittests dependency on >>> the functions defined in dynamic.c. So, rather than calling >>> of_attach_node defined in dynamic.c, minimal functionality >>> required to attach a new node is re-defined in unittest.c. >>> Also, now after executing the tests the test data is not >>> removed from the device tree so there is no need to call >>> of_detach_node. >> >> Could there be unwanted side effects of not removing the test data? > > Unfortunately I found a regression introduced by commit 3ce04b4a9fdc30b6 > ("Removes OF_UNITTEST dependency on OF_DYNAMIC config symbol"). > > If the test data is still present, kexec (kexec-tools 2.0.7 released 24 > November 2014, 1:2.0.7-5 in Debian) fails with: > > unrecoverable error: short read > from"/proc/device-tree//testcase-data/large-property-PAGE_SIZEx8" > > Granted, this is a bug in kexec-tools, but I'm reporting it anyway, as it is > a kernel regression with existing userspace. > > I believe this bug was fixed in kexec-tools by commit d1932cd592e2a6aa > ("kexec/fs2dt: Use slurp_file_len to avoid partial read of files"), but I > haven't tested the fix yet. Is OF_UNITTEST enabled by default in Debian or this is a custom kernel? Perhaps we should require a command line option to actually populate the test data and run the tests? We just need more tests to slow down the boot enough people will not enable them by default. ;) Rob > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: kexec fails if OF_UNITTEST=y (was: Re: [PATCH v2] Removes OF_UNITTEST dependency on OF_DYNAMIC config symbol) Date: Mon, 16 Mar 2015 19:25:26 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Geert Uytterhoeven Cc: Gaurav Minocha , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Grant Likely , Rob Herring , "kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Mon, Mar 16, 2015 at 5:58 AM, Geert Uytterhoeven wrote: > On Fri, Jan 23, 2015 at 2:03 PM, Geert Uytterhoeven > wrote: >> On Sun, Jan 11, 2015 at 8:19 AM, Gaurav Minocha >> wrote: >>> This patch intends to remove the unittests dependency on >>> the functions defined in dynamic.c. So, rather than calling >>> of_attach_node defined in dynamic.c, minimal functionality >>> required to attach a new node is re-defined in unittest.c. >>> Also, now after executing the tests the test data is not >>> removed from the device tree so there is no need to call >>> of_detach_node. >> >> Could there be unwanted side effects of not removing the test data? > > Unfortunately I found a regression introduced by commit 3ce04b4a9fdc30b6 > ("Removes OF_UNITTEST dependency on OF_DYNAMIC config symbol"). > > If the test data is still present, kexec (kexec-tools 2.0.7 released 24 > November 2014, 1:2.0.7-5 in Debian) fails with: > > unrecoverable error: short read > from"/proc/device-tree//testcase-data/large-property-PAGE_SIZEx8" > > Granted, this is a bug in kexec-tools, but I'm reporting it anyway, as it is > a kernel regression with existing userspace. > > I believe this bug was fixed in kexec-tools by commit d1932cd592e2a6aa > ("kexec/fs2dt: Use slurp_file_len to avoid partial read of files"), but I > haven't tested the fix yet. Is OF_UNITTEST enabled by default in Debian or this is a custom kernel? Perhaps we should require a command line option to actually populate the test data and run the tests? We just need more tests to slow down the boot enough people will not enable them by default. ;) Rob > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-we0-x232.google.com ([2a00:1450:400c:c03::232]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YXfKj-0005Sw-LX for kexec@lists.infradead.org; Tue, 17 Mar 2015 00:26:10 +0000 Received: by wegp1 with SMTP id p1so49600023weg.1 for ; Mon, 16 Mar 2015 17:25:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Rob Herring Date: Mon, 16 Mar 2015 19:25:26 -0500 Message-ID: Subject: Re: kexec fails if OF_UNITTEST=y (was: Re: [PATCH v2] Removes OF_UNITTEST dependency on OF_DYNAMIC config symbol) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Geert Uytterhoeven Cc: "devicetree@vger.kernel.org" , Rob Herring , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Gaurav Minocha , Grant Likely On Mon, Mar 16, 2015 at 5:58 AM, Geert Uytterhoeven wrote: > On Fri, Jan 23, 2015 at 2:03 PM, Geert Uytterhoeven > wrote: >> On Sun, Jan 11, 2015 at 8:19 AM, Gaurav Minocha >> wrote: >>> This patch intends to remove the unittests dependency on >>> the functions defined in dynamic.c. So, rather than calling >>> of_attach_node defined in dynamic.c, minimal functionality >>> required to attach a new node is re-defined in unittest.c. >>> Also, now after executing the tests the test data is not >>> removed from the device tree so there is no need to call >>> of_detach_node. >> >> Could there be unwanted side effects of not removing the test data? > > Unfortunately I found a regression introduced by commit 3ce04b4a9fdc30b6 > ("Removes OF_UNITTEST dependency on OF_DYNAMIC config symbol"). > > If the test data is still present, kexec (kexec-tools 2.0.7 released 24 > November 2014, 1:2.0.7-5 in Debian) fails with: > > unrecoverable error: short read > from"/proc/device-tree//testcase-data/large-property-PAGE_SIZEx8" > > Granted, this is a bug in kexec-tools, but I'm reporting it anyway, as it is > a kernel regression with existing userspace. > > I believe this bug was fixed in kexec-tools by commit d1932cd592e2a6aa > ("kexec/fs2dt: Use slurp_file_len to avoid partial read of files"), but I > haven't tested the fix yet. Is OF_UNITTEST enabled by default in Debian or this is a custom kernel? Perhaps we should require a command line option to actually populate the test data and run the tests? We just need more tests to slow down the boot enough people will not enable them by default. ;) Rob > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec