From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] drm: Convert to using %pOFn instead of device_node.name Date: Tue, 28 Aug 2018 10:04:22 -0500 Message-ID: References: <20180828015252.28511-1-robh@kernel.org> <20180828015252.28511-19-robh@kernel.org> <597b1b06-e1fb-dcf1-67f4-d6685fd38cad@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <597b1b06-e1fb-dcf1-67f4-d6685fd38cad-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Maarten Lankhorst Cc: freedreno , David Airlie , Gustavo Padovan , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , dri-devel , Rob Clark , linux-arm-msm , Sean Paul List-Id: linux-arm-msm@vger.kernel.org T24gVHVlLCBBdWcgMjgsIDIwMTggYXQgNzo1NCBBTSBNYWFydGVuIExhbmtob3JzdAo8bWFhcnRl bi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPiB3cm90ZToKPgo+IE9wIDI4LTA4LTE4IG9tIDAz OjUyIHNjaHJlZWYgUm9iIEhlcnJpbmc6Cj4gPiBJbiBwcmVwYXJhdGlvbiB0byByZW1vdmUgdGhl IG5vZGUgbmFtZSBwb2ludGVyIGZyb20gc3RydWN0IGRldmljZV9ub2RlLAo+ID4gY29udmVydCBw cmludGYgdXNlcnMgdG8gdXNlIHRoZSAlcE9GbiBmb3JtYXQgc3BlY2lmaWVyLgo+ID4KPiA+IENj OiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm9AcGFkb3Zhbi5vcmc+Cj4gPiBDYzogTWFhcnRlbiBM YW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBTZWFu IFBhdWwgPHNlYW5AcG9vcmx5LnJ1bj4KPiA+IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGlu dXguaWU+Cj4gPiBDYzogUm9iIENsYXJrIDxyb2JkY2xhcmtAZ21haWwuY29tPgo+ID4gQ2M6IGRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IENjOiBsaW51eC1hcm0tbXNtQHZnZXIu a2VybmVsLm9yZwo+ID4gQ2M6IGZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IFNp Z25lZC1vZmYtYnk6IFJvYiBIZXJyaW5nIDxyb2JoQGtlcm5lbC5vcmc+Cj4gPiAtLS0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vZHJtX21vZGVzLmMgICAgIHwgNCArKy0tCj4gPiAgZHJpdmVycy9ncHUv ZHJtL21zbS9oZG1pL2hkbWkuYyB8IDIgKy0KPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0 aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2RybV9tb2Rlcy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9tb2Rlcy5jCj4gPiBpbmRleCAw MmRiOWFjODJkN2EuLjI0YTc1MDQzNjU1OSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fbW9kZXMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9tb2Rlcy5jCj4gPiBA QCAtNzE2LDggKzcxNiw4IEBAIGludCBvZl9nZXRfZHJtX2Rpc3BsYXlfbW9kZShzdHJ1Y3QgZGV2 aWNlX25vZGUgKm5wLAo+ID4gICAgICAgaWYgKGJ1c19mbGFncykKPiA+ICAgICAgICAgICAgICAg ZHJtX2J1c19mbGFnc19mcm9tX3ZpZGVvbW9kZSgmdm0sIGJ1c19mbGFncyk7Cj4gPgo+ID4gLSAg ICAgcHJfZGVidWcoIiVwT0Y6IGdvdCAlZHglZCBkaXNwbGF5IG1vZGUgZnJvbSAlc1xuIiwKPiA+ IC0gICAgICAgICAgICAgbnAsIHZtLmhhY3RpdmUsIHZtLnZhY3RpdmUsIG5wLT5uYW1lKTsKPiA+ ICsgICAgIHByX2RlYnVnKCIlcE9GOiBnb3QgJWR4JWQgZGlzcGxheSBtb2RlXG4iLAo+ID4gKyAg ICAgICAgICAgICBucCwgdm0uaGFjdGl2ZSwgdm0udmFjdGl2ZSk7Cj4gQXJlbid0IHlvdSByZW1v dmluZyBpdCBoZXJlIGluc3RlYWQgb2YgY29udmVydGluZz8KCldlbGwsIHllcy4gVGhlIGZ1bGwg cGF0aCBhbmQgbmFtZSBhcmUgYWxyZWFkeSBwcmludGVkIHNvIHRoZSBub2RlIG5hbWUKYWxvbmUg d2FzIHByZXR0eSByZWR1bmRhbnQuCgpSb2IKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KRnJlZWRyZW5vIG1haWxpbmcgbGlzdApGcmVlZHJlbm9AbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZnJlZWRyZW5vCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07C4AC433F4 for ; Tue, 28 Aug 2018 15:04:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD2D62086D for ; Tue, 28 Aug 2018 15:04:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ESMfYzhu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD2D62086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727216AbeH1S4k (ORCPT ); Tue, 28 Aug 2018 14:56:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:34482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726807AbeH1S4k (ORCPT ); Tue, 28 Aug 2018 14:56:40 -0400 Received: from mail-qt0-f182.google.com (mail-qt0-f182.google.com [209.85.216.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD2872087B; Tue, 28 Aug 2018 15:04:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1535468674; bh=FBJDJgrDZj8hSHs0gy7bP4ijiRNv7XVOKCsmGExckT8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ESMfYzhuc4Lzxhzl/LFQAIKWqOyi6nUpvkpf3+laCCVxewPnx5snbCM52h68q1MB8 hy666jApZKhBsd+zdIkv5GRvxGUOBFHAAvGzRgsrdM5n+LtP2aD0qYoxB8xRnVmI0g c+igMig03MTLiDeBmkQRIRMA49IasX6kxwfmWJfw= Received: by mail-qt0-f182.google.com with SMTP id t5-v6so2057769qtn.3; Tue, 28 Aug 2018 08:04:34 -0700 (PDT) X-Gm-Message-State: APzg51C2aL6R1Exvl0+Q8aUnxqMOPmnQpuJKP46+RVvz7OZKZP3EBRjH /6MjiGtIG4OqXxa7IyyIGOYmmLWSExBw75BSow== X-Google-Smtp-Source: ANB0VdY87SAwzDDvyMGp/19k0oPIreDyXkKL3fStq3YIWdMTBak4xIMPJhvU0BpzxA3wJZJ8xNy9XOp9fYm6dyMC/Y4= X-Received: by 2002:ac8:148b:: with SMTP id l11-v6mr2139464qtj.27.1535468673978; Tue, 28 Aug 2018 08:04:33 -0700 (PDT) MIME-Version: 1.0 References: <20180828015252.28511-1-robh@kernel.org> <20180828015252.28511-19-robh@kernel.org> <597b1b06-e1fb-dcf1-67f4-d6685fd38cad@linux.intel.com> In-Reply-To: <597b1b06-e1fb-dcf1-67f4-d6685fd38cad@linux.intel.com> From: Rob Herring Date: Tue, 28 Aug 2018 10:04:22 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm: Convert to using %pOFn instead of device_node.name To: Maarten Lankhorst Cc: "linux-kernel@vger.kernel.org" , Gustavo Padovan , Sean Paul , David Airlie , Rob Clark , dri-devel , linux-arm-msm , freedreno Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 28, 2018 at 7:54 AM Maarten Lankhorst wrote: > > Op 28-08-18 om 03:52 schreef Rob Herring: > > In preparation to remove the node name pointer from struct device_node, > > convert printf users to use the %pOFn format specifier. > > > > Cc: Gustavo Padovan > > Cc: Maarten Lankhorst > > Cc: Sean Paul > > Cc: David Airlie > > Cc: Rob Clark > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-arm-msm@vger.kernel.org > > Cc: freedreno@lists.freedesktop.org > > Signed-off-by: Rob Herring > > --- > > drivers/gpu/drm/drm_modes.c | 4 ++-- > > drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > > index 02db9ac82d7a..24a750436559 100644 > > --- a/drivers/gpu/drm/drm_modes.c > > +++ b/drivers/gpu/drm/drm_modes.c > > @@ -716,8 +716,8 @@ int of_get_drm_display_mode(struct device_node *np, > > if (bus_flags) > > drm_bus_flags_from_videomode(&vm, bus_flags); > > > > - pr_debug("%pOF: got %dx%d display mode from %s\n", > > - np, vm.hactive, vm.vactive, np->name); > > + pr_debug("%pOF: got %dx%d display mode\n", > > + np, vm.hactive, vm.vactive); > Aren't you removing it here instead of converting? Well, yes. The full path and name are already printed so the node name alone was pretty redundant. Rob