From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62157C433ED for ; Thu, 20 May 2021 18:04:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 407E860FF1 for ; Thu, 20 May 2021 18:04:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233621AbhETSFy (ORCPT ); Thu, 20 May 2021 14:05:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:55742 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233351AbhETSFw (ORCPT ); Thu, 20 May 2021 14:05:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AFC6C6100A for ; Thu, 20 May 2021 18:04:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621533870; bh=VQwp4XJLOY8NbEJ2c96jI+zDjuoFguc3td2LgXxVTvo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=MFFsRMD/5TJnCqUKZ4pnq2uz7YHPN1clRmQ8RA2xxF9nA5uEYVfky4nQMglyVQ75O 70D3N+3uHl9mELxNIX3G4/aUGUAUTIsfmNMLtrHKH6Dut4fhhN0iwNSzCzAoPrHxOR hEt3bQvS/GwUE3QXJH7vWU7/9feUucSXvy0XrLQsB4wd8b5tQtxAPsAGU8xxPAl7+r vUMdNZ9fCd1QHy7IoYkGkxxd7w4G4LW49PHYW4+MP/HQd+bb3mfslXKUC/FXWVOUtH 0ClANE9J6t12lterT3bhx3CPYLao/7O4RCP/ZyYxaNmK7V0UhQLW9EYCO83i2+c0zh lIlFVNawUCQwg== Received: by mail-ed1-f45.google.com with SMTP id b17so20490824ede.0 for ; Thu, 20 May 2021 11:04:30 -0700 (PDT) X-Gm-Message-State: AOAM533BKotuM/HA0KTq0igaNvfcghTs7EGEQUGPwGQXPvQL4ezTomV9 PKlzJlyyM+xFEorrr5dblcR3ey2q3lIoW4wEww== X-Google-Smtp-Source: ABdhPJyg46HfyNml8JnUNhE2Dk7TTa9xNEt/Bo8IgrXmIz+8P4+WSt6KtYmdrtHtGrjwSKwdH4zNHfQ9kcQPrfoWn4s= X-Received: by 2002:a05:6402:c7:: with SMTP id i7mr6481075edu.194.1621533869303; Thu, 20 May 2021 11:04:29 -0700 (PDT) MIME-Version: 1.0 References: <20210520163751.27325-1-maz@kernel.org> <20210520163751.27325-35-maz@kernel.org> In-Reply-To: <20210520163751.27325-35-maz@kernel.org> From: Rob Herring Date: Thu, 20 May 2021 13:04:17 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 34/39] ARM: Bulk conversion to generic_handle_domain_irq() To: Marc Zyngier Cc: "linux-kernel@vger.kernel.org" , Thomas Gleixner , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Ley Foon Tan , Chris Zankel , Max Filippov , Vineet Gupta , Thomas Bogendoerfer , Robert Jarzmik , Russell King , Krzysztof Kozlowski , Yoshinori Sato , Rich Felker , Geert Uytterhoeven , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Daniel Vetter , Rob Clark , Linus Walleij , Lee Jones , Lorenzo Pieralisi , Bjorn Helgaas , Bartosz Golaszewski , Android Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 20, 2021 at 11:58 AM Marc Zyngier wrote: > > Wherever possible, replace constructs that match either > generic_handle_irq(irq_find_mapping()) or > generic_handle_irq(irq_linear_revmap()) to a single call to > generic_handle_domain_irq(). > > Signed-off-by: Marc Zyngier > --- > arch/arm/mach-pxa/pxa_cplds_irqs.c | 6 ++---- > arch/arm/mach-s3c/irq-s3c24xx.c | 5 ++--- > 2 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/arch/arm/mach-pxa/pxa_cplds_irqs.c b/arch/arm/mach-pxa/pxa_cplds_irqs.c > index ec0d9b094744..ce1bbabbad54 100644 > --- a/arch/arm/mach-pxa/pxa_cplds_irqs.c > +++ b/arch/arm/mach-pxa/pxa_cplds_irqs.c > @@ -39,10 +39,8 @@ static irqreturn_t cplds_irq_handler(int in_irq, void *d) > > do { > pending = readl(fpga->base + FPGA_IRQ_SET_CLR) & fpga->irq_mask; > - for_each_set_bit(bit, &pending, CPLDS_NB_IRQ) { > - generic_handle_irq(irq_find_mapping(fpga->irqdomain, > - bit)); > - } > + for_each_set_bit(bit, &pending, CPLDS_NB_IRQ) > + generic_handle_domain_irq(fpga->irqdomain, bit); We see this pattern a bit, I'm wondering if we can come up with a common helper. For an even longer name, something like: generic_handle_domain_irq_for_bitmap(fpga->irqdomain, &pending, CPLDS_NB_IRQ); Rob