From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB8ECC46466 for ; Mon, 5 Oct 2020 15:37:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7B862075A for ; Mon, 5 Oct 2020 15:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601912247; bh=QmCHU7ZxDcq6ahUu/Woq4aquYA1/mphg3DrGpWdrRbQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=VVmDZ9hCWDqUfV2nePLI1uxjOH1SWh2gr9z+NmZ+7EJwAMdDQyLyJrQG9o/6lXOiC 38deFBibwRfTgmRvVCT9xHxlmV3IJRRoWSru2Zn/3a74mQaGY7iXlpP6OiyOe9CyhO HUClahVUF4VSN5WO+pKQjk2UQaRo9n9s2Ae81dKQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728055AbgJEPh0 (ORCPT ); Mon, 5 Oct 2020 11:37:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:40912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727974AbgJEPhV (ORCPT ); Mon, 5 Oct 2020 11:37:21 -0400 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39D69206DD for ; Mon, 5 Oct 2020 15:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601912241; bh=QmCHU7ZxDcq6ahUu/Woq4aquYA1/mphg3DrGpWdrRbQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=k+0fVyXfLLXGACLXCvdTmPulSkHgkspFMXi7KefygJKCfJbG/vj/3IAy1vEWoixUC Cuq4uSaRIQBQMTlnAWwRZ4oTzPm6mF83Dxxlx63TbUPW0pUUNAWTPcwX8+4SjIs3DL EkHoArsgWBhd7GRbKAnW6FXHsVvWc1463jI0sMIc= Received: by mail-ot1-f46.google.com with SMTP id o8so9020369otl.4 for ; Mon, 05 Oct 2020 08:37:21 -0700 (PDT) X-Gm-Message-State: AOAM531hcJiJ8C2D17oFZnLIv8RTn4U/eUi1sdj90hhRNPaPaeAvykkO doZyM7cDDGVUuxyHK1ULvfY3+BRP11IrIroCKg== X-Google-Smtp-Source: ABdhPJzsH1uqqAAoHtLEvcKmHTiLoocvbR9S34oDR55xwJDNuRX1Yovmy1gHyfHIqS1U8Incnd+L5O/K2x8K3Jfy/RQ= X-Received: by 2002:a9d:1c90:: with SMTP id l16mr4428421ota.192.1601912240573; Mon, 05 Oct 2020 08:37:20 -0700 (PDT) MIME-Version: 1.0 References: <20201005071403.17450-1-ricardo.canuelo@collabora.com> <20201005071403.17450-4-ricardo.canuelo@collabora.com> In-Reply-To: <20201005071403.17450-4-ricardo.canuelo@collabora.com> From: Rob Herring Date: Mon, 5 Oct 2020 10:37:09 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] dt-bindings: mfd: google,cros-ec: add missing properties To: =?UTF-8?Q?Ricardo_Ca=C3=B1uelo?= Cc: Collabora Kernel ML , Enric Balletbo i Serra , Benson Leung , Guenter Roeck , Simon Glass , Doug Anderson , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Oct 5, 2020 at 2:14 AM Ricardo Ca=C3=B1uelo wrote: > > Add missing properties that are currently used in the examples of > subnode bindings and in many DTs. > This fixes all current dt_binding_check and dtbs_check warnings related > to this binding. > > Signed-off-by: Ricardo Ca=C3=B1uelo > --- > .../bindings/mfd/google,cros-ec.yaml | 40 +++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/= Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > index f49c0d5d31ad..c2dc05cdef9f 100644 > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > @@ -59,18 +59,58 @@ properties: > whether this nvram is present or not. > type: boolean > > + mtk,rpmsg-name: This should have been mediatek,rpmsg-name, but I guess we're stuck with it. > + description: > + Must be defined if the cros-ec is a rpmsg device for a Mediatek > + ARM Cortex M4 Co-processor. Contains the name pf the rpmsg > + device. Used to match the subnode to the rpmsg device announced by > + the SCP. > + $ref: /schemas/types.yaml#/definitions/string > + > spi-max-frequency: > description: Maximum SPI frequency of the device in Hz. > > reg: > maxItems: 1 > > + '#address-cells': > + enum: [1, 2] > + > + '#size-cells': > + enum: [0, 1] This doesn't really make sense. Either there's a size or there isn't. [...] > + "^regulator@[a-f0-9]+$": > + "^ec-codec@[a-f0-9]+$": What does the number space represent and is it the same for each of these? If not, then this is kind of broken. There's only 1 number space at a given level. Rob