From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFECEC43218 for ; Thu, 25 Apr 2019 23:07:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D05C20717 for ; Thu, 25 Apr 2019 23:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556233652; bh=xs2ElDN3VlxrnapRQbm5yDFRi/V9chScs6L10QtA0Qg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=rsdUQkm7f2i1dM16HYC82RzChQPJO+X45OEjtB3xg+NWCvIz9hhC4yNqq79IiO9fA Mp9p8swsYA5NEyInsmEFL7YeHEm5ZRPdyDhrRz/RqImcaKE9umJJK5IzOmU+jMtfDe fusiaXirwwumuSt/6oVRUzV9CIQLrrIxUTtVo4hk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729809AbfDYXHa (ORCPT ); Thu, 25 Apr 2019 19:07:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:43034 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726411AbfDYXH3 (ORCPT ); Thu, 25 Apr 2019 19:07:29 -0400 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4797720895; Thu, 25 Apr 2019 23:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556233649; bh=xs2ElDN3VlxrnapRQbm5yDFRi/V9chScs6L10QtA0Qg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iIlaFPmM4U5+uyj7Ix2SY+wLkcJ+vZbu7wNlO581Sv/8BHbOet/lFGz91rx/VRGMb 8YMw1L/hbMMSqYQanICIOYXixfyLULnEDCN3xEUVfs/o07khyTeVa0hwG3XPKZNTjZ KXdlt9C57Ovm3eXrq3vi/G/bHTv4B/5pyqCyotPw= Received: by mail-qk1-f170.google.com with SMTP id n81so846774qke.2; Thu, 25 Apr 2019 16:07:28 -0700 (PDT) X-Gm-Message-State: APjAAAXd/lna+DOIwhjUcDTmCWID17CFYxgpceFjyUSzOO4gZcETqiLt 9WWcEei+cgc5Ny1fYb0ZsNHY7azQvhWpvvsnhA== X-Google-Smtp-Source: APXvYqwgrV/l589fPtDNrIOiiKybEA2Z15lcEDOd2DbfybYxAIdblzmtNQSGFcfS7BuaN+/O27X2nI2f7wuI+fKBzk4= X-Received: by 2002:a37:4a51:: with SMTP id x78mr2024304qka.184.1556233648090; Thu, 25 Apr 2019 16:07:28 -0700 (PDT) MIME-Version: 1.0 References: <1556092536-17095-1-git-send-email-masonccyang@mxic.com.tw> <1556092536-17095-4-git-send-email-masonccyang@mxic.com.tw> <20190424212356.GA27103@bogus> <65853dc2-6f3c-1494-7e72-54877797cdd2@gmail.com> In-Reply-To: <65853dc2-6f3c-1494-7e72-54877797cdd2@gmail.com> From: Rob Herring Date: Thu, 25 Apr 2019 18:07:16 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings To: Marek Vasut Cc: Mason Yang , Mark Brown , "linux-kernel@vger.kernel.org" , linux-spi , Boris Brezillon , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Geert Uytterhoeven , Lee Jones , Sergei Shtylyov , Mark Rutland , devicetree@vger.kernel.org, Julien Su , Simon Horman , zhengxunli@mxic.com.tw Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 24, 2019 at 4:54 PM Marek Vasut wrote: > > On 4/24/19 11:23 PM, Rob Herring wrote: > > On Wed, Apr 24, 2019 at 03:55:36PM +0800, Mason Yang wrote: > >> Document the bindings used by the Renesas R-Car Gen3 RPC-IF MFD. > >> > >> Signed-off-by: Mason Yang > >> --- > >> .../devicetree/bindings/mfd/mfd-renesas-rpc.txt | 40 ++++++++++++++++++++++ > >> 1 file changed, 40 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > >> > >> diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > >> new file mode 100644 > >> index 0000000..668b822 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > >> @@ -0,0 +1,40 @@ > >> +Renesas R-Car Gen3 RPC-IF MFD Device Tree Bindings > >> +-------------------------------------------------- > > > > Looks like a SPI flash controller from the example. What makes it an > > MFD? > > It supports both SPI NOR and HyperFlash (CFI-compliant flash with > different bus interface). Not sure that really makes it an MFD. Lee probably has an opinion. In any case, can we get a complete binding that shows both. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings Date: Thu, 25 Apr 2019 18:07:16 -0500 Message-ID: References: <1556092536-17095-1-git-send-email-masonccyang@mxic.com.tw> <1556092536-17095-4-git-send-email-masonccyang@mxic.com.tw> <20190424212356.GA27103@bogus> <65853dc2-6f3c-1494-7e72-54877797cdd2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <65853dc2-6f3c-1494-7e72-54877797cdd2@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Marek Vasut Cc: Mason Yang , Mark Brown , "linux-kernel@vger.kernel.org" , linux-spi , Boris Brezillon , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Geert Uytterhoeven , Lee Jones , Sergei Shtylyov , Mark Rutland , devicetree@vger.kernel.org, Julien Su , Simon Horman , zhengxunli@mxic.com.tw List-Id: devicetree@vger.kernel.org On Wed, Apr 24, 2019 at 4:54 PM Marek Vasut wrote: > > On 4/24/19 11:23 PM, Rob Herring wrote: > > On Wed, Apr 24, 2019 at 03:55:36PM +0800, Mason Yang wrote: > >> Document the bindings used by the Renesas R-Car Gen3 RPC-IF MFD. > >> > >> Signed-off-by: Mason Yang > >> --- > >> .../devicetree/bindings/mfd/mfd-renesas-rpc.txt | 40 ++++++++++++++++++++++ > >> 1 file changed, 40 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > >> > >> diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > >> new file mode 100644 > >> index 0000000..668b822 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt > >> @@ -0,0 +1,40 @@ > >> +Renesas R-Car Gen3 RPC-IF MFD Device Tree Bindings > >> +-------------------------------------------------- > > > > Looks like a SPI flash controller from the example. What makes it an > > MFD? > > It supports both SPI NOR and HyperFlash (CFI-compliant flash with > different bus interface). Not sure that really makes it an MFD. Lee probably has an opinion. In any case, can we get a complete binding that shows both. Rob