From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4164BC43381 for ; Thu, 21 Jan 2021 17:48:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C333207C5 for ; Thu, 21 Jan 2021 17:48:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389253AbhAURsb (ORCPT ); Thu, 21 Jan 2021 12:48:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:52352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389053AbhAURqy (ORCPT ); Thu, 21 Jan 2021 12:46:54 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3D3CB22A85 for ; Thu, 21 Jan 2021 17:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611251166; bh=8Vgfa2YyRq9M4HMsdg2N5RVEwQqUfKMIoedhRicA3i8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bkWwKqyDQSQzUF6c3Ef+beGqDZgdJ+B0m3wmkPCJ4O3ZYxcMtFZj3Iag4w3ZAH+48 +ROPQCn1WTVgOXiIxKphyFKnFnQnFLr0GakCHkSxPb7WtdA9laaYWfnB0v+huoVDLe H94YYxtTu5voA/u+stvcD0aeJoKeEuEMycFpPhUr4I32wg1G6NXW9F28Kpk3QQP9I7 CmXDVQ8BF3BpZKg6G3YynU5QNWyRKDdNAyq0N98XKUVi0I9oFnMBWPdHQrwibqOcrO XwUbGTWE13Mh3SbVYfjdSFnSVS3vX4j6EWl4SjkibF9Wy58a4F953+ucZRDEer6AAY MkcZEPrL9zUzg== Received: by mail-ej1-f44.google.com with SMTP id r12so3815544ejb.9 for ; Thu, 21 Jan 2021 09:46:06 -0800 (PST) X-Gm-Message-State: AOAM533acx3+C62aj4Icqo3EYVnpL4BI1XLo+hq/qs70o1lDlOU2Ts8h yxCG6gyzm4G7p9Erk0zBjEfnHyhNA4wI2YMMJw== X-Google-Smtp-Source: ABdhPJxZ6w3DGy8e6iuFR3womYGkTwr2xd6oYATYjCw5hfVyz7Ge7r8p5AKFVrANgIpFc03gZIpusPNihpwj6i4MQOY= X-Received: by 2002:a17:906:25c4:: with SMTP id n4mr395803ejb.359.1611251164737; Thu, 21 Jan 2021 09:46:04 -0800 (PST) MIME-Version: 1.0 References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-5-mohamed.mediouni@caramail.com> In-Reply-To: From: Rob Herring Date: Thu, 21 Jan 2021 11:45:51 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC To: Arnd Bergmann Cc: Linus Walleij , Mark Rutland , Marc Zyngier , Hector Martin , "linux-kernel@vger.kernel.org" , Catalin Marinas , Mohamed Mediouni , Will Deacon , Linux ARM , Stan Skowronek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2021 at 4:38 AM Arnd Bergmann wrote: > > On Thu, Jan 21, 2021 at 10:48 AM Linus Walleij wrote: > > > > Hi Mohamed, > > > > thanks for your patch! > > > > On Wed, Jan 20, 2021 at 2:31 PM Mohamed Mediouni > > wrote: > > > > > +properties: > > > + compatible: > > > + items: > > > + - const: apple,aic > > > > However weird it may seem, Apple is not in the file > > Documentation/devicetree/bindings/vendor-prefixes.yaml > > > > (I think it's weird because I remember clearly that they have been > > using device tree for PPC since ages.) > > > > Could you add this 2-liner to that file and send it directly to > > DT binding maintainers as a single patch as a preparation? > > Choosing the vendor prefix here is going to be a little tricky > and non-obvious. > > Background: > > Traditionally, it should have been the stock ticker symbol of the > company (clearly only publicly traded companies would be able > to produce a Unix capable computer, right?), but there were > already inconsistent: IBM used "ibm" (in small letters), Sun > used "SUNW" (in capitals) but in 2007 changed the stock ticker > symbol to "JAVA", obviously without changing the firmware bindings. > > Apple traditionally used "AAPL" (also in caps) in the device tree, > and there is one remnant of that in the M1 device tree, in the form > of the "AAPL,phandle" property in each node, which corresponds > to our "linux,phandle". (phandles were introduced as properties in > both of the flattened DT formats, .dtb and apple's own format). > There are also "AAPL,unit-string properties and some device_type > strings (AAPL,display-crossbar, AAPL,atc-dpxbar, ...) in the M1 DT, > and the CPU nodes (and only those) use "apple" in small letters > as in "apple,icestorm","ARM,v8". The other nodes tend to not have > a vendor prefix, but a lot use a subsystem name as the prefix, such > as compatible="gpio,t8101" or compatible="tempsensor,t8020". > > Since Apple are already using both the "AAPL" and the "apple" > prefix themselves, I have a bad feeling about reusing either of > them for defining the devicetree.org bindings that we add to > linux/Documentation/devicetree/bindings. The question is: if > not "apple", what else should we use here? IMO, 'AAPL' as that is what is already in use in the kernel. I don't see why it matters at all what Apple is using. It might if we used any of the ADT as-is, but I don't see that happening from what I've seen. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5656BC433DB for ; Thu, 21 Jan 2021 17:47:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0C4B22B2C for ; Thu, 21 Jan 2021 17:47:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0C4B22B2C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5vUzQ1A8UqmwvcEfE5J1+aFoPmkjLy38NLUFDyFQzQU=; b=ikNytjsCungXZpQJ3QIRML32a WKcERG+R3kuTKt7Cb9FUw7SKLC3gQW8JrtjlHGlYCa3cxJnHsSbAYzqYvn+wQXB5i1aaarDR/r7nr tDlKKvxNeQrntXThPYjuPRuAIWehgVQ1QEAped+BW82ZTx9ecNRd5l4ywkWzxBsU0XJ10MEctZYlP OoBCoBwThvGl53uqefG0p+mx39JS5K1AII8U2bS0uSF0mJTa26eViR5tl0i1XFkggx1BCrSGH9KCp j8qkRwvKqwavO4gn25FbEi8eelG2Yb2inQQwqqs8f87FZnCOdsKrYgvrrB1xQUx3rdtXApPzVcKGq bB54H4KNQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2e26-0005Zg-Gr; Thu, 21 Jan 2021 17:46:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2e23-0005Yw-EU for linux-arm-kernel@lists.infradead.org; Thu, 21 Jan 2021 17:46:09 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 51DBC23A24 for ; Thu, 21 Jan 2021 17:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611251166; bh=8Vgfa2YyRq9M4HMsdg2N5RVEwQqUfKMIoedhRicA3i8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bkWwKqyDQSQzUF6c3Ef+beGqDZgdJ+B0m3wmkPCJ4O3ZYxcMtFZj3Iag4w3ZAH+48 +ROPQCn1WTVgOXiIxKphyFKnFnQnFLr0GakCHkSxPb7WtdA9laaYWfnB0v+huoVDLe H94YYxtTu5voA/u+stvcD0aeJoKeEuEMycFpPhUr4I32wg1G6NXW9F28Kpk3QQP9I7 CmXDVQ8BF3BpZKg6G3YynU5QNWyRKDdNAyq0N98XKUVi0I9oFnMBWPdHQrwibqOcrO XwUbGTWE13Mh3SbVYfjdSFnSVS3vX4j6EWl4SjkibF9Wy58a4F953+ucZRDEer6AAY MkcZEPrL9zUzg== Received: by mail-ej1-f50.google.com with SMTP id ox12so3867612ejb.2 for ; Thu, 21 Jan 2021 09:46:06 -0800 (PST) X-Gm-Message-State: AOAM533IuyMlKkXporfZskdkfImeXXf9SYRTgzz3X3WOgvGOVtKvZyDP RErmPq+77vBYO1QkeQua65ph99pH3cEpE9B3wA== X-Google-Smtp-Source: ABdhPJxZ6w3DGy8e6iuFR3womYGkTwr2xd6oYATYjCw5hfVyz7Ge7r8p5AKFVrANgIpFc03gZIpusPNihpwj6i4MQOY= X-Received: by 2002:a17:906:25c4:: with SMTP id n4mr395803ejb.359.1611251164737; Thu, 21 Jan 2021 09:46:04 -0800 (PST) MIME-Version: 1.0 References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-5-mohamed.mediouni@caramail.com> In-Reply-To: From: Rob Herring Date: Thu, 21 Jan 2021 11:45:51 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 4/7] irqchip/apple-aic: Add support for Apple AIC To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_124608_246384_E74DAD62 X-CRM114-Status: GOOD ( 26.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Marc Zyngier , Linus Walleij , Hector Martin , "linux-kernel@vger.kernel.org" , Catalin Marinas , Mohamed Mediouni , Will Deacon , Linux ARM , Stan Skowronek Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 21, 2021 at 4:38 AM Arnd Bergmann wrote: > > On Thu, Jan 21, 2021 at 10:48 AM Linus Walleij wrote: > > > > Hi Mohamed, > > > > thanks for your patch! > > > > On Wed, Jan 20, 2021 at 2:31 PM Mohamed Mediouni > > wrote: > > > > > +properties: > > > + compatible: > > > + items: > > > + - const: apple,aic > > > > However weird it may seem, Apple is not in the file > > Documentation/devicetree/bindings/vendor-prefixes.yaml > > > > (I think it's weird because I remember clearly that they have been > > using device tree for PPC since ages.) > > > > Could you add this 2-liner to that file and send it directly to > > DT binding maintainers as a single patch as a preparation? > > Choosing the vendor prefix here is going to be a little tricky > and non-obvious. > > Background: > > Traditionally, it should have been the stock ticker symbol of the > company (clearly only publicly traded companies would be able > to produce a Unix capable computer, right?), but there were > already inconsistent: IBM used "ibm" (in small letters), Sun > used "SUNW" (in capitals) but in 2007 changed the stock ticker > symbol to "JAVA", obviously without changing the firmware bindings. > > Apple traditionally used "AAPL" (also in caps) in the device tree, > and there is one remnant of that in the M1 device tree, in the form > of the "AAPL,phandle" property in each node, which corresponds > to our "linux,phandle". (phandles were introduced as properties in > both of the flattened DT formats, .dtb and apple's own format). > There are also "AAPL,unit-string properties and some device_type > strings (AAPL,display-crossbar, AAPL,atc-dpxbar, ...) in the M1 DT, > and the CPU nodes (and only those) use "apple" in small letters > as in "apple,icestorm","ARM,v8". The other nodes tend to not have > a vendor prefix, but a lot use a subsystem name as the prefix, such > as compatible="gpio,t8101" or compatible="tempsensor,t8020". > > Since Apple are already using both the "AAPL" and the "apple" > prefix themselves, I have a bad feeling about reusing either of > them for defining the devicetree.org bindings that we add to > linux/Documentation/devicetree/bindings. The question is: if > not "apple", what else should we use here? IMO, 'AAPL' as that is what is already in use in the kernel. I don't see why it matters at all what Apple is using. It might if we used any of the ADT as-is, but I don't see that happening from what I've seen. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel