From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32E8FC64E7B for ; Tue, 1 Dec 2020 17:38:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3D0F20671 for ; Tue, 1 Dec 2020 17:38:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="q7gvXsO8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392179AbgLARht (ORCPT ); Tue, 1 Dec 2020 12:37:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:50888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391945AbgLARht (ORCPT ); Tue, 1 Dec 2020 12:37:49 -0500 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F10C21D42 for ; Tue, 1 Dec 2020 17:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606844227; bh=KNAM6f9lqa9mSdVyTIG/dKQEu1sW8SSDpknGMUKbCiU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=q7gvXsO8ykqAn2xVepDAm7HMlbTj1GN5iniIENiosDRNoP34C9CXV2n19OssOrOSf zrHyfvybHLN4CfnLGsVrl2JcsaJ+CdjwlOBwLTkB41lyPHgC9pllif5zp7zhSV4eOu N50+hBxxWoZ6tlmxD6bJrD1Hh6WkQ4KIF5fOnMpg= Received: by mail-ej1-f54.google.com with SMTP id x16so5814239ejj.7 for ; Tue, 01 Dec 2020 09:37:07 -0800 (PST) X-Gm-Message-State: AOAM5321luAWYhACxtM2aY33PdtL1di+ynP5N5Kv1QJbN17KDBGGZlZo RqfO2RBV4ANoebQk+iu6hAmZbiBIwJs7ZPahPQ== X-Google-Smtp-Source: ABdhPJxR2ypWVHPbsoaZHQu3SRgRb3mnZE4SCBgSJTl1wFd4t4AYEIvkGKfVCSCuJyrRSxZoQsFWoEqw9dgY/cytRY4= X-Received: by 2002:a17:906:c20f:: with SMTP id d15mr4059120ejz.341.1606844225944; Tue, 01 Dec 2020 09:37:05 -0800 (PST) MIME-Version: 1.0 References: <1606746513-30909-1-git-send-email-kevin3.tang@gmail.com> <1606746513-30909-2-git-send-email-kevin3.tang@gmail.com> In-Reply-To: From: Rob Herring Date: Tue, 1 Dec 2020 10:36:54 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/6] dt-bindings: display: add Unisoc's drm master bindings To: Kevin Tang Cc: Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Daniel Vetter , Mark Rutland , Orson Zhai , Lyra Zhang , "linux-kernel@vger.kernel.org" , dri-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 1, 2020 at 12:36 AM Kevin Tang wrote: > > Hi Rob > > Rob Herring =E4=BA=8E2020=E5=B9=B412=E6=9C=881=E6=97= =A5=E5=91=A8=E4=BA=8C =E4=B8=8A=E5=8D=884:29=E5=86=99=E9=81=93=EF=BC=9A > > > > On Mon, Nov 30, 2020 at 7:28 AM Kevin Tang wrot= e: > > > > > > From: Kevin Tang > > > > Once again, DT patches must Cc the DT list if you want them reviewed. > Ok, i will add DT list to my Cc list. > > > > > > > > The Unisoc DRM master device is a virtual device needed to list all > > > DPU devices or other display interface nodes that comprise the > > > graphics subsystem > > > > > > Cc: Orson Zhai > > > Cc: Chunyan Zhang > > > Signed-off-by: Kevin Tang > > > --- > > > .../display/sprd/sprd,display-subsystem.yaml | 39 ++++++++++++= ++++++++++ > > > 1 file changed, 39 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/sprd/sp= rd,display-subsystem.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,disp= lay-subsystem.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,di= splay-subsystem.yaml > > > new file mode 100644 > > > index 0000000..9487a39 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/sprd/sprd,display-sub= system.yaml > > > @@ -0,0 +1,39 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/sprd/sprd,display-subsyst= em.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Unisoc DRM master device > > > + > > > +maintainers: > > > + - Kevin Tang > > > + > > > +description: | > > > + The Unisoc DRM master device is a virtual device needed to list al= l > > > + DPU devices or other display interface nodes that comprise the > > > + graphics subsystem. > > > + > > > +properties: > > > + compatible: > > > + const: sprd,display-subsystem > > > > As I said before, we try to avoid these virtual nodes. Make the DRM > > driver bind to the DPU node. > > > > The case where this might be needed is if you have h/w that's a > > mixture of shared and discrete blocks. I don't see anything here > > matching that. > > This is how I understand this sentence: "h/w that's a mixture of shared a= nd discrete blocks" > We have multiple display controllers and corresponding physical interface= s, typical dual-screen display scenario > E.g: > 1. dpu0 and dpu1 both binding to DSI for dual mipi-dsi display; > 2. dpu0 binding to DSI for primary display, and dpu1 binding to DP for ex= ternal display; > > It looks like this: > dpu0------>MIPI-DSI------>DPHY/CPHY Combo------>Panel0 > ^ > ----------------| > | > dpu1------>DisplayPort------>PHY------>Panel1 > > For DTS like this: > display-subsystem { > compatible =3D "sprd,display-subsystem"; > ports =3D <&dpu0_out>, <&dpu1_out>; > }; Yeah, this would be one such case. Just make this scenario clear in commit message. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DB4CC64E7A for ; Tue, 1 Dec 2020 17:37:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A92CB20671 for ; Tue, 1 Dec 2020 17:37:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="q7gvXsO8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A92CB20671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0EC3B89BB2; Tue, 1 Dec 2020 17:37:10 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2FC5D89BB2 for ; Tue, 1 Dec 2020 17:37:08 +0000 (UTC) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 895F62168B for ; Tue, 1 Dec 2020 17:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606844227; bh=KNAM6f9lqa9mSdVyTIG/dKQEu1sW8SSDpknGMUKbCiU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=q7gvXsO8ykqAn2xVepDAm7HMlbTj1GN5iniIENiosDRNoP34C9CXV2n19OssOrOSf zrHyfvybHLN4CfnLGsVrl2JcsaJ+CdjwlOBwLTkB41lyPHgC9pllif5zp7zhSV4eOu N50+hBxxWoZ6tlmxD6bJrD1Hh6WkQ4KIF5fOnMpg= Received: by mail-ej1-f47.google.com with SMTP id d17so5811478ejy.9 for ; Tue, 01 Dec 2020 09:37:07 -0800 (PST) X-Gm-Message-State: AOAM532af+snxZ9x1iJ40cZg9drrkljeI7PqbELkUPSVup4SBb2W0gXX BL2dw1EKDkJ5gohuEzgUFWB5xJoAC+rYQp5dGQ== X-Google-Smtp-Source: ABdhPJxR2ypWVHPbsoaZHQu3SRgRb3mnZE4SCBgSJTl1wFd4t4AYEIvkGKfVCSCuJyrRSxZoQsFWoEqw9dgY/cytRY4= X-Received: by 2002:a17:906:c20f:: with SMTP id d15mr4059120ejz.341.1606844225944; Tue, 01 Dec 2020 09:37:05 -0800 (PST) MIME-Version: 1.0 References: <1606746513-30909-1-git-send-email-kevin3.tang@gmail.com> <1606746513-30909-2-git-send-email-kevin3.tang@gmail.com> In-Reply-To: From: Rob Herring Date: Tue, 1 Dec 2020 10:36:54 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/6] dt-bindings: display: add Unisoc's drm master bindings To: Kevin Tang X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , Lyra Zhang , "linux-kernel@vger.kernel.org" , dri-devel , Orson Zhai , Sean Paul Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCBEZWMgMSwgMjAyMCBhdCAxMjozNiBBTSBLZXZpbiBUYW5nIDxrZXZpbjMudGFuZ0Bn bWFpbC5jb20+IHdyb3RlOgo+Cj4gSGkgUm9iCj4KPiBSb2IgSGVycmluZyA8cm9iaCtkdEBrZXJu ZWwub3JnPiDkuo4yMDIw5bm0MTLmnIgx5pel5ZGo5LqMIOS4iuWNiDQ6MjnlhpnpgZPvvJoKPiA+ Cj4gPiBPbiBNb24sIE5vdiAzMCwgMjAyMCBhdCA3OjI4IEFNIEtldmluIFRhbmcgPGtldmluMy50 YW5nQGdtYWlsLmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IEZyb206IEtldmluIFRhbmcgPGtldmlu LnRhbmdAdW5pc29jLmNvbT4KPiA+Cj4gPiBPbmNlIGFnYWluLCBEVCBwYXRjaGVzIG11c3QgQ2Mg dGhlIERUIGxpc3QgaWYgeW91IHdhbnQgdGhlbSByZXZpZXdlZC4KPiBPaywgaSB3aWxsIGFkZCBE VCBsaXN0IHRvIG15IENjIGxpc3QuCj4gPgo+ID4gPgo+ID4gPiBUaGUgVW5pc29jIERSTSBtYXN0 ZXIgZGV2aWNlIGlzIGEgdmlydHVhbCBkZXZpY2UgbmVlZGVkIHRvIGxpc3QgYWxsCj4gPiA+IERQ VSBkZXZpY2VzIG9yIG90aGVyIGRpc3BsYXkgaW50ZXJmYWNlIG5vZGVzIHRoYXQgY29tcHJpc2Ug dGhlCj4gPiA+IGdyYXBoaWNzIHN1YnN5c3RlbQo+ID4gPgo+ID4gPiBDYzogT3Jzb24gWmhhaSA8 b3Jzb256aGFpQGdtYWlsLmNvbT4KPiA+ID4gQ2M6IENodW55YW4gWmhhbmcgPHpoYW5nLmx5cmFA Z21haWwuY29tPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBLZXZpbiBUYW5nIDxrZXZpbi50YW5nQHVu aXNvYy5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgLi4uL2Rpc3BsYXkvc3ByZC9zcHJkLGRpc3BsYXkt c3Vic3lzdGVtLnlhbWwgICAgICAgfCAzOSArKysrKysrKysrKysrKysrKysrKysrCj4gPiA+ICAx IGZpbGUgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKQo+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0 IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3NwcmQvc3ByZCxkaXNw bGF5LXN1YnN5c3RlbS55YW1sCj4gPiA+Cj4gPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9zcHJkL3NwcmQsZGlzcGxheS1zdWJzeXN0ZW0u eWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3NwcmQvc3By ZCxkaXNwbGF5LXN1YnN5c3RlbS55YW1sCj4gPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gPiA+ IGluZGV4IDAwMDAwMDAuLjk0ODdhMzkKPiA+ID4gLS0tIC9kZXYvbnVsbAo+ID4gPiArKysgYi9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9zcHJkL3NwcmQsZGlzcGxh eS1zdWJzeXN0ZW0ueWFtbAo+ID4gPiBAQCAtMCwwICsxLDM5IEBACj4gPiA+ICsjIFNQRFgtTGlj ZW5zZS1JZGVudGlmaWVyOiAoR1BMLTIuMC1vbmx5IE9SIEJTRC0yLUNsYXVzZSkKPiA+ID4gKyVZ QU1MIDEuMgo+ID4gPiArLS0tCj4gPiA+ICskaWQ6IGh0dHA6Ly9kZXZpY2V0cmVlLm9yZy9zY2hl bWFzL2Rpc3BsYXkvc3ByZC9zcHJkLGRpc3BsYXktc3Vic3lzdGVtLnlhbWwjCj4gPiA+ICskc2No ZW1hOiBodHRwOi8vZGV2aWNldHJlZS5vcmcvbWV0YS1zY2hlbWFzL2NvcmUueWFtbCMKPiA+ID4g Kwo+ID4gPiArdGl0bGU6IFVuaXNvYyBEUk0gbWFzdGVyIGRldmljZQo+ID4gPiArCj4gPiA+ICtt YWludGFpbmVyczoKPiA+ID4gKyAgLSBLZXZpbiBUYW5nIDxrZXZpbi50YW5nQHVuaXNvYy5jb20+ Cj4gPiA+ICsKPiA+ID4gK2Rlc2NyaXB0aW9uOiB8Cj4gPiA+ICsgIFRoZSBVbmlzb2MgRFJNIG1h c3RlciBkZXZpY2UgaXMgYSB2aXJ0dWFsIGRldmljZSBuZWVkZWQgdG8gbGlzdCBhbGwKPiA+ID4g KyAgRFBVIGRldmljZXMgb3Igb3RoZXIgZGlzcGxheSBpbnRlcmZhY2Ugbm9kZXMgdGhhdCBjb21w cmlzZSB0aGUKPiA+ID4gKyAgZ3JhcGhpY3Mgc3Vic3lzdGVtLgo+ID4gPiArCj4gPiA+ICtwcm9w ZXJ0aWVzOgo+ID4gPiArICBjb21wYXRpYmxlOgo+ID4gPiArICAgIGNvbnN0OiBzcHJkLGRpc3Bs YXktc3Vic3lzdGVtCj4gPgo+ID4gQXMgSSBzYWlkIGJlZm9yZSwgd2UgdHJ5IHRvIGF2b2lkIHRo ZXNlIHZpcnR1YWwgbm9kZXMuIE1ha2UgdGhlIERSTQo+ID4gZHJpdmVyIGJpbmQgdG8gdGhlIERQ VSBub2RlLgo+ID4KPiA+IFRoZSBjYXNlIHdoZXJlIHRoaXMgbWlnaHQgYmUgbmVlZGVkIGlzIGlm IHlvdSBoYXZlIGgvdyB0aGF0J3MgYQo+ID4gbWl4dHVyZSBvZiBzaGFyZWQgYW5kIGRpc2NyZXRl IGJsb2Nrcy4gSSBkb24ndCBzZWUgYW55dGhpbmcgaGVyZQo+ID4gbWF0Y2hpbmcgdGhhdC4KPgo+ IFRoaXMgaXMgaG93IEkgdW5kZXJzdGFuZCB0aGlzIHNlbnRlbmNlOiAiaC93IHRoYXQncyBhIG1p eHR1cmUgb2Ygc2hhcmVkIGFuZCBkaXNjcmV0ZSBibG9ja3MiCj4gV2UgaGF2ZSBtdWx0aXBsZSBk aXNwbGF5IGNvbnRyb2xsZXJzIGFuZCBjb3JyZXNwb25kaW5nIHBoeXNpY2FsIGludGVyZmFjZXMs IHR5cGljYWwgZHVhbC1zY3JlZW4gZGlzcGxheSBzY2VuYXJpbwo+IEUuZzoKPiAxLiBkcHUwIGFu ZCBkcHUxIGJvdGggYmluZGluZyB0byBEU0kgZm9yIGR1YWwgbWlwaS1kc2kgZGlzcGxheTsKPiAy LiBkcHUwIGJpbmRpbmcgdG8gRFNJIGZvciBwcmltYXJ5IGRpc3BsYXksIGFuZCBkcHUxIGJpbmRp bmcgdG8gRFAgZm9yIGV4dGVybmFsIGRpc3BsYXk7Cj4KPiBJdCBsb29rcyBsaWtlIHRoaXM6Cj4g ZHB1MC0tLS0tLT5NSVBJLURTSS0tLS0tLT5EUEhZL0NQSFkgQ29tYm8tLS0tLS0+UGFuZWwwCj4g ICAgICAgICAgICAgICAgICAgICAgICAgXgo+ICAgICAtLS0tLS0tLS0tLS0tLS0tfAo+ICAgICB8 Cj4gZHB1MS0tLS0tLT5EaXNwbGF5UG9ydC0tLS0tLT5QSFktLS0tLS0+UGFuZWwxCj4KPiBGb3Ig RFRTIGxpa2UgdGhpczoKPiBkaXNwbGF5LXN1YnN5c3RlbSB7Cj4gY29tcGF0aWJsZSA9ICJzcHJk LGRpc3BsYXktc3Vic3lzdGVtIjsKPiBwb3J0cyA9IDwmZHB1MF9vdXQ+LCA8JmRwdTFfb3V0PjsK PiB9OwoKWWVhaCwgdGhpcyB3b3VsZCBiZSBvbmUgc3VjaCBjYXNlLiBKdXN0IG1ha2UgdGhpcyBz Y2VuYXJpbyBjbGVhciBpbgpjb21taXQgbWVzc2FnZS4KClJvYgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK