From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7007C433DB for ; Tue, 26 Jan 2021 13:45:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62860229C9 for ; Tue, 26 Jan 2021 13:45:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405162AbhAZNog (ORCPT ); Tue, 26 Jan 2021 08:44:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:46498 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404748AbhAZNnm (ORCPT ); Tue, 26 Jan 2021 08:43:42 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7816A2223D; Tue, 26 Jan 2021 13:43:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611668581; bh=gZmSYgI/wa2/JnuwHcpAdHOfBP02jfH9AVoTNyQbgPc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nWwXoa8f5j/f3gLzJfb7C9m7/sFDrLHniZrrgAr3k2Zu3c66CVjRNMxSWU5xSb82l xkhszdemIvKTLDQEn/CA3Prn09unXNPsfylBVtz0NWF3xhFUXP6/xNwbeEb4x2nHAm iEauYN0wy4xpv3vvbtmFWBixLfgryqrihSe9YIGeNFLbszkFD3WISoI/eGC8gN77VG WP4VXgt+jg3IslYG6sSXafeRZvIxj6IdlyD/5lzQ6XslXEZR/dLn9wP5PzVInhrUds 8U6PrAPO0jaaVWObpmUklbMTVpVSiUKZG5E1AhSmm3pWa2M4cGUKOq5gdYy0zEysqE mKV/13nCeXk+Q== Received: by mail-ed1-f50.google.com with SMTP id s11so19790292edd.5; Tue, 26 Jan 2021 05:43:01 -0800 (PST) X-Gm-Message-State: AOAM531ztYVgbFC7mYXKPFi4ClaRRBRgZz4lns3RNcteLNyVkKNB0CQe vZgzmJK1dZgaGHU5l0iYB/vtSIv6T7hpTadaJA== X-Google-Smtp-Source: ABdhPJyedjeaKb7Y7yFDeXhCNsA7wEgX8BmR5Dj0sgd1WrT81hG16uP3pAjOTds7G2dy9MdFeUk38Ykxu3sHpbfk3lQ= X-Received: by 2002:a50:fc04:: with SMTP id i4mr4670026edr.137.1611668580145; Tue, 26 Jan 2021 05:43:00 -0800 (PST) MIME-Version: 1.0 References: <20210125105757.661240-1-uwe@kleine-koenig.org> <9d9bb0f6-d4f4-b1b9-a4c4-786987578085@kleine-koenig.org> In-Reply-To: <9d9bb0f6-d4f4-b1b9-a4c4-786987578085@kleine-koenig.org> From: Rob Herring Date: Tue, 26 Jan 2021 07:42:48 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] cmd_dtc: Enable generation of device tree symbols To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Masahiro Yamada , Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , linux-arm-kernel , cyril@debamax.com, Arnd Bergmann , Maxime Ripard , DTML , Geert Uytterhoeven , Frank Rowand Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2021 at 1:27 AM Uwe Kleine-K=C3=B6nig wrote: > > Hello Masahiro, > > On 1/25/21 10:53 PM, Masahiro Yamada wrote: > > On Mon, Jan 25, 2021 at 8:07 PM Uwe Kleine-K=C3=B6nig wrote: > >> > >> Adding the -@ switch to dtc results in the binary devicetrees containi= ng > >> a list of symbolic references and their paths. This is necessary to > >> apply device tree overlays e.g. on Raspberry Pi as described on > >> https://www.raspberrypi.org/documentation/configuration/device-tree.md= . > >> > >> Obviously the downside of this change is an increas of the size of the > >> generated dtbs, for an arm out-of-tree build (multi_v7_defconfig): > >> > >> $ du -s arch/arm/boot/dts* > >> 101380 arch/arm/boot/dts-pre > >> 114308 arch/arm/boot/dts-post > >> > >> so this is in average an increase of 12.8% in size. > >> > >> Signed-off-by: Uwe Kleine-K=C3=B6nig > > > > > > (CCing DT ML.) > > makes sense, thanks. > > > https://www.spinics.net/lists/linux-kbuild/msg27904.html > > > > See Rob's comment: > > > > "We've already rejected doing that. Turning on '-@' can grow the dtb > > size by a significant amount which could be problematic for some > > boards." > > The patch was created after some conversation on irc which continued > after I sent the patch. I added the participating parties to Cc:. > > The (relevant) followups were: > > Geert suggested to always generate the symbols and provide a way to > strip the symbols for installation if and when they are not needed. > > Rob said: "I'm less concerned with the size increases, but rather that > labels go from purely source syntax to an ABI. I'd rather see some > decision as to which labels are enabled or not." I've also said move the arm32 dts files to family subdirectories and enable '-@' per directory. I've posted a script to do the whole thing, but I think the preference is one-by-one. This is needed anyways if we're going to start adding overlays which Viresh is working on. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04F8AC433DB for ; Tue, 26 Jan 2021 13:45:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4B5123103 for ; Tue, 26 Jan 2021 13:45:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4B5123103 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pYhmfDserwpMlevPxVgpszVpUHfOBNo3jIsvx7MWrn0=; b=O91qbYkvN2EdsGM/MUzXcaW34 Q1Y0BpSFELHDXZR18YvW9xa0wk5CfiYWSDMCO+LUw1FRjH+G3j2CpQ5GPf5D1Tx1xobZlNNdngXf2 laD+uP3J3cNwr1LYy/Ki6GwGh5zuyB3UHiR0GsQ4lqhJlpjvhE6KUezqSkidjE9lptwJzJKGeQzJ4 w9eVM3Dy3rQ7MHyjKzt2eEr32DMeIArliNrbdtC9S01nPFwRpxyGZ4rYUqP21w1322umXKbkxfy/i TIZG18On2OsqoaFDBEvVDepWjKaVA5w2C7HvuB7fjmDDdLGGFKtJKv4eNOGUVpBKWoAVBjhxwgEO3 zg53K+5Qg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4Ocx-0002Bf-2J; Tue, 26 Jan 2021 13:43:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4OcY-000207-Mp for linux-arm-kernel@lists.infradead.org; Tue, 26 Jan 2021 13:43:04 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E06F22D04 for ; Tue, 26 Jan 2021 13:43:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611668581; bh=gZmSYgI/wa2/JnuwHcpAdHOfBP02jfH9AVoTNyQbgPc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nWwXoa8f5j/f3gLzJfb7C9m7/sFDrLHniZrrgAr3k2Zu3c66CVjRNMxSWU5xSb82l xkhszdemIvKTLDQEn/CA3Prn09unXNPsfylBVtz0NWF3xhFUXP6/xNwbeEb4x2nHAm iEauYN0wy4xpv3vvbtmFWBixLfgryqrihSe9YIGeNFLbszkFD3WISoI/eGC8gN77VG WP4VXgt+jg3IslYG6sSXafeRZvIxj6IdlyD/5lzQ6XslXEZR/dLn9wP5PzVInhrUds 8U6PrAPO0jaaVWObpmUklbMTVpVSiUKZG5E1AhSmm3pWa2M4cGUKOq5gdYy0zEysqE mKV/13nCeXk+Q== Received: by mail-ed1-f43.google.com with SMTP id z22so5092418edb.9 for ; Tue, 26 Jan 2021 05:43:01 -0800 (PST) X-Gm-Message-State: AOAM530F0Q1S7nxLUD0D9r3GmiaZf/x/De4m0Cwt7p9F2pjTMV4T06Rd IXWTbLr3nWQkyPD5exj4msRf0YNl8VAf8PcKxQ== X-Google-Smtp-Source: ABdhPJyedjeaKb7Y7yFDeXhCNsA7wEgX8BmR5Dj0sgd1WrT81hG16uP3pAjOTds7G2dy9MdFeUk38Ykxu3sHpbfk3lQ= X-Received: by 2002:a50:fc04:: with SMTP id i4mr4670026edr.137.1611668580145; Tue, 26 Jan 2021 05:43:00 -0800 (PST) MIME-Version: 1.0 References: <20210125105757.661240-1-uwe@kleine-koenig.org> <9d9bb0f6-d4f4-b1b9-a4c4-786987578085@kleine-koenig.org> In-Reply-To: <9d9bb0f6-d4f4-b1b9-a4c4-786987578085@kleine-koenig.org> From: Rob Herring Date: Tue, 26 Jan 2021 07:42:48 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] cmd_dtc: Enable generation of device tree symbols To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210126_084302_969292_027AF979 X-CRM114-Status: GOOD ( 25.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , Michal Marek , Arnd Bergmann , Linux Kbuild mailing list , Masahiro Yamada , Linux Kernel Mailing List , Maxime Ripard , cyril@debamax.com, Geert Uytterhoeven , Frank Rowand , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKYW4gMjYsIDIwMjEgYXQgMToyNyBBTSBVd2UgS2xlaW5lLUvDtm5pZyA8dXdlQGts ZWluZS1rb2VuaWcub3JnPiB3cm90ZToKPgo+IEhlbGxvIE1hc2FoaXJvLAo+Cj4gT24gMS8yNS8y MSAxMDo1MyBQTSwgTWFzYWhpcm8gWWFtYWRhIHdyb3RlOgo+ID4gT24gTW9uLCBKYW4gMjUsIDIw MjEgYXQgODowNyBQTSBVd2UgS2xlaW5lLUvDtm5pZyA8dXdlQGtsZWluZS1rb2VuaWcub3JnPiB3 cm90ZToKPiA+Pgo+ID4+IEFkZGluZyB0aGUgLUAgc3dpdGNoIHRvIGR0YyByZXN1bHRzIGluIHRo ZSBiaW5hcnkgZGV2aWNldHJlZXMgY29udGFpbmluZwo+ID4+IGEgbGlzdCBvZiBzeW1ib2xpYyBy ZWZlcmVuY2VzIGFuZCB0aGVpciBwYXRocy4gVGhpcyBpcyBuZWNlc3NhcnkgdG8KPiA+PiBhcHBs eSBkZXZpY2UgdHJlZSBvdmVybGF5cyBlLmcuIG9uIFJhc3BiZXJyeSBQaSBhcyBkZXNjcmliZWQg b24KPiA+PiBodHRwczovL3d3dy5yYXNwYmVycnlwaS5vcmcvZG9jdW1lbnRhdGlvbi9jb25maWd1 cmF0aW9uL2RldmljZS10cmVlLm1kLgo+ID4+Cj4gPj4gT2J2aW91c2x5IHRoZSBkb3duc2lkZSBv ZiB0aGlzIGNoYW5nZSBpcyBhbiBpbmNyZWFzIG9mIHRoZSBzaXplIG9mIHRoZQo+ID4+IGdlbmVy YXRlZCBkdGJzLCBmb3IgYW4gYXJtIG91dC1vZi10cmVlIGJ1aWxkIChtdWx0aV92N19kZWZjb25m aWcpOgo+ID4+Cj4gPj4gICAgICAgICAgJCBkdSAtcyBhcmNoL2FybS9ib290L2R0cyoKPiA+PiAg ICAgICAgICAxMDEzODAgIGFyY2gvYXJtL2Jvb3QvZHRzLXByZQo+ID4+ICAgICAgICAgIDExNDMw OCAgYXJjaC9hcm0vYm9vdC9kdHMtcG9zdAo+ID4+Cj4gPj4gc28gdGhpcyBpcyBpbiBhdmVyYWdl IGFuIGluY3JlYXNlIG9mIDEyLjglIGluIHNpemUuCj4gPj4KPiA+PiBTaWduZWQtb2ZmLWJ5OiBV d2UgS2xlaW5lLUvDtm5pZyA8dXdlQGtsZWluZS1rb2VuaWcub3JnPgo+ID4KPiA+Cj4gPiAoQ0Np bmcgRFQgTUwuKQo+Cj4gbWFrZXMgc2Vuc2UsIHRoYW5rcy4KPgo+ID4gaHR0cHM6Ly93d3cuc3Bp bmljcy5uZXQvbGlzdHMvbGludXgta2J1aWxkL21zZzI3OTA0Lmh0bWwKPiA+Cj4gPiBTZWUgUm9i J3MgY29tbWVudDoKPiA+Cj4gPiAiV2UndmUgYWxyZWFkeSByZWplY3RlZCBkb2luZyB0aGF0LiBU dXJuaW5nIG9uICctQCcgY2FuIGdyb3cgdGhlIGR0Ygo+ID4gc2l6ZSBieSBhIHNpZ25pZmljYW50 IGFtb3VudCB3aGljaCBjb3VsZCBiZSBwcm9ibGVtYXRpYyBmb3Igc29tZQo+ID4gYm9hcmRzLiIK Pgo+IFRoZSBwYXRjaCB3YXMgY3JlYXRlZCBhZnRlciBzb21lIGNvbnZlcnNhdGlvbiBvbiBpcmMg d2hpY2ggY29udGludWVkCj4gYWZ0ZXIgSSBzZW50IHRoZSBwYXRjaC4gSSBhZGRlZCB0aGUgcGFy dGljaXBhdGluZyBwYXJ0aWVzIHRvIENjOi4KPgo+IFRoZSAocmVsZXZhbnQpIGZvbGxvd3VwcyB3 ZXJlOgo+Cj4gR2VlcnQgc3VnZ2VzdGVkIHRvIGFsd2F5cyBnZW5lcmF0ZSB0aGUgc3ltYm9scyBh bmQgcHJvdmlkZSBhIHdheSB0bwo+IHN0cmlwIHRoZSBzeW1ib2xzIGZvciBpbnN0YWxsYXRpb24g aWYgYW5kIHdoZW4gdGhleSBhcmUgbm90IG5lZWRlZC4KPgo+IFJvYiBzYWlkOiAiSSdtIGxlc3Mg Y29uY2VybmVkIHdpdGggdGhlIHNpemUgaW5jcmVhc2VzLCBidXQgcmF0aGVyIHRoYXQKPiBsYWJl bHMgZ28gZnJvbSBwdXJlbHkgc291cmNlIHN5bnRheCB0byBhbiBBQkkuIEknZCByYXRoZXIgc2Vl IHNvbWUKPiBkZWNpc2lvbiBhcyB0byB3aGljaCBsYWJlbHMgYXJlIGVuYWJsZWQgb3Igbm90LiIK CkkndmUgYWxzbyBzYWlkIG1vdmUgdGhlIGFybTMyIGR0cyBmaWxlcyB0byBmYW1pbHkgc3ViZGly ZWN0b3JpZXMgYW5kCmVuYWJsZSAnLUAnIHBlciBkaXJlY3RvcnkuIEkndmUgcG9zdGVkIGEgc2Ny aXB0IHRvIGRvIHRoZSB3aG9sZSB0aGluZywKYnV0IEkgdGhpbmsgdGhlIHByZWZlcmVuY2UgaXMg b25lLWJ5LW9uZS4gVGhpcyBpcyBuZWVkZWQgYW55d2F5cyBpZgp3ZSdyZSBnb2luZyB0byBzdGFy dCBhZGRpbmcgb3ZlcmxheXMgd2hpY2ggVmlyZXNoIGlzIHdvcmtpbmcgb24uCgpSb2IKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK