From: Rob Herring <robherring2@gmail.com> To: Douglas Anderson <dianders@chromium.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, John Youn <johnyoun@synopsys.com>, Felipe Balbi <balbi@ti.com>, Chris Zhong <zyw@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>, Julius Werner <jwerner@chromium.org>, Andrew Bresticker <abrestic@chromium.org>, Alexandru Stan <amstan@chromium.org>, lyz@rock-chips.com, linux-rockchip@lists.infradead.org, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Kever Yang <kever.yang@rock-chips.com>, Paul Zimmerman <paulz@synopsys.com>, Gregory Herrero <gregory.herrero@intel.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 2/3] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB Date: Tue, 23 Jun 2015 09:17:23 -0500 [thread overview] Message-ID: <CAL_JsqJT42GhY45FWY5G=450zxSRVLHu36_O1tPkTdH39JeEcw@mail.gmail.com> (raw) In-Reply-To: <1435017144-2971-3-git-send-email-dianders@chromium.org> On Mon, Jun 22, 2015 at 6:52 PM, Douglas Anderson <dianders@chromium.org> wrote: > Some SoCs with a dwc2 USB controller may need to keep the PHY on to > support remote wakeup. Allow specifying this as a device tree > property. I find it hard to believe that any host can support wake-up without the PHY. Does this really need to be conditional? Perhaps other cases are just always-on or remote wake-up has not been tested. Assuming the PHY was provided with the knowledge that remote wakeup is enabled, it would be able to figure out within its driver how to support that. Unfortunately the generic PHY framework is a completely lacking in its ability to support protocol specific features like this or other USB PHY features like Vbus detect or charger detection. Rob > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > Documentation/devicetree/bindings/usb/dwc2.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt > index fd132cb..84d258d 100644 > --- a/Documentation/devicetree/bindings/usb/dwc2.txt > +++ b/Documentation/devicetree/bindings/usb/dwc2.txt > @@ -17,6 +17,9 @@ Refer to clk/clock-bindings.txt for generic clock consumer properties > Optional properties: > - phys: phy provider specifier > - phy-names: shall be "usb2-phy" > +- snps,need-phy-for-wake: if present indicates that the phy needs to be left > + on for remote wakeup during suspend. > + > Refer to phy/phy-bindings.txt for generic phy consumer properties > - dr_mode: shall be one of "host", "peripheral" and "otg" > Refer to usb/generic.txt > @@ -35,4 +38,5 @@ Example: > clock-names = "otg"; > phys = <&usbphy>; > phy-names = "usb2-phy"; > + snps,need-phy-for-wake; > }; > -- > 2.4.3.573.g4eafbef >
next prev parent reply other threads:[~2015-06-23 14:17 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-22 23:52 [PATCH 0/3] dwc2 patches to allow wakeup on Rockchip rk3288 Douglas Anderson 2015-06-22 23:52 ` Douglas Anderson 2015-06-22 23:52 ` [PATCH 1/3] USB: Export usb_wakeup_enabled_descendants() Douglas Anderson 2015-06-22 23:52 ` Douglas Anderson 2015-06-22 23:52 ` [PATCH 2/3] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB Douglas Anderson 2015-06-22 23:52 ` Douglas Anderson 2015-06-23 14:17 ` Rob Herring [this message] 2015-06-23 15:12 ` Doug Anderson 2015-06-23 15:12 ` Doug Anderson 2015-06-22 23:52 ` [PATCH 3/3] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled Douglas Anderson 2015-06-22 23:52 ` Douglas Anderson 2015-07-06 17:48 ` [PATCH 0/3] dwc2 patches to allow wakeup on Rockchip rk3288 Felipe Balbi 2015-07-06 17:48 ` Felipe Balbi 2015-07-06 18:06 ` Doug Anderson 2015-07-06 18:06 ` Doug Anderson 2015-07-06 18:12 ` Felipe Balbi 2015-07-06 18:12 ` Felipe Balbi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAL_JsqJT42GhY45FWY5G=450zxSRVLHu36_O1tPkTdH39JeEcw@mail.gmail.com' \ --to=robherring2@gmail.com \ --cc=abrestic@chromium.org \ --cc=amstan@chromium.org \ --cc=balbi@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=galak@codeaurora.org \ --cc=gregkh@linuxfoundation.org \ --cc=gregory.herrero@intel.com \ --cc=heiko@sntech.de \ --cc=ijc+devicetree@hellion.org.uk \ --cc=johnyoun@synopsys.com \ --cc=jwerner@chromium.org \ --cc=kever.yang@rock-chips.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=lyz@rock-chips.com \ --cc=mark.rutland@arm.com \ --cc=paulz@synopsys.com \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ --cc=zyw@rock-chips.com \ --subject='Re: [PATCH 2/3] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.