From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965428AbdGTOG1 (ORCPT ); Thu, 20 Jul 2017 10:06:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:50076 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965399AbdGTOGY (ORCPT ); Thu, 20 Jul 2017 10:06:24 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8589822C96 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org MIME-Version: 1.0 In-Reply-To: <20170720081508.33563afe@vento.lan> References: <20170718214339.7774-33-robh@kernel.org> <564a6768-3b23-6dc7-ecb5-cb4f4359b633@samsung.com> <20170720081508.33563afe@vento.lan> From: Rob Herring Date: Thu, 20 Jul 2017 09:06:01 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] media: Convert to using %pOF instead of full_name To: Mauro Carvalho Chehab Cc: Sylwester Nawrocki , Frank Rowand , "linux-media@vger.kernel.org" , Mauro Carvalho Chehab , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Kyungmin Park , Andrzej Hajda , "Lad, Prabhakar" , Songjun Wu , Kukjin Kim , Krzysztof Kozlowski , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Matthias Brugger , Laurent Pinchart , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Guennadi Liakhovetski , Hyun Kwon , Michal Simek , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , linux-mediatek@lists.infradead.org, "open list:MEDIA DRIVERS FOR RENESAS - FCP" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 20, 2017 at 6:15 AM, Mauro Carvalho Chehab wrote: > Em Wed, 19 Jul 2017 11:02:01 -0500 > Rob Herring escreveu: > >> On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki >> wrote: >> > On 07/18/2017 11:43 PM, Rob Herring wrote: >> >> Now that we have a custom printf format specifier, convert users of >> >> full_name to use %pOF instead. This is preparation to remove storing >> >> of the full path string for each node. >> >> >> >> Signed-off-by: Rob Herring >> > >> >> --- >> >> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 3 +- >> >> drivers/media/i2c/s5k5baf.c | 7 ++-- >> >> drivers/media/platform/am437x/am437x-vpfe.c | 4 +- >> >> drivers/media/platform/atmel/atmel-isc.c | 4 +- >> >> drivers/media/platform/davinci/vpif_capture.c | 16 ++++---- >> >> drivers/media/platform/exynos4-is/fimc-is.c | 8 ++-- >> >> drivers/media/platform/exynos4-is/fimc-lite.c | 3 +- >> >> drivers/media/platform/exynos4-is/media-dev.c | 8 ++-- >> >> drivers/media/platform/exynos4-is/mipi-csis.c | 4 +- >> >> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 +-- >> >> drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 8 ++-- >> >> drivers/media/platform/omap3isp/isp.c | 8 ++-- >> >> drivers/media/platform/pxa_camera.c | 2 +- >> >> drivers/media/platform/rcar-vin/rcar-core.c | 4 +- >> >> drivers/media/platform/soc_camera/soc_camera.c | 6 +-- >> >> drivers/media/platform/xilinx/xilinx-vipp.c | 52 +++++++++++++------------- >> >> drivers/media/v4l2-core/v4l2-async.c | 4 +- >> >> drivers/media/v4l2-core/v4l2-clk.c | 3 +- >> >> include/media/v4l2-clk.h | 4 +- >> >> 19 files changed, 71 insertions(+), 83 deletions(-) >> > >> >> diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c >> >> index ac4704388920..9233ad0b1b6b 100644 >> >> --- a/drivers/media/platform/xilinx/xilinx-vipp.c >> >> +++ b/drivers/media/platform/xilinx/xilinx-vipp.c >> > >> >> @@ -144,9 +144,8 @@ static int xvip_graph_build_one(struct xvip_composite_device *xdev, >> >> remote = ent->entity; >> >> >> >> if (link.remote_port >= remote->num_pads) { >> >> - dev_err(xdev->dev, "invalid port number %u on %s\n", >> >> - link.remote_port, >> >> - to_of_node(link.remote_node)->full_name); >> >> + dev_err(xdev->dev, "invalid port number %u on %pOF\n", >> >> + link.remote_port, link.remote_node); >> > >> > Shouldn't there be to_of_node(link.remote_node) instead of link.remote_node ? >> >> Humm, yes. I thought I fixed that. > > After such fix, I'm OK with this patch. I'll send a new version. I think I'll send a revert of the referenced commit. It won't apply cleanly, but at least it will capture the change in behavior and why it was wrong. > Are you planning to apply it on your tree, or via the media one? > > I guess it is probably better to apply via media, in order to avoid > conflicts with other changes. Yes, you can take it. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] media: Convert to using %pOF instead of full_name Date: Thu, 20 Jul 2017 09:06:01 -0500 Message-ID: References: <20170718214339.7774-33-robh@kernel.org> <564a6768-3b23-6dc7-ecb5-cb4f4359b633@samsung.com> <20170720081508.33563afe@vento.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20170720081508.33563afe@vento.lan> Sender: linux-samsung-soc-owner@vger.kernel.org To: Mauro Carvalho Chehab Cc: Sylwester Nawrocki , Frank Rowand , "linux-media@vger.kernel.org" , Mauro Carvalho Chehab , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Kyungmin Park , Andrzej Hajda , "Lad, Prabhakar" , Songjun Wu , Kukjin Kim , Krzysztof Kozlowski , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Matthias Brugger , Laurent Pinchart List-Id: devicetree@vger.kernel.org On Thu, Jul 20, 2017 at 6:15 AM, Mauro Carvalho Chehab wrote: > Em Wed, 19 Jul 2017 11:02:01 -0500 > Rob Herring escreveu: > >> On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki >> wrote: >> > On 07/18/2017 11:43 PM, Rob Herring wrote: >> >> Now that we have a custom printf format specifier, convert users of >> >> full_name to use %pOF instead. This is preparation to remove storing >> >> of the full path string for each node. >> >> >> >> Signed-off-by: Rob Herring >> > >> >> --- >> >> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 3 +- >> >> drivers/media/i2c/s5k5baf.c | 7 ++-- >> >> drivers/media/platform/am437x/am437x-vpfe.c | 4 +- >> >> drivers/media/platform/atmel/atmel-isc.c | 4 +- >> >> drivers/media/platform/davinci/vpif_capture.c | 16 ++++---- >> >> drivers/media/platform/exynos4-is/fimc-is.c | 8 ++-- >> >> drivers/media/platform/exynos4-is/fimc-lite.c | 3 +- >> >> drivers/media/platform/exynos4-is/media-dev.c | 8 ++-- >> >> drivers/media/platform/exynos4-is/mipi-csis.c | 4 +- >> >> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 +-- >> >> drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 8 ++-- >> >> drivers/media/platform/omap3isp/isp.c | 8 ++-- >> >> drivers/media/platform/pxa_camera.c | 2 +- >> >> drivers/media/platform/rcar-vin/rcar-core.c | 4 +- >> >> drivers/media/platform/soc_camera/soc_camera.c | 6 +-- >> >> drivers/media/platform/xilinx/xilinx-vipp.c | 52 +++++++++++++------------- >> >> drivers/media/v4l2-core/v4l2-async.c | 4 +- >> >> drivers/media/v4l2-core/v4l2-clk.c | 3 +- >> >> include/media/v4l2-clk.h | 4 +- >> >> 19 files changed, 71 insertions(+), 83 deletions(-) >> > >> >> diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c >> >> index ac4704388920..9233ad0b1b6b 100644 >> >> --- a/drivers/media/platform/xilinx/xilinx-vipp.c >> >> +++ b/drivers/media/platform/xilinx/xilinx-vipp.c >> > >> >> @@ -144,9 +144,8 @@ static int xvip_graph_build_one(struct xvip_composite_device *xdev, >> >> remote = ent->entity; >> >> >> >> if (link.remote_port >= remote->num_pads) { >> >> - dev_err(xdev->dev, "invalid port number %u on %s\n", >> >> - link.remote_port, >> >> - to_of_node(link.remote_node)->full_name); >> >> + dev_err(xdev->dev, "invalid port number %u on %pOF\n", >> >> + link.remote_port, link.remote_node); >> > >> > Shouldn't there be to_of_node(link.remote_node) instead of link.remote_node ? >> >> Humm, yes. I thought I fixed that. > > After such fix, I'm OK with this patch. I'll send a new version. I think I'll send a revert of the referenced commit. It won't apply cleanly, but at least it will capture the change in behavior and why it was wrong. > Are you planning to apply it on your tree, or via the media one? > > I guess it is probably better to apply via media, in order to avoid > conflicts with other changes. Yes, you can take it. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Thu, 20 Jul 2017 09:06:01 -0500 Subject: [PATCH] media: Convert to using %pOF instead of full_name In-Reply-To: <20170720081508.33563afe@vento.lan> References: <20170718214339.7774-33-robh@kernel.org> <564a6768-3b23-6dc7-ecb5-cb4f4359b633@samsung.com> <20170720081508.33563afe@vento.lan> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jul 20, 2017 at 6:15 AM, Mauro Carvalho Chehab wrote: > Em Wed, 19 Jul 2017 11:02:01 -0500 > Rob Herring escreveu: > >> On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki >> wrote: >> > On 07/18/2017 11:43 PM, Rob Herring wrote: >> >> Now that we have a custom printf format specifier, convert users of >> >> full_name to use %pOF instead. This is preparation to remove storing >> >> of the full path string for each node. >> >> >> >> Signed-off-by: Rob Herring >> > >> >> --- >> >> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 3 +- >> >> drivers/media/i2c/s5k5baf.c | 7 ++-- >> >> drivers/media/platform/am437x/am437x-vpfe.c | 4 +- >> >> drivers/media/platform/atmel/atmel-isc.c | 4 +- >> >> drivers/media/platform/davinci/vpif_capture.c | 16 ++++---- >> >> drivers/media/platform/exynos4-is/fimc-is.c | 8 ++-- >> >> drivers/media/platform/exynos4-is/fimc-lite.c | 3 +- >> >> drivers/media/platform/exynos4-is/media-dev.c | 8 ++-- >> >> drivers/media/platform/exynos4-is/mipi-csis.c | 4 +- >> >> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 +-- >> >> drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 8 ++-- >> >> drivers/media/platform/omap3isp/isp.c | 8 ++-- >> >> drivers/media/platform/pxa_camera.c | 2 +- >> >> drivers/media/platform/rcar-vin/rcar-core.c | 4 +- >> >> drivers/media/platform/soc_camera/soc_camera.c | 6 +-- >> >> drivers/media/platform/xilinx/xilinx-vipp.c | 52 +++++++++++++------------- >> >> drivers/media/v4l2-core/v4l2-async.c | 4 +- >> >> drivers/media/v4l2-core/v4l2-clk.c | 3 +- >> >> include/media/v4l2-clk.h | 4 +- >> >> 19 files changed, 71 insertions(+), 83 deletions(-) >> > >> >> diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c >> >> index ac4704388920..9233ad0b1b6b 100644 >> >> --- a/drivers/media/platform/xilinx/xilinx-vipp.c >> >> +++ b/drivers/media/platform/xilinx/xilinx-vipp.c >> > >> >> @@ -144,9 +144,8 @@ static int xvip_graph_build_one(struct xvip_composite_device *xdev, >> >> remote = ent->entity; >> >> >> >> if (link.remote_port >= remote->num_pads) { >> >> - dev_err(xdev->dev, "invalid port number %u on %s\n", >> >> - link.remote_port, >> >> - to_of_node(link.remote_node)->full_name); >> >> + dev_err(xdev->dev, "invalid port number %u on %pOF\n", >> >> + link.remote_port, link.remote_node); >> > >> > Shouldn't there be to_of_node(link.remote_node) instead of link.remote_node ? >> >> Humm, yes. I thought I fixed that. > > After such fix, I'm OK with this patch. I'll send a new version. I think I'll send a revert of the referenced commit. It won't apply cleanly, but at least it will capture the change in behavior and why it was wrong. > Are you planning to apply it on your tree, or via the media one? > > I guess it is probably better to apply via media, in order to avoid > conflicts with other changes. Yes, you can take it. Rob