From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966885AbdADUlB (ORCPT ); Wed, 4 Jan 2017 15:41:01 -0500 Received: from mail.kernel.org ([198.145.29.136]:39216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936065AbdADUk7 (ORCPT ); Wed, 4 Jan 2017 15:40:59 -0500 MIME-Version: 1.0 In-Reply-To: <529b-586c3500-5-5e05b080@98620974> References: <20170103225127.jn36tatufdfz2k5q@rob-hp-laptop> <529b-586c3500-5-5e05b080@98620974> From: Rob Herring Date: Wed, 4 Jan 2017 14:39:50 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V7 1/4] Documentation/devicetree/bindings: b850v3_lvds_dp To: Peter Senna Tschudin Cc: Jiri Slaby , dri-devel , Martyn Welch , Takashi Iwai , Russell King , Kumar Gala , Peter Senna Tschudin , Archit Taneja , Fabio Estevam , Ian Campbell , David Miller , Mark Rutland , Russell King , "kernel@pengutronix.de" , enric.balletbo@collabora.com, Mauro Carvalho Chehab , Peter Senna Tschudin , Thierry Reding , Greg Kroah-Hartman , Philipp Zabel , Andrew Morton , "linux-kernel@vger.kernel.org" , Javier Martinez Canillas , "devicetree@vger.kernel.org" , martin.donnelly@ge.com, Shawn Guo , "linux-arm-kernel@lists.infradead.org" , Enric Balletbo i Serra , Pawel Moll , David Airlie , Yakir Yang , "heiko@sntech.de" , Thierry Reding , Daniel Vetter , Guenter Roeck Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 3, 2017 at 5:34 PM, Peter Senna Tschudin wrote: > Hi Rob, > > Thank you for the review. > > On 03 January, 2017 23:51 CET, Rob Herring wrote: > >> On Sun, Jan 01, 2017 at 09:24:29PM +0100, Peter Senna Tschudin wrote: >> > Devicetree bindings documentation for the GE B850v3 LVDS/DP++ >> > display bridge. >> > >> > Cc: Martyn Welch >> > Cc: Martin Donnelly >> > Cc: Javier Martinez Canillas >> > Cc: Enric Balletbo i Serra >> > Cc: Philipp Zabel >> > Cc: Rob Herring >> > Cc: Fabio Estevam >> > Signed-off-by: Peter Senna Tschudin >> > --- >> > There was an Acked-by from Rob Herring for V6, but I changed >> > the bindings to use i2c_new_secondary_device() so I removed it from the commit >> > message. >> > >> > .../devicetree/bindings/ge/b850v3-lvds-dp.txt | 39 ++++++++++++++++++++++ >> >> Generally, bindings are not organized by vendor. Put in >> bindings/display/bridge/... instead. > > Will change that. > >> >> > 1 file changed, 39 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt >> > >> > diff --git a/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt >> > new file mode 100644 >> > index 0000000..1bc6ebf >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt >> > @@ -0,0 +1,39 @@ >> > +Driver for GE B850v3 LVDS/DP++ display bridge >> > + >> > +Required properties: >> > + - compatible : should be "ge,b850v3-lvds-dp". >> >> Isn't '-lvds-dp' redundant? The part# should be enough. > > b850v3 is the name of the product, this is why the proposed name. What about, b850v3-dp2 dp2 indicating the second DP output? Humm, b850v3 is the board name? This node should be the name of the bridge chip. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH V7 1/4] Documentation/devicetree/bindings: b850v3_lvds_dp Date: Wed, 4 Jan 2017 14:39:50 -0600 Message-ID: References: <20170103225127.jn36tatufdfz2k5q@rob-hp-laptop> <529b-586c3500-5-5e05b080@98620974> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <529b-586c3500-5-5e05b080@98620974> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Senna Tschudin Cc: Jiri Slaby , dri-devel , Martyn Welch , Takashi Iwai , Russell King , Kumar Gala , Peter Senna Tschudin , Archit Taneja , Fabio Estevam , Ian Campbell , David Miller , Mark Rutland , Russell King , "kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" , enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, Mauro Carvalho Chehab , Peter Senna Tschudin , Thierry Reding , Greg Kroah-Hartman List-Id: devicetree@vger.kernel.org On Tue, Jan 3, 2017 at 5:34 PM, Peter Senna Tschudin wrote: > Hi Rob, > > Thank you for the review. > > On 03 January, 2017 23:51 CET, Rob Herring wrote: > >> On Sun, Jan 01, 2017 at 09:24:29PM +0100, Peter Senna Tschudin wrote: >> > Devicetree bindings documentation for the GE B850v3 LVDS/DP++ >> > display bridge. >> > >> > Cc: Martyn Welch >> > Cc: Martin Donnelly >> > Cc: Javier Martinez Canillas >> > Cc: Enric Balletbo i Serra >> > Cc: Philipp Zabel >> > Cc: Rob Herring >> > Cc: Fabio Estevam >> > Signed-off-by: Peter Senna Tschudin >> > --- >> > There was an Acked-by from Rob Herring for V6, but I changed >> > the bindings to use i2c_new_secondary_device() so I removed it from the commit >> > message. >> > >> > .../devicetree/bindings/ge/b850v3-lvds-dp.txt | 39 ++++++++++++++++++++++ >> >> Generally, bindings are not organized by vendor. Put in >> bindings/display/bridge/... instead. > > Will change that. > >> >> > 1 file changed, 39 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt >> > >> > diff --git a/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt >> > new file mode 100644 >> > index 0000000..1bc6ebf >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt >> > @@ -0,0 +1,39 @@ >> > +Driver for GE B850v3 LVDS/DP++ display bridge >> > + >> > +Required properties: >> > + - compatible : should be "ge,b850v3-lvds-dp". >> >> Isn't '-lvds-dp' redundant? The part# should be enough. > > b850v3 is the name of the product, this is why the proposed name. What about, b850v3-dp2 dp2 indicating the second DP output? Humm, b850v3 is the board name? This node should be the name of the bridge chip. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Wed, 4 Jan 2017 14:39:50 -0600 Subject: [PATCH V7 1/4] Documentation/devicetree/bindings: b850v3_lvds_dp In-Reply-To: <529b-586c3500-5-5e05b080@98620974> References: <20170103225127.jn36tatufdfz2k5q@rob-hp-laptop> <529b-586c3500-5-5e05b080@98620974> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jan 3, 2017 at 5:34 PM, Peter Senna Tschudin wrote: > Hi Rob, > > Thank you for the review. > > On 03 January, 2017 23:51 CET, Rob Herring wrote: > >> On Sun, Jan 01, 2017 at 09:24:29PM +0100, Peter Senna Tschudin wrote: >> > Devicetree bindings documentation for the GE B850v3 LVDS/DP++ >> > display bridge. >> > >> > Cc: Martyn Welch >> > Cc: Martin Donnelly >> > Cc: Javier Martinez Canillas >> > Cc: Enric Balletbo i Serra >> > Cc: Philipp Zabel >> > Cc: Rob Herring >> > Cc: Fabio Estevam >> > Signed-off-by: Peter Senna Tschudin >> > --- >> > There was an Acked-by from Rob Herring for V6, but I changed >> > the bindings to use i2c_new_secondary_device() so I removed it from the commit >> > message. >> > >> > .../devicetree/bindings/ge/b850v3-lvds-dp.txt | 39 ++++++++++++++++++++++ >> >> Generally, bindings are not organized by vendor. Put in >> bindings/display/bridge/... instead. > > Will change that. > >> >> > 1 file changed, 39 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt >> > >> > diff --git a/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt >> > new file mode 100644 >> > index 0000000..1bc6ebf >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt >> > @@ -0,0 +1,39 @@ >> > +Driver for GE B850v3 LVDS/DP++ display bridge >> > + >> > +Required properties: >> > + - compatible : should be "ge,b850v3-lvds-dp". >> >> Isn't '-lvds-dp' redundant? The part# should be enough. > > b850v3 is the name of the product, this is why the proposed name. What about, b850v3-dp2 dp2 indicating the second DP output? Humm, b850v3 is the board name? This node should be the name of the bridge chip. Rob