All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Mark Zhang <markz@nvidia.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Lee Jones <lee.jones@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3 2/4] mfd: max77620: add documentation for backup battery charging
Date: Tue, 19 Feb 2019 09:18:22 -0600	[thread overview]
Message-ID: <CAL_JsqJkw1Ti7Jdz_1oqGHarM1aUs3odQW37SUrKZUJq6hpDsw@mail.gmail.com> (raw)
In-Reply-To: <91d3d8f8-0b96-c442-5674-3eff8209848b@nvidia.com>

On Mon, Feb 18, 2019 at 8:07 PM Mark Zhang <markz@nvidia.com> wrote:
>
> On 2/19/2019 2:06 AM, Rob Herring wrote:
> > On Tue, Feb 12, 2019 at 12:44 AM Mark Zhang <markz@nvidia.com> wrote:
> >>
> >> Adding documentation for 3 new backup battery charging dts
> >> properties:
> >> - maxim,charging-current-microamp
> >> - maxim,charging-voltage-microvolt
> >> - maxim,output-resister-ohms
> >
> > What's the difference between the 77620 and 77650 as there's patches
> > on the list for the 77650 too. The properties are similar, but seems
> > to be main vs. backup battery charger. We should have common
> > properties for this.
>
> Rob, it's different. The RTC in max77620 is supplied from a backup
> battery and consumes 2.0uA (IBBATT) when no other power sources are
> available. So unlike max77620 battery charging, which provides features
> like:
>
> static enum power_supply_property max77650_charger_properties[] = {
>         POWER_SUPPLY_PROP_STATUS,
>         POWER_SUPPLY_PROP_ONLINE,
>         POWER_SUPPLY_PROP_CHARGE_TYPE
> };
>
> For backup battery charging in max77620, what we can do is just setting
> those 3 parameters. We don't know whether it's charging, whether the
> backup battery is online, the percentage of the charging progress, and
> etc. That's why I mentioned before that it's not appropriate to create
> it as a power supply driver.

Maybe so, but that's all outside the scope of the binding. Both
bindings define charging current and voltage. And other vendor's
chargers likely need the same parameters, too. So there's no reason to
have different properties.

Rob

  parent reply	other threads:[~2019-02-19 15:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-12  6:43 [PATCH v3 0/4] Add max77620 charging & low battery support Mark Zhang
2019-02-12  6:43 ` Mark Zhang
2019-02-12  6:43 ` [PATCH v3 1/4] mfd: max77620: Add backup battery charger support Mark Zhang
2019-02-12  6:43   ` Mark Zhang
2019-02-12  8:06   ` Lee Jones
2019-02-12  6:43 ` [PATCH v3 2/4] mfd: max77620: add documentation for backup battery charging Mark Zhang
2019-02-12  6:43   ` Mark Zhang
2019-02-18 18:06   ` Rob Herring
2019-02-19  2:07     ` Mark Zhang
2019-02-19  2:07       ` Mark Zhang
2019-02-19  2:09       ` Mark Zhang
2019-02-19  2:09         ` Mark Zhang
2019-02-19 15:18       ` Rob Herring [this message]
2019-02-12  6:43 ` [PATCH v3 3/4] mfd: max77620: Add low battery monitor support Mark Zhang
2019-02-12  6:43   ` Mark Zhang
2019-02-12  6:43 ` [PATCH v3 4/4] mfd: max77620: add documentation for low battery monitoring Mark Zhang
2019-02-12  6:43   ` Mark Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqJkw1Ti7Jdz_1oqGHarM1aUs3odQW37SUrKZUJq6hpDsw@mail.gmail.com \
    --to=robh+dt@kernel.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=markz@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.