From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62153C43381 for ; Wed, 13 Mar 2019 20:07:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D66520854 for ; Wed, 13 Mar 2019 20:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552507641; bh=BA8bzZoS2/gf19hPjFVcEe3fH5ko7ryd4i4aQnYm86Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=PSzhycD8S43dLahrKsxlGO22NSQnM8kcXbgRmc0Q6RH8y7n8RzZlNLPTmmbQSs/0W +rCxrE7idgawBh/pVVBCdvT9f5GRn0LFhbjIawJiqdgO1jxMpRGe9B53xzUg61agjl LvZGLbNzySsEMDHKDPss2HnFqdl7aK6IyT5fAGfo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727213AbfCMUHT (ORCPT ); Wed, 13 Mar 2019 16:07:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:39496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726962AbfCMUHT (ORCPT ); Wed, 13 Mar 2019 16:07:19 -0400 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CAF262146E; Wed, 13 Mar 2019 20:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552507638; bh=BA8bzZoS2/gf19hPjFVcEe3fH5ko7ryd4i4aQnYm86Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=E0jZjHZFFn2txB/TSwlE12nW0TzYPzh62xRmsd8yfsho1iNmwvSsIgOc3ikgD7dax GrwnZqKodUYVsdcs+ML1oSkpjh2ukrnXO0RdCFRSop3bV1GDLn08YyrzndaFhJ21xE fh+BGSsQcZ5vLytbz432D4DTfAxeJZTv42ahLE8s= Received: by mail-qt1-f180.google.com with SMTP id z17so3474843qtn.4; Wed, 13 Mar 2019 13:07:17 -0700 (PDT) X-Gm-Message-State: APjAAAUZsgjgXit/X6N/fv9nCoJy8Z83qweW2EL304myfJ0Bi0/9Rp87 vZyqE/tfk4+m51SgtGoPIGnM65rrq9bMPq//JA== X-Google-Smtp-Source: APXvYqw87Ro29I5U0HwuCjzmE8G+DGicpVQXY2flFbFKvRF4cXOCzipWaMFB30K33IHVPOjUnCKaNkxsJnjxdmKnTS8= X-Received: by 2002:a0c:c585:: with SMTP id a5mr10988734qvj.246.1552507637038; Wed, 13 Mar 2019 13:07:17 -0700 (PDT) MIME-Version: 1.0 References: <20190121173835.21173-1-nava.manne@xilinx.com> <20190121173835.21173-7-nava.manne@xilinx.com> <20190121154928.GA32129@bogus> In-Reply-To: From: Rob Herring Date: Wed, 13 Mar 2019 15:07:04 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 6/6] dt-bindings: fpga: Add bindings for ZynqMP fpga driver To: Nava kishore Manne Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Moritz Fischer , Alan Tull , "linux-kernel@vger.kernel.org" , Jolly Shah , Rajan Vaja , Michal Simek , "linux-arm-kernel@lists.infradead.org" , "chinnikishore369@gmail.com" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 5, 2019 at 3:42 AM Nava kishore Manne wrote: > > Hi Rob, > > Thanks for the quick response. > Please find my response inline. > > > -----Original Message----- > > From: Rob Herring [mailto:robh@kernel.org] > > Sent: Monday, March 4, 2019 10:57 PM > > To: Nava kishore Manne > > Cc: mark.rutland@arm.com; Michal Simek ; Rajan Vaja > > ; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; devicetree@vger.kernel.org; Jolly Shah > > ; chinnikishore369@gmail.com > > Subject: Re: [PATCH v3 6/6] dt-bindings: fpga: Add bindings for ZynqMP fpga > > driver Please fix your mail program to... > > On Mon, Mar 4, 2019 at 5:35 AM Nava kishore Manne > > wrote: ...use this style reply header. [...] > > > Device Tree Example for Full Reconfiguration > > > ============================================ > > > > > > Live Device Tree contains: > > > > > > zynqmp_pcap: pcap { > > > compatible = "xlnx,zynqmp-pcap-fpga"; > > > }; > > > > > > fpga_region0: fpga-region0 { > > > > This should be a child of pcap. > > > AFAIK we can't put the fpga-region as a child of pcap as both are independent and they refered to each other using phandlers > I have made this changes by looking into the below reference doc. > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/fpga/fpga-region.txt Indeed. But having them a as child of the firmware node doesn't make sense either. Putting them at the top level would make more sense. I don't recall why we didn't make them a child. Maybe regions can span multiple bridges in the case with bridges. > > > compatible = "fpga-region"; > > > fpga-mgr = <&zynqmp_pcap>; > > > #address-cells = <0x1>; > > > #size-cells = <0x1>; > > > ranges; > > > }; > > > > > > DT Overlay contains: > > > > Don't show overlays in examples. Just show a final tree (i.e. base with overlay > > applied). > > To get a better picture for the users i have added this example node with overlays > I feel it's good to have this info because it will not impact the functionality of PCAP node. Then feel free to document this somewhere else. As we move to schema documents, your examples will have to compile and validate against the schema. I don't want to add applying overlays to the mix. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 6/6] dt-bindings: fpga: Add bindings for ZynqMP fpga driver Date: Wed, 13 Mar 2019 15:07:04 -0500 Message-ID: References: <20190121173835.21173-1-nava.manne@xilinx.com> <20190121173835.21173-7-nava.manne@xilinx.com> <20190121154928.GA32129@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Nava kishore Manne Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Moritz Fischer , Alan Tull , "linux-kernel@vger.kernel.org" , Jolly Shah , Rajan Vaja , Michal Simek , "linux-arm-kernel@lists.infradead.org" , "chinnikishore369@gmail.com" List-Id: devicetree@vger.kernel.org On Tue, Mar 5, 2019 at 3:42 AM Nava kishore Manne wrote: > > Hi Rob, > > Thanks for the quick response. > Please find my response inline. > > > -----Original Message----- > > From: Rob Herring [mailto:robh@kernel.org] > > Sent: Monday, March 4, 2019 10:57 PM > > To: Nava kishore Manne > > Cc: mark.rutland@arm.com; Michal Simek ; Rajan Vaja > > ; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; devicetree@vger.kernel.org; Jolly Shah > > ; chinnikishore369@gmail.com > > Subject: Re: [PATCH v3 6/6] dt-bindings: fpga: Add bindings for ZynqMP fpga > > driver Please fix your mail program to... > > On Mon, Mar 4, 2019 at 5:35 AM Nava kishore Manne > > wrote: ...use this style reply header. [...] > > > Device Tree Example for Full Reconfiguration > > > ============================================ > > > > > > Live Device Tree contains: > > > > > > zynqmp_pcap: pcap { > > > compatible = "xlnx,zynqmp-pcap-fpga"; > > > }; > > > > > > fpga_region0: fpga-region0 { > > > > This should be a child of pcap. > > > AFAIK we can't put the fpga-region as a child of pcap as both are independent and they refered to each other using phandlers > I have made this changes by looking into the below reference doc. > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/fpga/fpga-region.txt Indeed. But having them a as child of the firmware node doesn't make sense either. Putting them at the top level would make more sense. I don't recall why we didn't make them a child. Maybe regions can span multiple bridges in the case with bridges. > > > compatible = "fpga-region"; > > > fpga-mgr = <&zynqmp_pcap>; > > > #address-cells = <0x1>; > > > #size-cells = <0x1>; > > > ranges; > > > }; > > > > > > DT Overlay contains: > > > > Don't show overlays in examples. Just show a final tree (i.e. base with overlay > > applied). > > To get a better picture for the users i have added this example node with overlays > I feel it's good to have this info because it will not impact the functionality of PCAP node. Then feel free to document this somewhere else. As we move to schema documents, your examples will have to compile and validate against the schema. I don't want to add applying overlays to the mix. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB750C43381 for ; Wed, 13 Mar 2019 20:07:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D1F020854 for ; Wed, 13 Mar 2019 20:07:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GcrtpKep"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="E0jZjHZF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D1F020854 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T6g9964CrIcsEhQ5dtxxKLJmGwFn8wHE8ti0iJC0QeY=; b=GcrtpKep3M0F3O voXEpHJbKxOlWC09ZhWbqB9YJhYFRvi1qipW+R3Ffq2QwGSEd6m/c8CgUszFGt3lfqd6srRzPbw0Z SXdNPUlDdIvQFvjKstJKHc3EZI5XPSdJQvq8dr7c5f1ZE17YsB6NYgauUGyAMXwqkt5tG7Y93PRYu p8RUTvezfX06eEr/1DktixHQFZkBmXPBjIDhRC33ePy/nyJRimOcpGM51pqIFr0sk4mV2ZwTj974B FFR+EI1tm649Mq0c0cM4j1zJDxTG0XaC6Xn4ARJHFLbjriu9CJWbRZ2tIMDI3V0/SiMPivfJeEISa KEmz2fkVTlqyRPa94awg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4A9q-00017b-Ce; Wed, 13 Mar 2019 20:07:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4A9m-00016Y-Df for linux-arm-kernel@lists.infradead.org; Wed, 13 Mar 2019 20:07:20 +0000 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D22732183F for ; Wed, 13 Mar 2019 20:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552507638; bh=BA8bzZoS2/gf19hPjFVcEe3fH5ko7ryd4i4aQnYm86Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=E0jZjHZFFn2txB/TSwlE12nW0TzYPzh62xRmsd8yfsho1iNmwvSsIgOc3ikgD7dax GrwnZqKodUYVsdcs+ML1oSkpjh2ukrnXO0RdCFRSop3bV1GDLn08YyrzndaFhJ21xE fh+BGSsQcZ5vLytbz432D4DTfAxeJZTv42ahLE8s= Received: by mail-qt1-f177.google.com with SMTP id z39so3493836qtz.0 for ; Wed, 13 Mar 2019 13:07:17 -0700 (PDT) X-Gm-Message-State: APjAAAXy+7INPwmSAvMNEGjOweRg1b4zRMi+CaTctLgiA1mBhUF60DNM afMOL6P64hVFESh5HFy10TWZIDnuaq4n5x76dA== X-Google-Smtp-Source: APXvYqw87Ro29I5U0HwuCjzmE8G+DGicpVQXY2flFbFKvRF4cXOCzipWaMFB30K33IHVPOjUnCKaNkxsJnjxdmKnTS8= X-Received: by 2002:a0c:c585:: with SMTP id a5mr10988734qvj.246.1552507637038; Wed, 13 Mar 2019 13:07:17 -0700 (PDT) MIME-Version: 1.0 References: <20190121173835.21173-1-nava.manne@xilinx.com> <20190121173835.21173-7-nava.manne@xilinx.com> <20190121154928.GA32129@bogus> In-Reply-To: From: Rob Herring Date: Wed, 13 Mar 2019 15:07:04 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 6/6] dt-bindings: fpga: Add bindings for ZynqMP fpga driver To: Nava kishore Manne X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190313_130718_500030_8F29B3B7 X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Moritz Fischer , Alan Tull , "linux-kernel@vger.kernel.org" , Jolly Shah , Rajan Vaja , Michal Simek , "linux-arm-kernel@lists.infradead.org" , "chinnikishore369@gmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 5, 2019 at 3:42 AM Nava kishore Manne wrote: > > Hi Rob, > > Thanks for the quick response. > Please find my response inline. > > > -----Original Message----- > > From: Rob Herring [mailto:robh@kernel.org] > > Sent: Monday, March 4, 2019 10:57 PM > > To: Nava kishore Manne > > Cc: mark.rutland@arm.com; Michal Simek ; Rajan Vaja > > ; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; devicetree@vger.kernel.org; Jolly Shah > > ; chinnikishore369@gmail.com > > Subject: Re: [PATCH v3 6/6] dt-bindings: fpga: Add bindings for ZynqMP fpga > > driver Please fix your mail program to... > > On Mon, Mar 4, 2019 at 5:35 AM Nava kishore Manne > > wrote: ...use this style reply header. [...] > > > Device Tree Example for Full Reconfiguration > > > ============================================ > > > > > > Live Device Tree contains: > > > > > > zynqmp_pcap: pcap { > > > compatible = "xlnx,zynqmp-pcap-fpga"; > > > }; > > > > > > fpga_region0: fpga-region0 { > > > > This should be a child of pcap. > > > AFAIK we can't put the fpga-region as a child of pcap as both are independent and they refered to each other using phandlers > I have made this changes by looking into the below reference doc. > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/fpga/fpga-region.txt Indeed. But having them a as child of the firmware node doesn't make sense either. Putting them at the top level would make more sense. I don't recall why we didn't make them a child. Maybe regions can span multiple bridges in the case with bridges. > > > compatible = "fpga-region"; > > > fpga-mgr = <&zynqmp_pcap>; > > > #address-cells = <0x1>; > > > #size-cells = <0x1>; > > > ranges; > > > }; > > > > > > DT Overlay contains: > > > > Don't show overlays in examples. Just show a final tree (i.e. base with overlay > > applied). > > To get a better picture for the users i have added this example node with overlays > I feel it's good to have this info because it will not impact the functionality of PCAP node. Then feel free to document this somewhere else. As we move to schema documents, your examples will have to compile and validate against the schema. I don't want to add applying overlays to the mix. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel