From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0381CC4707F for ; Thu, 27 May 2021 20:15:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA78C613F0 for ; Thu, 27 May 2021 20:15:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235576AbhE0URa (ORCPT ); Thu, 27 May 2021 16:17:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:36886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235519AbhE0UR3 (ORCPT ); Thu, 27 May 2021 16:17:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E7DEC613ED for ; Thu, 27 May 2021 20:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622146555; bh=tFekpgxnBCW9B8RjFMXNWQrv6Zb6ZGLs5ePDqpxSgdE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iLl0m0NLbslZM0fYdRh9f/XHszKTpjvV3fvA6TLGLe+DKtPcfmqqV63rzFWfD3CXR ncuR4EqDYj+HER4/N/LQI+0zVJFgbIJgsrce8TqCgzg6l46fOF77vMhwcwABC9PZ7M mh/oy9FKDIZ178Kn6vhDRMt7n1uDsstgCjOkJwFWi8zrZl1xaoOSORIk9QfhjokJY7 xJvGdZAO8KlTEj6hXxPSX77O0cM28mD19pjguTf7ax3IQbypBiO9rcsRrD+EsCmkAo 5ll+9PgChzS9hg9MjPRDMbKf+f7X4aYAIcMfX2eH+zHSxMmMoxj5SBHq7jZQ+Ll8ys fy5XKiGtMSriw== Received: by mail-ed1-f52.google.com with SMTP id e24so2191947eds.11 for ; Thu, 27 May 2021 13:15:55 -0700 (PDT) X-Gm-Message-State: AOAM531E1J+Rqxe2sIocVlpYi3iyalEfcvC+oce5p9skITD5COikD80L sKKH4hQvS8uYLpj3j8biaIoD1Tp4DmbNOrb9Iw== X-Google-Smtp-Source: ABdhPJxbZVBOsMqT/HqqfLaPGIKYmp2V8KOD8QColAH/Tj/AWClwoZF6Ap7huIY7UiAEGSL163TdSsAVhoDGI7/FX8Q= X-Received: by 2002:aa7:d893:: with SMTP id u19mr6286360edq.258.1622146554521; Thu, 27 May 2021 13:15:54 -0700 (PDT) MIME-Version: 1.0 References: <20210526182807.548118-1-sudeep.holla@arm.com> <20210526182807.548118-9-sudeep.holla@arm.com> <20210526183455.q6wmhm6qjggu65hs@bogus> In-Reply-To: <20210526183455.q6wmhm6qjggu65hs@bogus> From: Rob Herring Date: Thu, 27 May 2021 15:15:42 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 8/8] dt-bindings: firmware: arm,scmi: Convert to json schema To: Sudeep Holla Cc: devicetree@vger.kernel.org, linux-arm-kernel , Cristian Marussi , Florian Fainelli , Jim Quinlan , Etienne Carriere , Peter Hilber Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, May 26, 2021 at 1:35 PM Sudeep Holla wrote: > > On Wed, May 26, 2021 at 07:28:07PM +0100, Sudeep Holla wrote: > > Convert the old text format binding for System Control and Management Interface > > (SCMI) Message Protocol into the new and shiny YAML format. > > > > Cc: Rob Herring > > Cc: Cristian Marussi > > Cc: Florian Fainelli > > Cc: Jim Quinlan > > Cc: Etienne Carriere > > Cc: Peter Hilber > > Signed-off-by: Sudeep Holla > > --- > > .../devicetree/bindings/arm/arm,scmi.txt | 224 --------------- > > .../bindings/firmware/arm,scmi.yaml | 270 ++++++++++++++++++ > > 2 files changed, 270 insertions(+), 224 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/arm,scmi.txt > > create mode 100644 Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > > Hi, > > > > I have converted all the bindings except the below regulator part of the > > binding. This needs to be addressed before merging ofcourse. Just posting > > the remaining changes to get feedback and also ask suggestion for the below: > > > > scmi_voltage: protocol@17 { > > reg = <0x17>; > > regulators { > > regulator_devX: regulator@0 { > > reg = <0x0>; > > regulator-max-microvolt = <3300000>; > > }; > > > > regulator_devY: regulator@9 { > > reg = <0x9>; > > regulator-min-microvolt = <500000>; > > regulator-max-microvolt = <4200000>; > > }; > > }; > > }; > > > > I will reply with things I have tried separately to avoid confusion with this > > the patch here. > > > > Below is the patch I have tried. I even started without a separate binding > for scmi regulator. Irrespective of what I have tried so far, I keep getting > the same error, I even added '#address-cells' and '#size-cells' to the node > but makes no difference. > > Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml > Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:62.19-31: Warning (reg_format): /example-0/firmware/scmi/protocol@17/regulators/regulator@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) > Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:67.19-31: Warning (reg_format): /example-0/firmware/scmi/protocol@17/regulators/regulator@9:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) > Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:61.45-64.19: Warning (avoid_default_addr_size): /example-0/firmware/scmi/protocol@17/regulators/regulator@0: Relying on default #address-cells value > Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:61.45-64.19: Warning (avoid_default_addr_size): /example-0/firmware/scmi/protocol@17/regulators/regulator@0: Relying on default #size-cells value > Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:66.45-70.19: Warning (avoid_default_addr_size): /example-0/firmware/scmi/protocol@17/regulators/regulator@9: Relying on default #address-cells value > Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:66.45-70.19: Warning (avoid_default_addr_size): /example-0/firmware/scmi/protocol@17/regulators/regulator@9: Relying on default #size-cells value > Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml: Warning (unique_unit_address): Failed prerequisite 'avoid_default_addr_size' > CHECK Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml > > > Regards, > Sudeep > > --->8 > > diff --git c/Documentation/devicetree/bindings/firmware/arm,scmi.yaml i/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 36072585fc45..1fe23ef36adf 100644 > --- c/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ i/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -101,6 +101,10 @@ description: | > '#thermal-sensor-cells': > const: 1 > > + '^regulator@[0-9]+$': You need to create the whole hierarchy. This is defining 'regulator@*' nodes at the top level of the binding. You need 'regulators' property under 'protocol@??' and then this under 'regulators. Is the protocol number fixed? If so, you can add a 'protocol@17' property in addition to the pattern. > + type: object > + $ref: "/schemas/regulator/arm,scmi-regulator.yaml#" > + From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0E6DC47089 for ; Thu, 27 May 2021 20:17:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDA856054E for ; Thu, 27 May 2021 20:17:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDA856054E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uyXXvig5IdT6CxDdAS0pOr3+Qu43I9cYJQvfPILITJ4=; b=X+4tJh238KCrxQ 918zgY6WFj6AVghzDUr2y2Ytprv+414nzntrQRKHqk0KNszDZAk4/np0jtn+f2Ug+I4YOjjRaqdyQ rBcpRoUKDY0ad5ZqzKZ1dbsMDmXwdKNUaYWEz1FCEgnQffcKmDBsgRolaZptjxAwJK+BBBUmyyXib oJWr557O7BBZTSyl0P1A9XwfhPp50ONyrRIg9kndcGCaliBrDKvfF8PgxUQfVgw+utVRkfku+OTbc y/D6s6Q/+gx++NPOB5pK01lT25hGCvqAIjqy4sGOlI3DlJmyZFNn0MyN0nCRxPOQ9k/qTsz9LBVlg 5I1lDzlg12fsj7JZ5K1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmMQC-009FG8-Rr; Thu, 27 May 2021 20:16:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmMQ8-009FEm-PS for linux-arm-kernel@lists.infradead.org; Thu, 27 May 2021 20:15:58 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E0637613D8 for ; Thu, 27 May 2021 20:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622146555; bh=tFekpgxnBCW9B8RjFMXNWQrv6Zb6ZGLs5ePDqpxSgdE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iLl0m0NLbslZM0fYdRh9f/XHszKTpjvV3fvA6TLGLe+DKtPcfmqqV63rzFWfD3CXR ncuR4EqDYj+HER4/N/LQI+0zVJFgbIJgsrce8TqCgzg6l46fOF77vMhwcwABC9PZ7M mh/oy9FKDIZ178Kn6vhDRMt7n1uDsstgCjOkJwFWi8zrZl1xaoOSORIk9QfhjokJY7 xJvGdZAO8KlTEj6hXxPSX77O0cM28mD19pjguTf7ax3IQbypBiO9rcsRrD+EsCmkAo 5ll+9PgChzS9hg9MjPRDMbKf+f7X4aYAIcMfX2eH+zHSxMmMoxj5SBHq7jZQ+Ll8ys fy5XKiGtMSriw== Received: by mail-ed1-f52.google.com with SMTP id df21so2284707edb.3 for ; Thu, 27 May 2021 13:15:55 -0700 (PDT) X-Gm-Message-State: AOAM530sc2RgMvVoCAV/vk7vecX8td4CVK88OaqOFTuThGr+pnI6gVxz FyTidgzF4lIxMOc2uoPNXCJSYy7VhckRcA8kdg== X-Google-Smtp-Source: ABdhPJxbZVBOsMqT/HqqfLaPGIKYmp2V8KOD8QColAH/Tj/AWClwoZF6Ap7huIY7UiAEGSL163TdSsAVhoDGI7/FX8Q= X-Received: by 2002:aa7:d893:: with SMTP id u19mr6286360edq.258.1622146554521; Thu, 27 May 2021 13:15:54 -0700 (PDT) MIME-Version: 1.0 References: <20210526182807.548118-1-sudeep.holla@arm.com> <20210526182807.548118-9-sudeep.holla@arm.com> <20210526183455.q6wmhm6qjggu65hs@bogus> In-Reply-To: <20210526183455.q6wmhm6qjggu65hs@bogus> From: Rob Herring Date: Thu, 27 May 2021 15:15:42 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 8/8] dt-bindings: firmware: arm, scmi: Convert to json schema To: Sudeep Holla Cc: devicetree@vger.kernel.org, linux-arm-kernel , Cristian Marussi , Florian Fainelli , Jim Quinlan , Etienne Carriere , Peter Hilber X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_131556_893816_BE304CB4 X-CRM114-Status: GOOD ( 25.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 26, 2021 at 1:35 PM Sudeep Holla wrote: > > On Wed, May 26, 2021 at 07:28:07PM +0100, Sudeep Holla wrote: > > Convert the old text format binding for System Control and Management Interface > > (SCMI) Message Protocol into the new and shiny YAML format. > > > > Cc: Rob Herring > > Cc: Cristian Marussi > > Cc: Florian Fainelli > > Cc: Jim Quinlan > > Cc: Etienne Carriere > > Cc: Peter Hilber > > Signed-off-by: Sudeep Holla > > --- > > .../devicetree/bindings/arm/arm,scmi.txt | 224 --------------- > > .../bindings/firmware/arm,scmi.yaml | 270 ++++++++++++++++++ > > 2 files changed, 270 insertions(+), 224 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/arm,scmi.txt > > create mode 100644 Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > > > Hi, > > > > I have converted all the bindings except the below regulator part of the > > binding. This needs to be addressed before merging ofcourse. Just posting > > the remaining changes to get feedback and also ask suggestion for the below: > > > > scmi_voltage: protocol@17 { > > reg = <0x17>; > > regulators { > > regulator_devX: regulator@0 { > > reg = <0x0>; > > regulator-max-microvolt = <3300000>; > > }; > > > > regulator_devY: regulator@9 { > > reg = <0x9>; > > regulator-min-microvolt = <500000>; > > regulator-max-microvolt = <4200000>; > > }; > > }; > > }; > > > > I will reply with things I have tried separately to avoid confusion with this > > the patch here. > > > > Below is the patch I have tried. I even started without a separate binding > for scmi regulator. Irrespective of what I have tried so far, I keep getting > the same error, I even added '#address-cells' and '#size-cells' to the node > but makes no difference. > > Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml > Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:62.19-31: Warning (reg_format): /example-0/firmware/scmi/protocol@17/regulators/regulator@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) > Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:67.19-31: Warning (reg_format): /example-0/firmware/scmi/protocol@17/regulators/regulator@9:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) > Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format' > Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:61.45-64.19: Warning (avoid_default_addr_size): /example-0/firmware/scmi/protocol@17/regulators/regulator@0: Relying on default #address-cells value > Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:61.45-64.19: Warning (avoid_default_addr_size): /example-0/firmware/scmi/protocol@17/regulators/regulator@0: Relying on default #size-cells value > Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:66.45-70.19: Warning (avoid_default_addr_size): /example-0/firmware/scmi/protocol@17/regulators/regulator@9: Relying on default #address-cells value > Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:66.45-70.19: Warning (avoid_default_addr_size): /example-0/firmware/scmi/protocol@17/regulators/regulator@9: Relying on default #size-cells value > Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml: Warning (unique_unit_address): Failed prerequisite 'avoid_default_addr_size' > CHECK Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml > > > Regards, > Sudeep > > --->8 > > diff --git c/Documentation/devicetree/bindings/firmware/arm,scmi.yaml i/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 36072585fc45..1fe23ef36adf 100644 > --- c/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ i/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -101,6 +101,10 @@ description: | > '#thermal-sensor-cells': > const: 1 > > + '^regulator@[0-9]+$': You need to create the whole hierarchy. This is defining 'regulator@*' nodes at the top level of the binding. You need 'regulators' property under 'protocol@??' and then this under 'regulators. Is the protocol number fixed? If so, you can add a 'protocol@17' property in addition to the pattern. > + type: object > + $ref: "/schemas/regulator/arm,scmi-regulator.yaml#" > + _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel